[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix

2019-05-26 Thread Rohit Koushal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848629#comment-16848629 ] Rohit Koushal commented on OFBIZ-11056: --- Thanks [~jacques.le.roux]. (y) > Fix duplicate entry in

[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-05-26 Thread Swapnil M Mane (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625 ] Swapnil M Mane edited comment on OFBIZ-10145 at 5/27/19 5:41 AM: - Thanks

[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-05-26 Thread Swapnil M Mane (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625 ] Swapnil M Mane commented on OFBIZ-10145: Thanks [~jacques.le.roux], you are correct for R17

[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-05-26 Thread Swapnil M Mane (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: init-gradle-wrapper.sh init-gradle-wrapper-trunk-and-18.sh >

[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2019-05-26 Thread Shi Jinghai (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848557#comment-16848557 ] Shi Jinghai commented on OFBIZ-11069: - Hi Jacques and Pierre, Thanks for the comments and votes!

[jira] [Closed] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme

2019-05-26 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10797. - Thanks Ayushi Rathod for reporting the issue and providing the patch. > CSS Styling for Party

[jira] [Updated] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme

2019-05-26 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10797: -- Sprint: OFBiz Community Day (May 2019) > CSS Styling for Party Content progress bar is wrong

[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working

2019-05-26 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7257: - Flags: Patch > View Image button on order detail page is not working >

[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2019-05-26 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848426#comment-16848426 ] Devanshu Vyas commented on OFBIZ-7257: -- As per the listed implementation plan, I have prepared a

[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working

2019-05-26 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7257: - Attachment: OFBIZ-7257.patch > View Image button on order detail page is not working >

[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848424#comment-16848424 ] Pierre Smits commented on OFBIZ-11017: -- If it is not a priority for you, you should consider

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848421#comment-16848421 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 12:53 PM: --- You keep

[jira] [Commented] (OFBIZ-10733) HTML Code is rendering in Sales Invoice

2019-05-26 Thread Sanjay Yadav (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848423#comment-16848423 ] Sanjay Yadav commented on OFBIZ-10733: -- Thanks Chandrashekhar. > HTML Code is rendering in Sales

[jira] [Updated] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7963: Description: As ever the devil is in details. There is no longer a Sonar plugin available

[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Sprint: OFBiz Community Day (May 2019) > Refactor EntityDataLoadContainer >

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848421#comment-16848421 ] Pierre Smits commented on OFBIZ-7963: - You keep mentioning to have the sonar task to be available for

[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848418#comment-16848418 ] Jacques Le Roux commented on OFBIZ-11017: - Yes, but not a 1st priority. When I speak about side

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848415#comment-16848415 ] Jacques Le Roux commented on OFBIZ-7963: bq. Due to secret key(s) required by SonarCloud.io this

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux edited comment on OFBIZ-7963 at 5/26/19 12:14 PM: --

[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Attachment: OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch

[jira] [Created] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11070: -- Summary: Refactor EntityDataLoadContainer Key: OFBIZ-11070 URL: https://issues.apache.org/jira/browse/OFBIZ-11070 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-9382) Enhance the BIRT plugin with an install routine to load necessary data

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9382: Description: After installing the BIRT plugin, the user has to load some data in the right order

[jira] [Updated] (OFBIZ-9382) Enhance the BIRT plugin with an install routine to load necessary data

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9382: Labels: bi dwh reporting (was: ) > Enhance the BIRT plugin with an install routine to load

[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848411#comment-16848411 ] Pierre Smits commented on OFBIZ-11017: -- Jacques, Are you still working this ticket? > In demo

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848402#comment-16848402 ] Pierre Smits commented on OFBIZ-7963: - Jacques, Due to secret key(s) required by SonarCloud.io this

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux edited comment on OFBIZ-7963 at 5/26/19 10:52 AM: --

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux commented on OFBIZ-7963: Thanks Pierre, # was almost already clear to me, I only

[jira] [Closed] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11064. --- Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Pawan, Your patch is

[jira] [Assigned] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11064: --- Assignee: Jacques Le Roux (was: Pawan Verma) > Use Groovy Truth instead of

[jira] [Updated] (OFBIZ-11066) Have a service to load records in the organisation dimension

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11066: - Attachment: OFBIZ-11066-OrgDimService.patch > Have a service to load records in the

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 10:09 AM: --- Jacques,

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 10:08 AM: --- Jacques,

[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 9:59 AM: -- Jacques, To

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits commented on OFBIZ-7963: - Jacques, To clarify some things: # The Jenkins+Sonar aspect

[jira] [Updated] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy

2019-05-26 Thread Pawan Verma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11064: Attachment: OFBIZ-11064.patch > Use Groovy Truth instead of UtilValidate Class in Groovy >

[jira] [Commented] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy

2019-05-26 Thread Pawan Verma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848384#comment-16848384 ] Pawan Verma commented on OFBIZ-11064: - Thanks, [~jacques.le.roux] for the review. My bad! I have

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848380#comment-16848380 ] Jacques Le Roux commented on OFBIZ-7963: bq. What are you talking about when stating: 'if it

[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848365#comment-16848365 ] Pierre Smits commented on OFBIZ-11069: -- Hi Jinghai, +1 on introducing the coalesce functionality.

[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848363#comment-16848363 ] Jacques Le Roux commented on OFBIZ-11069: - HI Jinghai, Sounds good to me: +1 > Add coalesce to

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848362#comment-16848362 ] Pierre Smits commented on OFBIZ-7963: - Agree to what? IIUC, the community already agreed to the fact

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848361#comment-16848361 ] Pierre Smits commented on OFBIZ-7963: - What are you talking about when stating: 'if it still works'?

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848357#comment-16848357 ] Jacques Le Roux commented on OFBIZ-7963: BTW if it still works and the community agrees about

[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848356#comment-16848356 ] Jacques Le Roux commented on OFBIZ-7963: Hi Pierre, Your last patch gives the same "result" than

[jira] [Comment Edited] (OFBIZ-10917) establish code analysis with Sonar

2019-05-26 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815141#comment-16815141 ] Jacques Le Roux edited comment on OFBIZ-10917 at 5/26/19 7:22 AM: -- Hi