[jira] [Commented] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels

2020-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028747#comment-17028747 ] ASF subversion and git services commented on OFBIZ-11134: - Commit

[jira] [Commented] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels

2020-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028740#comment-17028740 ] ASF subversion and git services commented on OFBIZ-11134: - Commit

[jira] [Commented] (OFBIZ-11337) replace pullPluginFromSvn with a git equivalent

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028584#comment-17028584 ] Jacques Le Roux commented on OFBIZ-11337: - Oops indeed, cool :) > replace pullPluginFromSvn

[jira] [Commented] (OFBIZ-11337) replace pullPluginFromSvn with a git equivalent

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028551#comment-17028551 ] Pierre Smits commented on OFBIZ-11337: -- It is. > replace pullPluginFromSvn with a git equivalent >

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028550#comment-17028550 ] Pierre Smits commented on OFBIZ-11205: -- Nor should we priviledge third-party developers over

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028548#comment-17028548 ] Pierre Smits commented on OFBIZ-11304: -- SonarCloud does a lot, in combination with CI. See latest

[jira] [Commented] (OFBIZ-11337) replace pullPluginFromSvn with a git equivalent

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028541#comment-17028541 ] Jacques Le Roux commented on OFBIZ-11337: - Should this not be under OFBIZ-11268 ? > replace

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028539#comment-17028539 ] Jacques Le Roux commented on OFBIZ-11304: - It's already in Buildbot, but not as a pre-push. Do

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028538#comment-17028538 ] Jacques Le Roux commented on OFBIZ-11205: - Thanks Mathieu, that's help for sure. Pierre, yes

[jira] [Commented] (OFBIZ-7112) EntityUtilProperties

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028516#comment-17028516 ] Jacques Le Roux commented on OFBIZ-7112: OK, I have a FF group of tabs w/ 12 tabs, I'll get back

[jira] [Updated] (OFBIZ-11337) replace pullPluginFromSvn with a git equivalent

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11337: - Description: Currently we have a 'pullPluginFromSvn' task defined in *build.gradle*. The

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-02-02 Thread Devanshu Vyas (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028507#comment-17028507 ] Devanshu Vyas commented on OFBIZ-9254: -- I forgot to pick it up and complete it. Thanks [~mbrohl] for

[jira] [Commented] (OFBIZ-11329) setUserTimeZone should ran only once based on error

2020-02-02 Thread James Yong (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028472#comment-17028472 ] James Yong commented on OFBIZ-11329: {quote}Then why not simply throw a RequestHandlerException?

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028462#comment-17028462 ] Pierre Smits commented on OFBIZ-11205: -- The latest comment by Mathieu highlights the differences

[jira] [Commented] (OFBIZ-7112) EntityUtilProperties

2020-02-02 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028459#comment-17028459 ] Michael Brohl commented on OFBIZ-7112: -- [~jleroux], the issue here is solely for the purpose of

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028456#comment-17028456 ] Michael Brohl commented on OFBIZ-11205: --- Thank you for the clarification, [~mthl] . Discussing the

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Mathieu Lirzin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028452#comment-17028452 ] Mathieu Lirzin commented on OFBIZ-11205: Hello, Having dynamic development capabilities and

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028443#comment-17028443 ] Pierre Smits commented on OFBIZ-11304: -- Can't this be made part of the sonar cloud checks? >

[jira] [Created] (OFBIZ-11337) replace pullPluginFromSvn with a git equivalent

2020-02-02 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11337: Summary: replace pullPluginFromSvn with a git equivalent Key: OFBIZ-11337 URL: https://issues.apache.org/jira/browse/OFBIZ-11337 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028439#comment-17028439 ] Jacques Le Roux commented on OFBIZ-11236: - BTW, thank you Devanshu for your review :) > Add

[jira] [Commented] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028438#comment-17028438 ] Jacques Le Roux commented on OFBIZ-11236: - Hi Pierre, Thanks for your patch, I reviewed it,

[jira] [Commented] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028432#comment-17028432 ] Pierre Smits commented on OFBIZ-11236: -- Having a 'delete shipment note' function may not be right

[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945622#comment-16945622 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/2/20 1:06 PM: - Hi

[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946563#comment-16946563 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/2/20 1:02 PM: - Hello

[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945734#comment-16945734 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/2/20 1:02 PM: - Hello

[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945734#comment-16945734 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/2/20 1:01 PM: - Hello

[jira] [Comment Edited] (OFBIZ-11306) POC for CSRF Token

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028426#comment-17028426 ] Jacques Le Roux edited comment on OFBIZ-11306 at 2/2/20 12:54 PM: -- Hi

[jira] [Comment Edited] (OFBIZ-11306) POC for CSRF Token

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028426#comment-17028426 ] Jacques Le Roux edited comment on OFBIZ-11306 at 2/2/20 12:52 PM: -- Hi

[jira] [Comment Edited] (OFBIZ-11306) POC for CSRF Token

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028426#comment-17028426 ] Jacques Le Roux edited comment on OFBIZ-11306 at 2/2/20 12:49 PM: -- Hi

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028426#comment-17028426 ] Jacques Le Roux commented on OFBIZ-11306: - Hi James, About bq. My question is whether it is

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028424#comment-17028424 ] Jacques Le Roux commented on OFBIZ-11205: - I see, as Pierre suggested, in order to collect all

[jira] [Commented] (OFBIZ-11329) setUserTimeZone should ran only once based on error

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028417#comment-17028417 ] Jacques Le Roux commented on OFBIZ-11329: - Hi James, Thanks for your review! bq. But as

[jira] [Commented] (OFBIZ-11336) Use withCloseable in Groovy everywhere it's possible

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028415#comment-17028415 ] Pierre Smits commented on OFBIZ-11336: -- Can you elaborate a bit more? E.g. with examples of as-is

[jira] [Commented] (OFBIZ-6866) Add links to edit/delete a term, for instance from the list

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028413#comment-17028413 ] Jacques Le Roux commented on OFBIZ-6866: I'll have a look when I'll get a chance. Maybe too late,

[jira] [Updated] (OFBIZ-11336) Use withCloseable in Groovy everywhere it's possible

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11336: Summary: Use withCloseable in Groovy everywhere it's possible (was: Use withCloseable in

[jira] [Created] (OFBIZ-11336) Use withCloseable in Grooy everywhere it's possible

2020-02-02 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11336: --- Summary: Use withCloseable in Grooy everywhere it's possible Key: OFBIZ-11336 URL: https://issues.apache.org/jira/browse/OFBIZ-11336 Project: OFBiz

[jira] [Commented] (OFBIZ-7112) EntityUtilProperties

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028410#comment-17028410 ] Jacques Le Roux commented on OFBIZ-7112: Michael, I don't want to close before having resolved

[jira] [Updated] (OFBIZ-8297) Convert

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-8297: Labels: configuration (was: ) > Convert

[jira] [Updated] (OFBIZ-8297) Convert

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-8297: Parent: (was: OFBIZ-6164) Issue Type: Bug (was: Sub-task) > Convert

[jira] [Updated] (OFBIZ-8297) Convert

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-8297: Description: * Convert -- > >

[jira] [Assigned] (OFBIZ-10833) CMS add content not working

2020-02-02 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10833: - Assignee: Michael Brohl > CMS add content not working > --- >

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028369#comment-17028369 ] Michael Brohl commented on OFBIZ-11205: --- I wondered how it would work when you have all ressources

[jira] [Commented] (OFBIZ-8297) Convert

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028364#comment-17028364 ] Jacques Le Roux commented on OFBIZ-8297: BTW, I wonder if Moqui has a Tenant feature. I ask

[jira] [Commented] (OFBIZ-8297) Convert

2020-02-02 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028363#comment-17028363 ] Michael Brohl commented on OFBIZ-8297: -- {quote}Michael,  First you claimed that the provided patch

[jira] [Reopened] (OFBIZ-8297) Convert

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-8297: Reading the description it seems to me that the issue has not been addressed. So reopening

[jira] [Updated] (OFBIZ-11301) Clarify usage of Github PR

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11301: - Priority: Major (was: Minor) > Clarify usage of Github PR > -- > >

[jira] [Updated] (OFBIZ-11301) Clarify usage of Github PR

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11301: - Description: The PullRequest reflex is now an acquired behaviour. I started a discussion at

[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028340#comment-17028340 ] Pierre Smits commented on OFBIZ-11301: -- Effort to address this has been started. Currently work is

[jira] [Assigned] (OFBIZ-11301) Clarify usage of Github PR

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11301: Assignee: Pierre Smits (was: Jacques Le Roux) > Clarify usage of Github PR >

[jira] [Updated] (OFBIZ-11301) Clarify usage of Github PR

2020-02-02 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11301: - Labels: documentation (was: ) > Clarify usage of Github PR > -- > >

[jira] [Commented] (OFBIZ-10833) CMS add content not working

2020-02-02 Thread Swapnil Mane (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028326#comment-17028326 ] Swapnil Mane commented on OFBIZ-10833: -- Hi [~mbrohl], Thank you for showing kind interest, please

[jira] [Assigned] (OFBIZ-10833) CMS add content not working

2020-02-02 Thread Swapnil Mane (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Mane reassigned OFBIZ-10833: Assignee: (was: Swapnil Mane) > CMS add content not working >

[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028316#comment-17028316 ] Jacques Le Roux commented on OFBIZ-11205: - What makes you ask this question with a bias in? Have

[jira] [Updated] (OFBIZ-10722) Date-find error when used in two forms of a same screen

2020-02-02 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10722: Fix Version/s: (was: 18.12.01) Affects Version/s: (was: Release Branch