[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-668385084 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)

[jira] [Updated] (OFBIZ-11930) Remove unused imports from Java files

2020-08-03 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11930: - Parent: OFBIZ-11350 Issue Type: Sub-task (was: Improvement) > Remove unused imports

[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files

2020-08-03 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170543#comment-17170543 ] Priya Sharma commented on OFBIZ-11930: -- Yes Suraj, suggestion looks good to me. Thanks! > Remove

[jira] [Commented] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-08-03 Thread Devanshu Vyas (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170535#comment-17170535 ] Devanshu Vyas commented on OFBIZ-11929: --- I have attached 2 patch files containing the fix for some

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-08-03 Thread Devanshu Vyas (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170534#comment-17170534 ] Devanshu Vyas commented on OFBIZ-9254: -- Thanks Pawan and Jacques. I have created a new

[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-08-03 Thread Devanshu Vyas (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11929: -- Attachment: OFBIZ-11929_framework.patch OFBIZ-11929_plugins.patch > Fix

[jira] [Commented] (OFBIZ-11936) Status ID checkbox for FindTask and FindTimeSheet forms

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170329#comment-17170329 ] Jacques Le Roux commented on OFBIZ-11936: - +1 for commit, looks good to me. > Status ID

[jira] [Commented] (OFBIZ-11864) Purchase Order Email Support

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170264#comment-17170264 ] ASF subversion and git services commented on OFBIZ-11864: - Commit

[jira] [Commented] (OFBIZ-11864) Purchase Order Email Support

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170229#comment-17170229 ] ASF subversion and git services commented on OFBIZ-11864: - Commit

[jira] [Updated] (OFBIZ-11936) Status ID checkbox for FindTask and FindTimeSheet forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11936: --- Attachment: OFBIZ-11936.patch > Status ID checkbox for FindTask and FindTimeSheet forms >

[jira] [Updated] (OFBIZ-11937) Status ID checkbox for FindEmploymentApps, FindPartyQuals and FindEmplLeaves forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11937: --- Attachment: OFBIZ-11937.patch > Status ID checkbox for FindEmploymentApps, FindPartyQuals and

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-03 Thread GitBox
JacquesLeRoux commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668131743 Hi Wiebke, Yes: in https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, HTH

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668096472 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[jira] [Commented] (OFBIZ-7706) Error in Create Billing Account From SFA

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170107#comment-17170107 ] Akash Jain commented on OFBIZ-7706: --- Thanks, [~jleroux]! > Error in Create Billing Account From SFA >

[GitHub] [ofbiz-framework] wpaetzold commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-03 Thread GitBox
wpaetzold commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668054832 Hi @JacquesLeRoux, I did not notice that I exceeded the max line length. I am sorry about this and I will gladly correct it. Is there a formatter for eclipse

[jira] [Commented] (OFBIZ-7706) Error in Create Billing Account From SFA

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170035#comment-17170035 ] Jacques Le Roux commented on OFBIZ-7706: I created OFBIZ-11943 for the redirect issue > Error in

[jira] [Created] (OFBIZ-11943) Makes Cancel/Done buttons used in payment methods screens from SFA profile work as in "Create EFT Account" screen

2020-08-03 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11943: --- Summary: Makes Cancel/Done buttons used in payment methods screens from SFA profile work as in "Create EFT Account" screen Key: OFBIZ-11943 URL:

[jira] [Closed] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11735. -- Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Product link on Order

[jira] [Commented] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170028#comment-17170028 ] ASF subversion and git services commented on OFBIZ-11735: - Commit

[jira] [Commented] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170007#comment-17170007 ] ASF subversion and git services commented on OFBIZ-11735: - Commit

[jira] [Commented] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1717#comment-1717 ] ASF subversion and git services commented on OFBIZ-11735: - Commit

[jira] [Closed] (OFBIZ-7706) Error in Create Billing Account From SFA

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-7706. - Resolution: Cannot Reproduce Thanks, [~chandan.khandelwal] and [~Florian M]! > Error in Create Billing

[jira] [Commented] (OFBIZ-11864) Purchase Order Email Support

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169972#comment-17169972 ] Akash Jain commented on OFBIZ-11864: Thanks, [~jleroux]! > Purchase Order Email Support >

[jira] [Closed] (OFBIZ-11864) Purchase Order Email Support

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11864. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Purchase Order Email Support >

[jira] [Commented] (OFBIZ-11864) Purchase Order Email Support

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169965#comment-17169965 ] ASF subversion and git services commented on OFBIZ-11864: - Commit

[jira] [Closed] (OFBIZ-8426) Unit test case for service - removeDataResourceRole

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8426. - Resolution: Fixed This has been handled in OFBIZ-8420 Thanks, [~Tanmay]! > Unit test case for service

[jira] [Closed] (OFBIZ-8425) Unit test case for service - updateDataResourceRole

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8425. - Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-8420

[jira] [Closed] (OFBIZ-8424) Unit test case for service - createDataResourceRole

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8424. - Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-8420

[jira] [Closed] (OFBIZ-8422) Unit test case for service - removeDataCategory

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8422. - Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-8420

[jira] [Closed] (OFBIZ-8421) Unit test case for service - updateDataCategory

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8421. - Fix Version/s: Upcoming Branch Resolution: Implemented > Unit test case for service -

[jira] [Commented] (OFBIZ-8421) Unit test case for service - updateDataCategory

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169952#comment-17169952 ] Akash Jain commented on OFBIZ-8421: --- This has been handled in OFBIZ-8420 Thanks, [~Tanmay]! > Unit

[jira] [Closed] (OFBIZ-8420) Unit test case for some content services

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-8420. - Fix Version/s: Upcoming Branch Resolution: Implemented > Unit test case for some content services

[jira] [Closed] (OFBIZ-9619) UI inconsistency in "Status Id" drop down

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-9619. - Fix Version/s: Upcoming Branch Resolution: Implemented Sub tickets closed. > UI inconsistency in

[jira] [Commented] (OFBIZ-8420) Unit test case for some content services

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169918#comment-17169918 ] ASF subversion and git services commented on OFBIZ-8420: Commit

[jira] [Commented] (OFBIZ-8420) Unit test case for some content services

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169917#comment-17169917 ] ASF subversion and git services commented on OFBIZ-8420: Commit

[jira] [Commented] (OFBIZ-8424) Unit test case for service - createDataResourceRole

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169921#comment-17169921 ] ASF subversion and git services commented on OFBIZ-8424: Commit

[jira] [Commented] (OFBIZ-8426) Unit test case for service - removeDataResourceRole

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169923#comment-17169923 ] ASF subversion and git services commented on OFBIZ-8426: Commit

[jira] [Commented] (OFBIZ-8422) Unit test case for service - removeDataCategory

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169920#comment-17169920 ] ASF subversion and git services commented on OFBIZ-8422: Commit

[jira] [Commented] (OFBIZ-8425) Unit test case for service - updateDataResourceRole

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169922#comment-17169922 ] ASF subversion and git services commented on OFBIZ-8425: Commit

[jira] [Commented] (OFBIZ-8421) Unit test case for service - updateDataCategory

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169919#comment-17169919 ] ASF subversion and git services commented on OFBIZ-8421: Commit

[jira] [Closed] (OFBIZ-11939) Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11939. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Status ID checkbox for

[jira] [Commented] (OFBIZ-11939) Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169914#comment-17169914 ] ASF subversion and git services commented on OFBIZ-11939: - Commit

[jira] [Closed] (OFBIZ-11938) Status ID checkbox for FindPayments and FindPurchaseInvoices forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11938. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Status ID checkbox for FindPayments

[jira] [Commented] (OFBIZ-11938) Status ID checkbox for FindPayments and FindPurchaseInvoices forms

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169912#comment-17169912 ] ASF subversion and git services commented on OFBIZ-11938: - Commit

[jira] [Commented] (OFBIZ-11935) Status ID checkbox for Return, Requirement and Quote forms

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169910#comment-17169910 ] ASF subversion and git services commented on OFBIZ-11935: - Commit

[jira] [Closed] (OFBIZ-11935) Status ID checkbox for Return, Requirement and Quote forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11935. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Status ID checkbox for Return,

[jira] [Closed] (OFBIZ-11934) Status ID checkbox for FindDataResource and FindContent forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11934. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Status ID checkbox for

[jira] [Commented] (OFBIZ-11934) Status ID checkbox for FindDataResource and FindContent forms

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169908#comment-17169908 ] ASF subversion and git services commented on OFBIZ-11934: - Commit

[jira] [Closed] (OFBIZ-9643) Improvements in Find Invoice and Find Payment screen

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-9643. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~Renuka_Srishti] and

[jira] [Commented] (OFBIZ-9643) Improvements in Find Invoice and Find Payment screen

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169895#comment-17169895 ] ASF subversion and git services commented on OFBIZ-9643: Commit

[jira] [Commented] (OFBIZ-11933) Checkbox not selected after searching with multiple options checked in form widget

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169858#comment-17169858 ] Jacques Le Roux commented on OFBIZ-11933: - I only reviewed 3 of them and tried OFBIZ-11939, good

[jira] [Updated] (OFBIZ-11942) Check if <> meme needs encoding in some place

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11942: Parent: OFBIZ-1525 Issue Type: Sub-task (was: Task) > Check if <> meme needs

[jira] [Created] (OFBIZ-11942) Check if <> meme needs encoding in some place

2020-08-03 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11942: --- Summary: Check if <> meme needs encoding in some place Key: OFBIZ-11942 URL: https://issues.apache.org/jira/browse/OFBIZ-11942 Project: OFBiz Issue

[jira] [Closed] (OFBIZ-11871) Server-Side Template Injection using Static

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11871. --- Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Server-Side

[jira] [Commented] (OFBIZ-11907) WidgetWorker should not write generated html to Appendable

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169837#comment-17169837 ] ASF subversion and git services commented on OFBIZ-11907: - Commit

[jira] [Commented] (OFBIZ-11907) WidgetWorker should not write generated html to Appendable

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169836#comment-17169836 ] ASF subversion and git services commented on OFBIZ-11907: - Commit

[jira] [Commented] (OFBIZ-11871) Server-Side Template Injection using Static

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169833#comment-17169833 ] ASF subversion and git services commented on OFBIZ-11871: - Commit

[jira] [Commented] (OFBIZ-11871) Server-Side Template Injection using Static

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169832#comment-17169832 ] ASF subversion and git services commented on OFBIZ-11871: - Commit

[jira] [Commented] (OFBIZ-11907) WidgetWorker should not write generated html to Appendable

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169835#comment-17169835 ] ASF subversion and git services commented on OFBIZ-11907: - Commit

[jira] [Commented] (OFBIZ-11907) WidgetWorker should not write generated html to Appendable

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169838#comment-17169838 ] ASF subversion and git services commented on OFBIZ-11907: - Commit

[jira] [Commented] (OFBIZ-11871) Server-Side Template Injection using Static

2020-08-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169834#comment-17169834 ] ASF subversion and git services commented on OFBIZ-11871: - Commit

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-666340394 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-667886102 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[jira] [Commented] (OFBIZ-11940) Getting Started - Developers need to mention Gradle min required version

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169809#comment-17169809 ] Jacques Le Roux commented on OFBIZ-11940: - Hi Karthik, This is not necessary for released

[jira] [Comment Edited] (OFBIZ-11940) Getting Started - Developers need to mention Gradle min required version

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169809#comment-17169809 ] Jacques Le Roux edited comment on OFBIZ-11940 at 8/3/20, 8:20 AM: -- Hi

[jira] [Closed] (OFBIZ-11940) Getting Started - Developers need to mention Gradle min required version

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11940. --- Assignee: Jacques Le Roux Resolution: Not A Problem > Getting Started - Developers

[GitHub] [ofbiz-framework] fehnomenal commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-08-03 Thread GitBox
fehnomenal commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-667881940 I did a quick check and found the following: - Lat and lon are used in some places without problems (mainly inside calls to `UtilMisc.toMap` or simple outputs)

[jira] [Commented] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169807#comment-17169807 ] Jacques Le Roux commented on OFBIZ-11941: - +1 > Checkstyle: Add override property in

[jira] [Commented] (OFBIZ-11931) ParameterNumber checkstyle rule

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169806#comment-17169806 ] Jacques Le Roux commented on OFBIZ-11931: - +1 > ParameterNumber checkstyle rule >

[jira] [Commented] (OFBIZ-11925) Checkstyle: Redundant modifiers

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169805#comment-17169805 ] Jacques Le Roux commented on OFBIZ-11925: - DId not check all, but sounds good to me >

[jira] [Updated] (OFBIZ-11925) Checkstyle: Redundant modifiers

2020-08-03 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11925: -- Attachment: OFBIZ-11925.patch > Checkstyle: Redundant modifiers >

[jira] [Updated] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

2020-08-03 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11941: -- Attachment: OFBIZ-11941.patch > Checkstyle: Add override property in DesignForExtension

[jira] [Created] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

2020-08-03 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11941: - Summary: Checkstyle: Add override property in DesignForExtension module Key: OFBIZ-11941 URL: https://issues.apache.org/jira/browse/OFBIZ-11941 Project: OFBiz

[jira] [Updated] (OFBIZ-11938) Status ID checkbox for FindPayments and FindPurchaseInvoices forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11938: --- Attachment: OFBIZ-11938.patch > Status ID checkbox for FindPayments and FindPurchaseInvoices forms

[jira] [Updated] (OFBIZ-11939) Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms

2020-08-03 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11939: --- Attachment: OFBIZ-11939.patch > Status ID checkbox for FindWorkEffort, FindProductionRun and

[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule

2020-08-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169744#comment-17169744 ] Jacques Le Roux commented on OFBIZ-11915: - Hi Suraj, As we discussed it's OK with me. I wonder