sonarcloud[bot] commented on pull request #14:
URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-668385084
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)
[
https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Priya Sharma updated OFBIZ-11930:
-
Parent: OFBIZ-11350
Issue Type: Sub-task (was: Improvement)
> Remove unused imports
[
https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170543#comment-17170543
]
Priya Sharma commented on OFBIZ-11930:
--
Yes Suraj, suggestion looks good to me.
Thanks!
> Remove
[
https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170535#comment-17170535
]
Devanshu Vyas commented on OFBIZ-11929:
---
I have attached 2 patch files containing the fix for some
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170534#comment-17170534
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Pawan and Jacques.
I have created a new
[
https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devanshu Vyas updated OFBIZ-11929:
--
Attachment: OFBIZ-11929_framework.patch
OFBIZ-11929_plugins.patch
> Fix
[
https://issues.apache.org/jira/browse/OFBIZ-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170329#comment-17170329
]
Jacques Le Roux commented on OFBIZ-11936:
-
+1 for commit, looks good to me.
> Status ID
[
https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170264#comment-17170264
]
ASF subversion and git services commented on OFBIZ-11864:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170229#comment-17170229
]
ASF subversion and git services commented on OFBIZ-11864:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain updated OFBIZ-11936:
---
Attachment: OFBIZ-11936.patch
> Status ID checkbox for FindTask and FindTimeSheet forms
>
[
https://issues.apache.org/jira/browse/OFBIZ-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain updated OFBIZ-11937:
---
Attachment: OFBIZ-11937.patch
> Status ID checkbox for FindEmploymentApps, FindPartyQuals and
JacquesLeRoux commented on pull request #209:
URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668131743
Hi Wiebke,
Yes: in
https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, HTH
sonarcloud[bot] removed a comment on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
sonarcloud[bot] commented on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668096472
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
sonarcloud[bot] commented on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
[
https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170107#comment-17170107
]
Akash Jain commented on OFBIZ-7706:
---
Thanks, [~jleroux]!
> Error in Create Billing Account From SFA
>
wpaetzold commented on pull request #209:
URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668054832
Hi @JacquesLeRoux,
I did not notice that I exceeded the max line length.
I am sorry about this and I will gladly correct it.
Is there a formatter for eclipse
[
https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170035#comment-17170035
]
Jacques Le Roux commented on OFBIZ-7706:
I created OFBIZ-11943 for the redirect issue
> Error in
Jacques Le Roux created OFBIZ-11943:
---
Summary: Makes Cancel/Done buttons used in payment methods screens
from SFA profile work as in "Create EFT Account" screen
Key: OFBIZ-11943
URL:
[
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11735.
--
Fix Version/s: 17.12.05
18.12.01
Resolution: Fixed
> Product link on Order
[
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170028#comment-17170028
]
ASF subversion and git services commented on OFBIZ-11735:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170007#comment-17170007
]
ASF subversion and git services commented on OFBIZ-11735:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1717#comment-1717
]
ASF subversion and git services commented on OFBIZ-11735:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-7706.
-
Resolution: Cannot Reproduce
Thanks, [~chandan.khandelwal] and [~Florian M]!
> Error in Create Billing
[
https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169972#comment-17169972
]
Akash Jain commented on OFBIZ-11864:
Thanks, [~jleroux]!
> Purchase Order Email Support
>
[
https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11864.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Purchase Order Email Support
>
[
https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169965#comment-17169965
]
ASF subversion and git services commented on OFBIZ-11864:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8426.
-
Resolution: Fixed
This has been handled in OFBIZ-8420
Thanks, [~Tanmay]!
> Unit test case for service
[
https://issues.apache.org/jira/browse/OFBIZ-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8425.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
This has been handled in OFBIZ-8420
[
https://issues.apache.org/jira/browse/OFBIZ-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8424.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
This has been handled in OFBIZ-8420
[
https://issues.apache.org/jira/browse/OFBIZ-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8422.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
This has been handled in OFBIZ-8420
[
https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8421.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Unit test case for service -
[
https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169952#comment-17169952
]
Akash Jain commented on OFBIZ-8421:
---
This has been handled in OFBIZ-8420
Thanks, [~Tanmay]!
> Unit
[
https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-8420.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Unit test case for some content services
[
https://issues.apache.org/jira/browse/OFBIZ-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-9619.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Sub tickets closed.
> UI inconsistency in
[
https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169918#comment-17169918
]
ASF subversion and git services commented on OFBIZ-8420:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169917#comment-17169917
]
ASF subversion and git services commented on OFBIZ-8420:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169921#comment-17169921
]
ASF subversion and git services commented on OFBIZ-8424:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169923#comment-17169923
]
ASF subversion and git services commented on OFBIZ-8426:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169920#comment-17169920
]
ASF subversion and git services commented on OFBIZ-8422:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169922#comment-17169922
]
ASF subversion and git services commented on OFBIZ-8425:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169919#comment-17169919
]
ASF subversion and git services commented on OFBIZ-8421:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11939.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Status ID checkbox for
[
https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169914#comment-17169914
]
ASF subversion and git services commented on OFBIZ-11939:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11938.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Status ID checkbox for FindPayments
[
https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169912#comment-17169912
]
ASF subversion and git services commented on OFBIZ-11938:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169910#comment-17169910
]
ASF subversion and git services commented on OFBIZ-11935:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11935.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Status ID checkbox for Return,
[
https://issues.apache.org/jira/browse/OFBIZ-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-11934.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Status ID checkbox for
[
https://issues.apache.org/jira/browse/OFBIZ-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169908#comment-17169908
]
ASF subversion and git services commented on OFBIZ-11934:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain closed OFBIZ-9643.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks, [~Renuka_Srishti] and
[
https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169895#comment-17169895
]
ASF subversion and git services commented on OFBIZ-9643:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169858#comment-17169858
]
Jacques Le Roux commented on OFBIZ-11933:
-
I only reviewed 3 of them and tried OFBIZ-11939, good
[
https://issues.apache.org/jira/browse/OFBIZ-11942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11942:
Parent: OFBIZ-1525
Issue Type: Sub-task (was: Task)
> Check if <> meme needs
Jacques Le Roux created OFBIZ-11942:
---
Summary: Check if <> meme needs encoding
in some place
Key: OFBIZ-11942
URL: https://issues.apache.org/jira/browse/OFBIZ-11942
Project: OFBiz
Issue
[
https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11871.
---
Fix Version/s: 17.12.05
18.12.01
Resolution: Fixed
> Server-Side
[
https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169837#comment-17169837
]
ASF subversion and git services commented on OFBIZ-11907:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169836#comment-17169836
]
ASF subversion and git services commented on OFBIZ-11907:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169833#comment-17169833
]
ASF subversion and git services commented on OFBIZ-11871:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169832#comment-17169832
]
ASF subversion and git services commented on OFBIZ-11871:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169835#comment-17169835
]
ASF subversion and git services commented on OFBIZ-11907:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169838#comment-17169838
]
ASF subversion and git services commented on OFBIZ-11907:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169834#comment-17169834
]
ASF subversion and git services commented on OFBIZ-11871:
-
Commit
sonarcloud[bot] removed a comment on pull request #35:
URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-666340394
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)
sonarcloud[bot] commented on pull request #35:
URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-667886102
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)
[
https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169809#comment-17169809
]
Jacques Le Roux commented on OFBIZ-11940:
-
Hi Karthik,
This is not necessary for released
[
https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169809#comment-17169809
]
Jacques Le Roux edited comment on OFBIZ-11940 at 8/3/20, 8:20 AM:
--
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-11940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11940.
---
Assignee: Jacques Le Roux
Resolution: Not A Problem
> Getting Started - Developers
fehnomenal commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-667881940
I did a quick check and found the following:
- Lat and lon are used in some places without problems (mainly inside calls
to `UtilMisc.toMap` or simple outputs)
[
https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169807#comment-17169807
]
Jacques Le Roux commented on OFBIZ-11941:
-
+1
> Checkstyle: Add override property in
[
https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169806#comment-17169806
]
Jacques Le Roux commented on OFBIZ-11931:
-
+1
> ParameterNumber checkstyle rule
>
[
https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169805#comment-17169805
]
Jacques Le Roux commented on OFBIZ-11925:
-
DId not check all, but sounds good to me
>
[
https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-11925:
--
Attachment: OFBIZ-11925.patch
> Checkstyle: Redundant modifiers
>
[
https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-11941:
--
Attachment: OFBIZ-11941.patch
> Checkstyle: Add override property in DesignForExtension
Suraj Khurana created OFBIZ-11941:
-
Summary: Checkstyle: Add override property in DesignForExtension
module
Key: OFBIZ-11941
URL: https://issues.apache.org/jira/browse/OFBIZ-11941
Project: OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-11938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain updated OFBIZ-11938:
---
Attachment: OFBIZ-11938.patch
> Status ID checkbox for FindPayments and FindPurchaseInvoices forms
[
https://issues.apache.org/jira/browse/OFBIZ-11939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash Jain updated OFBIZ-11939:
---
Attachment: OFBIZ-11939.patch
> Status ID checkbox for FindWorkEffort, FindProductionRun and
[
https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169744#comment-17169744
]
Jacques Le Roux commented on OFBIZ-11915:
-
Hi Suraj,
As we discussed it's OK with me. I wonder
78 matches
Mail list logo