[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-11-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: (was: OFBIZ-10606_0001-Add-WebAppCache.patch) > Webapp related code should

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-11-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: (was: OFBIZ-10606_0003-Refactor-WebAppCache.patch) > Webapp related code

[jira] [Commented] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-11-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674027#comment-16674027 ] Mathieu Lirzin commented on OFBIZ-10606: Thanks for letting me know, I will provide updated

[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673735#comment-16673735 ] Mathieu Lirzin commented on OFBIZ-10579: Hello Suraj, I have started to review

[jira] [Commented] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673668#comment-16673668 ] Mathieu Lirzin commented on OFBIZ-10638: I have provided

[jira] [Updated] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10638: --- Attachment: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch

[jira] [Updated] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10638: --- Summary: The ‘StartupLoader’ interface should be removed (was: The ‘StartupLoader’ should

[jira] [Created] (OFBIZ-10638) The ‘StartupLoader’ should be removed

2018-11-02 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10638: -- Summary: The ‘StartupLoader’ should be removed Key: OFBIZ-10638 URL: https://issues.apache.org/jira/browse/OFBIZ-10638 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-10637) ComponentConfig::getAppBarWebInfos creates infos only for components without <>

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673265#comment-16673265 ] Mathieu Lirzin commented on OFBIZ-10637: Thanks Jacques, sorry for the extra work :) >

[jira] [Comment Edited] (OFBIZ-10637) ComponentConfig::getAppBarWebInfos creates infos only for components without <>

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673122#comment-16673122 ] Mathieu Lirzin edited comment on OFBIZ-10637 at 11/2/18 1:54 PM: - Hello

[jira] [Commented] (OFBIZ-10637) ComponentConfig::getAppBarWebInfos creates infos only for components without <>

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673122#comment-16673122 ] Mathieu Lirzin commented on OFBIZ-10637: Hello Jacques, {code:java} if

[jira] [Commented] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673093#comment-16673093 ] Mathieu Lirzin commented on OFBIZ-10606: I have included

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-11-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: OFBIZ-10606_0001-Add-WebAppCache.patch

[jira] [Commented] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668525#comment-16668525 ] Mathieu Lirzin commented on OFBIZ-10452: Thanks Jacques > Remove unused

[jira] [Commented] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668522#comment-16668522 ] Mathieu Lirzin commented on OFBIZ-10603: Thanks Jacques. > Javadoc doesn't contains links to

[jira] [Commented] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668414#comment-16668414 ] Mathieu Lirzin commented on OFBIZ-10603: Hello [~jacques.le.roux], I have added

[jira] [Updated] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10603: --- Attachment: OFBIZ-10603_Add-a-comment-describing-how-to-maintain-external-Ja.patch >

[jira] [Assigned] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10452: -- Assignee: Jacques Le Roux (was: Mathieu Lirzin) > Remove unused

[jira] [Assigned] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-10-30 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10452: -- Assignee: Mathieu Lirzin (was: Jacques Le Roux) > Remove unused

[jira] [Comment Edited] (OFBIZ-10618) Update google libphonenumber to v8.9.16

2018-10-29 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667913#comment-16667913 ] Mathieu Lirzin edited comment on OFBIZ-10618 at 10/30/18 12:01 AM: ---

[jira] [Commented] (OFBIZ-10618) Update google libphonenumber to v8.9.16

2018-10-29 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667913#comment-16667913 ] Mathieu Lirzin commented on OFBIZ-10618: Hello [~pfm.smits], I think you should check the

[jira] [Commented] (OFBIZ-10449) Refactor ControlFilter

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1569#comment-1569 ] Mathieu Lirzin commented on OFBIZ-10449: I have updated the 

[jira] [Updated] (OFBIZ-10449) Refactor ControlFilter

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10449: --- Attachment: (was: OFBIZ-10449_Improved-Refactor-ControlFilter.patch) > Refactor

[jira] [Updated] (OFBIZ-10449) Refactor ControlFilter

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10449: --- Attachment: OFBIZ-10449_Refactor-ControlFilter-and-add-tests.patch > Refactor ControlFilter

[jira] [Comment Edited] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1526#comment-1526 ] Mathieu Lirzin edited comment on OFBIZ-10632 at 10/28/18 7:20 PM: --

[jira] [Commented] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1526#comment-1526 ] Mathieu Lirzin commented on OFBIZ-10632: Hello Jacques, Hum I see.  If I understand the FindBug

[jira] [Updated] (OFBIZ-10451) Use ‘String#equalsIgnoreCase’ in ‘RequestHandler#doRequest’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Description: Use {{String#equalsIgnoreCase}} instead of combining {{String#equals}} and

[jira] [Updated] (OFBIZ-10451) Use ‘String#equalsIgnoreCase’ in ‘RequestHandler#doRequest’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Summary: Use ‘String#equalsIgnoreCase’ in ‘RequestHandler#doRequest’ (was: Use

[jira] [Commented] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1521#comment-1521 ] Mathieu Lirzin commented on OFBIZ-10451: I have updated

[jira] [Updated] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Attachment: OFBIZ-10451_Use-String-equalsIgnoreCase-in-RequestHandler-doRequ.patch > Use

[jira] [Updated] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10452: --- Environment: (was: This method is only a wrapper for an overload.  Since it is not used

[jira] [Updated] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10452: --- Description: The {{RequestHandler#doRequest}} is only a wrapper for an overload.  Since it

[jira] [Updated] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10632: --- Description: Usage of {{"foo".toLowerCase()}} should be preferred to

[jira] [Updated] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10632: --- Description: Usage of {{"foo".toLowerCase()}} should be preferred to

[jira] [Commented] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1509#comment-1509 ] Mathieu Lirzin commented on OFBIZ-10632: I have included

[jira] [Updated] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10632: --- Attachment: OFBIZ-10632_Use-String-toLowercase-and-String-toUppercase-when-p.patch >

[jira] [Created] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

2018-10-28 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10632: -- Summary: ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible Key: OFBIZ-10632 URL: https://issues.apache.org/jira/browse/OFBIZ-10632

[jira] [Commented] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1489#comment-1489 ] Mathieu Lirzin commented on OFBIZ-10450: I have updated

[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10450: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10450: --- Attachment: OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch >

[jira] [Commented] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1459#comment-1459 ] Mathieu Lirzin commented on OFBIZ-10606: up to date patches will be provided soon > Webapp

[jira] [Issue Comment Deleted] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Comment: was deleted (was: I have included [^OFBIZ-10606_0001-Add-WebAppCache.patch],

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: (was: OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch) > Webapp related

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: (was: OFBIZ-10606_0003-Refactor-WebAppCache.patch) > Webapp related code

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: (was: OFBIZ-10606_0001-Add-WebAppCache.patch) > Webapp related code should

[jira] [Commented] (OFBIZ-10611) Allow unit tests to be written in Groovy

2018-10-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658218#comment-16658218 ] Mathieu Lirzin commented on OFBIZ-10611: I have included

[jira] [Updated] (OFBIZ-10611) Allow unit tests to be written in Groovy

2018-10-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10611: --- Attachment: OFBIZ-10611_Allow-unit-tests-to-be-written-in-Groovy.patch > Allow unit tests

[jira] [Created] (OFBIZ-10611) Allow unit tests to be written in Groovy

2018-10-21 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10611: -- Summary: Allow unit tests to be written in Groovy Key: OFBIZ-10611 URL: https://issues.apache.org/jira/browse/OFBIZ-10611 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10611) Allow unit tests to be written in Groovy

2018-10-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10611: --- Description: Since OFBIZ-9996 it is possible to write integration tests in Groovy, meaning

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-10-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657867#comment-16657867 ] Mathieu Lirzin commented on OFBIZ-10458: I don't expect time to have any impact on the issue at

[jira] [Comment Edited] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-10-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657835#comment-16657835 ] Mathieu Lirzin edited comment on OFBIZ-10458 at 10/20/18 11:43 AM: ---

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-10-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657835#comment-16657835 ] Mathieu Lirzin commented on OFBIZ-10458: OK; I thought you were saying that the test was

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-10-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657807#comment-16657807 ] Mathieu Lirzin commented on OFBIZ-10458: I can 't reproduce here with {{./gradlew from a "fresh

[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650749#comment-16650749 ] Mathieu Lirzin commented on OFBIZ-10607: I have included

[jira] [Updated] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10607: --- Attachment: OFBIZ-10607_Remove-EntityOperator-requestId.patch > ‘EntityOperator#getId()’ is

[jira] [Created] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2018-10-15 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10607: -- Summary: ‘EntityOperator#getId()’ is not used in the framework Key: OFBIZ-10607 URL: https://issues.apache.org/jira/browse/OFBIZ-10607 Project: OFBiz

[jira] [Commented] (OFBIZ-10602) Refactor ICalendar support

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650692#comment-16650692 ] Mathieu Lirzin commented on OFBIZ-10602: {quote}I added missing imports after errors in Buildbot

[jira] [Comment Edited] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650215#comment-16650215 ] Mathieu Lirzin edited comment on OFBIZ-10606 at 10/15/18 1:37 PM: -- I

[jira] [Commented] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650215#comment-16650215 ] Mathieu Lirzin commented on OFBIZ-10606: I have included

[jira] [Updated] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10606: --- Attachment: OFBIZ-10606_0001-Add-WebAppCache.patch

[jira] [Created] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’

2018-10-15 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10606: -- Summary: Webapp related code should be extracted from ‘ComponentConfig’ Key: OFBIZ-10606 URL: https://issues.apache.org/jira/browse/OFBIZ-10606 Project: OFBiz

[jira] [Commented] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650157#comment-16650157 ] Mathieu Lirzin commented on OFBIZ-10603: Hello, {quote}To have it working on Windows I had to

[jira] [Commented] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-14 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649427#comment-16649427 ] Mathieu Lirzin commented on OFBIZ-7775: --- Thanks jacques. > Cleanup JavaDocs to be standards

[jira] [Commented] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649078#comment-16649078 ] Mathieu Lirzin commented on OFBIZ-10603: I have provided 

[jira] [Updated] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10603: --- Attachment: OFBIZ-10603_Provide-external-links-in-Javadoc.patch > Javadoc doesn't contains

[jira] [Created] (OFBIZ-10603) Javadoc doesn't contains links to external documentation

2018-10-13 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10603: -- Summary: Javadoc doesn't contains links to external documentation Key: OFBIZ-10603 URL: https://issues.apache.org/jira/browse/OFBIZ-10603 Project: OFBiz

[jira] [Comment Edited] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649061#comment-16649061 ] Mathieu Lirzin edited comment on OFBIZ-7775 at 10/13/18 6:21 PM: - Hello,

[jira] [Commented] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649061#comment-16649061 ] Mathieu Lirzin commented on OFBIZ-7775: --- Hello, I have provided a 

[jira] [Updated] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-7775: -- Attachment: OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch > Cleanup JavaDocs

[jira] [Updated] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-7775: -- Attachment: OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch > Cleanup JavaDocs

[jira] [Updated] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-7775: -- Attachment: (was: OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch) >

[jira] [Updated] (OFBIZ-10602) Refactor ICalendar support

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10602: --- Attachment: OFBIZ-10602_Refactor-ICalendar-support.patch > Refactor ICalendar support >

[jira] [Created] (OFBIZ-10602) Refactor ICalendar support

2018-10-13 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10602: -- Summary: Refactor ICalendar support Key: OFBIZ-10602 URL: https://issues.apache.org/jira/browse/OFBIZ-10602 Project: OFBiz Issue Type: Improvement

[jira] [Commented] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648813#comment-16648813 ] Mathieu Lirzin commented on OFBIZ-10593: Hello Gil, I fully agree on creating an issue for

[jira] [Comment Edited] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642276#comment-16642276 ] Mathieu Lirzin edited comment on OFBIZ-10593 at 10/12/18 11:52 AM: ---

[jira] [Commented] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647696#comment-16647696 ] Mathieu Lirzin commented on OFBIZ-10593: Hello Jacques, I have updated

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: (was: OFBIZ-10593_Fixed-Implement-EntityConditionVisitor-properly.patch) >

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: OFBIZ-10593_Implement-EntityConditionVisitor-properly.patch >

[jira] [Comment Edited] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642276#comment-16642276 ] Mathieu Lirzin edited comment on OFBIZ-10593 at 10/8/18 6:28 PM: - Hello,

[jira] [Comment Edited] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642276#comment-16642276 ] Mathieu Lirzin edited comment on OFBIZ-10593 at 10/8/18 6:28 PM: - Hello,

[jira] [Commented] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642276#comment-16642276 ] Mathieu Lirzin commented on OFBIZ-10593: Hello, So after looking at the hierarchy it appears

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: (was: OFBIZ-10593_Implement-EntityConditionVisitor-properly.patch) >

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: OFBIZ-10593_Implement-EntityConditionVisitor-properly.patch >

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: OFBIZ-10593_Fixed-Implement-EntityConditionVisitor-properly.patch >

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: (was: OFBIZ-10593_Implement-EntityConditionVisitor-properly.patch) >

[jira] [Comment Edited] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638374#comment-16638374 ] Mathieu Lirzin edited comment on OFBIZ-10593 at 10/4/18 3:20 PM: - I have

[jira] [Commented] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638374#comment-16638374 ] Mathieu Lirzin commented on OFBIZ-10593: I have uploaded

[jira] [Comment Edited] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638374#comment-16638374 ] Mathieu Lirzin edited comment on OFBIZ-10593 at 10/4/18 3:20 PM: - I have

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Attachment: OFBIZ-10593_Implement-EntityConditionVisitor-properly.patch >

[jira] [Updated] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10593: --- Description: {{EntityConditionVisitor}} interface is supposed to implement the visitor

[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-10-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637038#comment-16637038 ] Mathieu Lirzin commented on OFBIZ-10579: Hello Jacques, I have created OFBIZ-10593 for that.

[jira] [Created] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-03 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10593: -- Summary: ‘EntityConditionVisitor’ is a confused visitor pattern Key: OFBIZ-10593 URL: https://issues.apache.org/jira/browse/OFBIZ-10593 Project: OFBiz

[jira] [Comment Edited] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-10-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636599#comment-16636599 ] Mathieu Lirzin edited comment on OFBIZ-10579 at 10/3/18 8:29 AM: - Hello,

[jira] [Comment Edited] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-10-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636599#comment-16636599 ] Mathieu Lirzin edited comment on OFBIZ-10579 at 10/3/18 8:27 AM: - Hello,

[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-10-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636599#comment-16636599 ] Mathieu Lirzin commented on OFBIZ-10579: Hello, Here is a remark that is not concerning the

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585803#comment-16585803 ] Mathieu Lirzin commented on OFBIZ-10438: So I was able to reproduce the bug and fix it in

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: fix-resolveURI.patch) > Add method attribute to request-map to

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_Fix-resolveURI.patch > Add method attribute to request-map to

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: fix-resolveURI.patch > Add method attribute to request-map to controll a uri

<    3   4   5   6   7   8   9   10   >