[jira] [Closed] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-12210. - Fix Version/s: 17.12.06 18.12.01 Resolution: Fixed Thanks:

[jira] [Assigned] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-12210: - Assignee: Suraj Khurana > orderStatus.changeReason not set when orderItem is cancelled

[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Component/s: order > orderStatus.changeReason not set when orderItem is cancelled >

[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 >

[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309894#comment-17309894 ] Suraj Khurana commented on OFBIZ-12210: --- I checked on demo-trunk order, by canceling and item

[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Issue Type: Bug (was: Improvement) > orderStatus.changeReason not set when orderItem is

[jira] [Commented] (OFBIZ-12204) WebPos: Impossible to checkout when product is paid in multiple cash amounts

[ https://issues.apache.org/jira/browse/OFBIZ-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309876#comment-17309876 ] Suraj Khurana commented on OFBIZ-12204: --- HI [~sa_james], Current behaviour is like if $50 is

[jira] [Closed] (OFBIZ-8717) Improve all the service level error messages for missing required field for webtools component

[ https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8717. Fix Version/s: Upcoming Branch Resolution: Fixed This has been pushed to latest trunk.

[jira] [Updated] (OFBIZ-8717) Improve all the service level error messages for missing required field for webtools component

[ https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-8717: - Affects Version/s: Trunk > Improve all the service level error messages for missing required

[jira] [Commented] (OFBIZ-12177) Possibly currency display bug in "Find Invoices"

[ https://issues.apache.org/jira/browse/OFBIZ-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293634#comment-17293634 ] Suraj Khurana commented on OFBIZ-12177: --- +1, patch looks good to me. > Possibly currency display

[jira] [Closed] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

[ https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11680. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed Thanks [~mbrohl]

[jira] [Closed] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11901. - Fix Version/s: Upcoming Branch Resolution: Implemented This has been pushed to trunk. >

[jira] [Commented] (OFBIZ-11728) Create new component, data configuration and connection request

[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261796#comment-17261796 ] Suraj Khurana commented on OFBIZ-11728: --- The first initial PR seems ready to merge, I will proceed

[jira] [Commented] (OFBIZ-12078) Remove hardcoded product cateogy on CategoryWorker.getCatalogTopCategory

[ https://issues.apache.org/jira/browse/OFBIZ-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243734#comment-17243734 ] Suraj Khurana commented on OFBIZ-12078: --- +1, LGTM > Remove hardcoded product cateogy on

[jira] [Commented] (OFBIZ-12053) Promising against Future Supply of Inventory

[ https://issues.apache.org/jira/browse/OFBIZ-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230025#comment-17230025 ] Suraj Khurana commented on OFBIZ-12053: --- This is a good idea, this will a shinning new feather in

[jira] [Closed] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11971. - Fix Version/s: (was: Trunk) 17.12.05 18.12.01

[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices

[ https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202610#comment-17202610 ] Suraj Khurana commented on OFBIZ-11965: --- Hello Vaibhav, Thanks for providing the patch. We are

[jira] [Assigned] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

[ https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11680: - Assignee: Suraj Khurana > ViewQuoteProfit shows fields in wrong order >

[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11971: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 >

[jira] [Closed] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements

[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11185. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Amit Gadaley for providing

[jira] [Assigned] (OFBIZ-11728) Create new component, data configuration and connection request

[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11728: - Assignee: Suraj Khurana (was: Shikha Jaiswal) > Create new component, data

[jira] [Commented] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202558#comment-17202558 ] Suraj Khurana commented on OFBIZ-11901: --- Hello [~lodhiravi], I have attached a patch, could you

[jira] [Updated] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points

[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11901: -- Attachment: OFBIZ-11901.patch > Provide OOTB support to calculate distance between two geo

[jira] [Closed] (OFBIZ-12022) Extra whitespace in code

[ https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-12022. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *42* checkstyle

[jira] [Updated] (OFBIZ-12022) Extra whitespace in code

[ https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12022: -- Attachment: OFBIZ-12022.patch > Extra whitespace in code > > >

[jira] [Created] (OFBIZ-12022) Extra whitespace in code

Suraj Khurana created OFBIZ-12022: - Summary: Extra whitespace in code Key: OFBIZ-12022 URL: https://issues.apache.org/jira/browse/OFBIZ-12022 Project: OFBiz Issue Type: Sub-task

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202526#comment-17202526 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, I think we can close this one. >

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195909#comment-17195909 ] Suraj Khurana commented on OFBIZ-11926: --- Yes, +1 to have this for all "do nothing" kind of code

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195444#comment-17195444 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, Please check 

[jira] [Updated] (OFBIZ-12014) Error while decoding url parameters with percent character

[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12014: -- Priority: Major (was: Trivial) > Error while decoding url parameters with percent character

[jira] [Closed] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11947. - Fix Version/s: Upcoming Branch Resolution: Implemented Last pair of patches fixed around

[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947-plugins-3.patch OFBIZ-11947-3.patch > Checkstyle: Add

[jira] [Closed] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11963. - Fix Version/s: Upcoming Branch Resolution: Implemented These pair of last patches fixed

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194631#comment-17194631 ] Suraj Khurana commented on OFBIZ-11963: --- All test passed in testIntegration for last uploaded

[jira] [Updated] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11963: -- Attachment: OFBIZ-11963-plugins-2.patch OFBIZ-11963-2.patch > Checkstyle:

[jira] [Closed] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11921. - Fix Version/s: Upcoming Branch Resolution: Implemented Last pair of patches fixed around

[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190167#comment-17190167 ] Suraj Khurana commented on OFBIZ-11921: --- Build successful. All tests passed in testIntegration.

[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189929#comment-17189929 ] Suraj Khurana commented on OFBIZ-11921: --- Last patch for this ticket attached. > Checkstyle: Line

[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-11921-plugins-3.patch OFBIZ-11921-3.patch > Checkstyle:

[jira] [Closed] (OFBIZ-11978) "cart" should be "card"

[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11978. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed Thanks Alex

[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187776#comment-17187776 ] Suraj Khurana commented on OFBIZ-11921: --- Thanks Jacques for review. Both the patches are loaded

[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187661#comment-17187661 ] Suraj Khurana commented on OFBIZ-11921: --- Yes, this one of plugins is kind of mixed and thus small,

[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

[ https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187630#comment-17187630 ] Suraj Khurana commented on OFBIZ-11954: --- Hi Jacques, I faced it on both, Linux (18.04) as well as

[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-11921-plugins-2.patch OFBIZ-11921-2.patch > Checkstyle:

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186892#comment-17186892 ] Suraj Khurana commented on OFBIZ-11926: --- Hello Jacques, This is an interesting case that you

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186483#comment-17186483 ] Suraj Khurana commented on OFBIZ-11947: --- This patch fixed around *1180* checkstyle issues. >

[jira] [Comment Edited] (OFBIZ-11970) Add to cart is not working for products with selectable features

[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186324#comment-17186324 ] Suraj Khurana edited comment on OFBIZ-11970 at 8/28/20, 7:19 AM: - Thanks

[jira] [Commented] (OFBIZ-11970) Add to cart is not working for products with selectable features

[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186324#comment-17186324 ] Suraj Khurana commented on OFBIZ-11970: --- Thanks [~lodhiravi], Could you please confirm if this

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186310#comment-17186310 ] Suraj Khurana commented on OFBIZ-11928: --- Hello [~ankush.upadhyay], These are all valid points

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186309#comment-17186309 ] Suraj Khurana commented on OFBIZ-11928: --- Thanks [~ankush.upadhyay] for the patch. I will wait for

[jira] [Updated] (OFBIZ-11978) "cart" should be "card"

[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11978: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > "cart"

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186275#comment-17186275 ] Suraj Khurana commented on OFBIZ-11947: --- Attached next patch consisting further enhancements of

[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947-2.patch > Checkstyle: Add Javadoc for classes designed for extension

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185777#comment-17185777 ] Suraj Khurana commented on OFBIZ-11926: --- Hello [~jleroux], I got your point. Could you please

[jira] [Updated] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11926: -- Attachment: JsLanguageFilesMapping.patch > Checkstyle: Variable name must match pattern >

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185310#comment-17185310 ] Suraj Khurana commented on OFBIZ-11926: --- Thanks Jacques, corrected inner class names as per naming

[jira] [Assigned] (OFBIZ-11978) "cart" should be "card"

[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11978: - Assignee: Suraj Khurana > "cart" should be "card" > --- > >

[jira] [Commented] (OFBIZ-11978) "cart" should be "card"

[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183212#comment-17183212 ] Suraj Khurana commented on OFBIZ-11978: --- Hi Alex, Will you please confirm if this if for trunk

[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

[ https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183205#comment-17183205 ] Suraj Khurana commented on OFBIZ-11954: --- I also faced this few days ago while working on an issue,

[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

[ https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183203#comment-17183203 ] Suraj Khurana commented on OFBIZ-11686: --- Hi [~jleroux], I remember we have enabled git pre-hook

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182719#comment-17182719 ] Suraj Khurana commented on OFBIZ-11926: --- All class names, method names, data members of class and

[jira] [Updated] (OFBIZ-11926) Checkstyle: Variable name must match pattern

[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11926: -- Attachment: OFBIZ-11926-plugins.patch OFBIZ-11926.patch > Checkstyle:

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182585#comment-17182585 ] Suraj Khurana commented on OFBIZ-11928: --- +1 Ankush, It looks good to me. Please verify all the

[jira] [Comment Edited] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390 ] Suraj Khurana edited comment on OFBIZ-11944 at 8/22/20, 2:15 PM: - I was

[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390 ] Suraj Khurana commented on OFBIZ-11944: --- I was about to reviw this, though it is committed pretty

[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11971: -- Sprint: OFBiz Community Day (Aug 2020) > Incorrect data for InvoiceItemTypeMap and

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182271#comment-17182271 ] Suraj Khurana commented on OFBIZ-11963: --- Thanks Jacques. I committed slightly modified patches,

[jira] [Updated] (OFBIZ-11350) Checkstyle improvements

[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11350: -- Sprint: OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020) (was: OFBiz Community

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181666#comment-17181666 ] Suraj Khurana commented on OFBIZ-11963: --- +1 for the first one, same thought and thus adding new

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181043#comment-17181043 ] Suraj Khurana commented on OFBIZ-11963: --- Right Jacques, used IntelliJ plugin to generate

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180981#comment-17180981 ] Suraj Khurana commented on OFBIZ-11963: --- ./gradlew testIntegration working fine. All tests

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180629#comment-17180629 ] Suraj Khurana commented on OFBIZ-11963: --- Attached initial patches, these are tend to fix around 2k

[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices

[ https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180627#comment-17180627 ] Suraj Khurana commented on OFBIZ-11965: --- This was discovered while working upon 

[jira] [Updated] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11963: -- Attachment: OFBIZ-11963.patch OFBIZ-11963-plugins.patch > Checkstyle:

[jira] [Created] (OFBIZ-11965) Improve service name as per best practices

Suraj Khurana created OFBIZ-11965: - Summary: Improve service name as per best practices Key: OFBIZ-11965 URL: https://issues.apache.org/jira/browse/OFBIZ-11965 Project: OFBiz Issue Type:

[jira] [Created] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

Suraj Khurana created OFBIZ-11963: - Summary: Checkstyle: Variable must be private and have accessor methods Key: OFBIZ-11963 URL: https://issues.apache.org/jira/browse/OFBIZ-11963 Project: OFBiz

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178780#comment-17178780 ] Suraj Khurana commented on OFBIZ-11947: --- This commit has fixed around *1960* checkstyle issues,

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178718#comment-17178718 ] Suraj Khurana commented on OFBIZ-11947: --- Oops, thanks Jacques, I will take care of it while

[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947.patch OFBIZ-11947-plugins.patch > Checkstyle: Add

[jira] [Created] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

Suraj Khurana created OFBIZ-11947: - Summary: Checkstyle: Add Javadoc for classes designed for extension Key: OFBIZ-11947 URL: https://issues.apache.org/jira/browse/OFBIZ-11947 Project: OFBiz

[jira] [Closed] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11941. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *1925*

[jira] [Closed] (OFBIZ-11931) ParameterNumber checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11931. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *110*

[jira] [Closed] (OFBIZ-11930) Remove unused imports from Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11930. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *54* checkstyle

[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172409#comment-17172409 ] Suraj Khurana commented on OFBIZ-11930: --- Hello Priya, I guess apart from those covered in PR,

[jira] [Assigned] (OFBIZ-11930) Remove unused imports from Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11930: - Assignee: Suraj Khurana (was: Priya Sharma) > Remove unused imports from Java files >

[jira] [Closed] (OFBIZ-11915) Handle MethodLength checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11915. - Fix Version/s: Upcoming Branch Resolution: Implemented As of now, this configuration

[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172372#comment-17172372 ] Suraj Khurana commented on OFBIZ-11915: --- +1, agreed. > Handle MethodLength checkstyle rule >

[jira] [Closed] (OFBIZ-11925) Checkstyle: Redundant modifiers

[ https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11925. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Jacques. > Checkstyle:

[jira] [Commented] (OFBIZ-11925) Checkstyle: Redundant modifiers

[ https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172370#comment-17172370 ] Suraj Khurana commented on OFBIZ-11925: --- This ticket fixed around 325 checkstyle issues. >

[jira] [Updated] (OFBIZ-11925) Checkstyle: Redundant modifiers

[ https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11925: -- Attachment: OFBIZ-11925.patch > Checkstyle: Redundant modifiers >

[jira] [Updated] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11941: -- Attachment: OFBIZ-11941.patch > Checkstyle: Add override property in DesignForExtension

[jira] [Created] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module

Suraj Khurana created OFBIZ-11941: - Summary: Checkstyle: Add override property in DesignForExtension module Key: OFBIZ-11941 URL: https://issues.apache.org/jira/browse/OFBIZ-11941 Project: OFBiz

[jira] [Updated] (OFBIZ-11931) ParameterNumber checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11931: -- Attachment: OFBIZ-11931.patch > ParameterNumber checkstyle rule >

[jira] [Updated] (OFBIZ-11915) Handle MethodLength checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11915: -- Attachment: OFBIZ-11915.patch > Handle MethodLength checkstyle rule >

[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169312#comment-17169312 ] Suraj Khurana commented on OFBIZ-11921: --- Attached initial patch, there will be some more for this

[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-plugins-11921.patch OFBIZ-11921.patch > Checkstyle: Line is

[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files

[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169291#comment-17169291 ] Suraj Khurana commented on OFBIZ-11930: --- Hi Priya, Thanks for creating this ticket. This is a

[jira] [Updated] (OFBIZ-11915) Handle MethodLength checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11915: -- Description: ML discussion: https://markmail.org/message/y4uuqrjsu5mtztwz > Handle

[jira] [Updated] (OFBIZ-11931) ParameterNumber checkstyle rule

[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11931: -- Parent: OFBIZ-11350 Issue Type: Sub-task (was: Improvement) > ParameterNumber

[jira] [Created] (OFBIZ-11931) ParameterNumber checkstyle rule

Suraj Khurana created OFBIZ-11931: - Summary: ParameterNumber checkstyle rule Key: OFBIZ-11931 URL: https://issues.apache.org/jira/browse/OFBIZ-11931 Project: OFBiz Issue Type: Improvement

  1   2   3   4   5   6   7   8   9   10   >