[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573257#comment-16573257
]
Mathieu Lirzin commented on OFBIZ-10485:
Thanks [~jacques.le.roux] for spotting that
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569448#comment-16569448
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Thank you for providing the patch. Implemented in
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569420#comment-16569420
]
Mathieu Lirzin commented on OFBIZ-10485:
done in
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569380#comment-16569380
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Oh and I recommend just creating a single patch, as I
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569379#comment-16569379
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Hi Mathieu, great I agree with all your suggestions.
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569306#comment-16569306
]
Mathieu Lirzin commented on OFBIZ-10485:
{quote}I'm not sure replacing {{stackList}} with maps
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569128#comment-16569128
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Patches 4, 5, 6, 7 and 8 are all applied on trunk in
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558129#comment-16558129
]
Mathieu Lirzin commented on OFBIZ-10485:
Thank you Taher, feel free to apply those patches the
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558123#comment-16558123
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Third patch implemented in r1836710. Thank you for
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555718#comment-16555718
]
Mathieu Lirzin commented on OFBIZ-10485:
Thanks Taher for applying the first two patches.
The
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555649#comment-16555649
]
Taher Alkhateeb commented on OFBIZ-10485:
-
The first two patches are implemented successfully.
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554337#comment-16554337
]
Mathieu Lirzin commented on OFBIZ-10485:
With the removal of dead code in the super class, then
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554281#comment-16554281
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Hi Mathieu,
One more question please, why did you
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554046#comment-16554046
]
Taher Alkhateeb commented on OFBIZ-10485:
-
I will apply the first commit today. Thank you.
>
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554025#comment-16554025
]
Mathieu Lirzin commented on OFBIZ-10485:
[~taher]: Where are you in the review process? Have you
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552660#comment-16552660
]
Pradhan Yash Sharma commented on OFBIZ-10485:
-
Hello Mathieu and Taher,
I have observed
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549224#comment-16549224
]
Pradhan Yash Sharma commented on OFBIZ-10485:
-
Hello Mathieu,
I would also like to review
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547927#comment-16547927
]
Mathieu Lirzin commented on OFBIZ-10485:
Hello Taher,
I have used my IDE to check for
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547849#comment-16547849
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Hi Mathiue,
So for the first patch, can you confirm
[
https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547448#comment-16547448
]
Taher Alkhateeb commented on OFBIZ-10485:
-
Awesome Mathieu, I will review ASAP
> Refactor
20 matches
Mail list logo
