[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2019-01-12 Thread Shikha Jaiswal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741156#comment-16741156 ] Shikha Jaiswal commented on OFBIZ-10689: I have provided the patch for groovy files. Please

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731234#comment-16731234 ] Jacques Le Roux commented on OFBIZ-10689: - I have committed the name and Javadoc changes at

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-21 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727232#comment-16727232 ] Deepak Dixit commented on OFBIZ-10689: -- I think we can mark this as improvement instead bug >

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-07 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712543#comment-16712543 ] Jacques Le Roux commented on OFBIZ-10689: - Thanks for feedback Pierre, No worries, if nobody

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-07 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712480#comment-16712480 ] Pierre Smits commented on OFBIZ-10689: -- Hey [~jacques.le.roux], I don't think I will be in the

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710113#comment-16710113 ] Jacques Le Roux commented on OFBIZ-10689: - I attached [^OFBIZ-10689-rename.patch] as a simple

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708481#comment-16708481 ] Jacques Le Roux commented on OFBIZ-10689: - Also there are some (hopefully rare) cases where it

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708475#comment-16708475 ] Jacques Le Roux commented on OFBIZ-10689: - Not quite, from {{ObjectTypeTests.java}} List, Map,

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708413#comment-16708413 ] Deepak Dixit commented on OFBIZ-10689: -- I think simpleTypeConvert is the right name. > function

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708403#comment-16708403 ] Jacques Le Roux commented on OFBIZ-10689: - I can't find any bq.

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-03 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708256#comment-16708256 ] Deepak Dixit commented on OFBIZ-10689: -- @param type Optional Java class name of type to convert to.

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-03 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708249#comment-16708249 ] Deepak Dixit commented on OFBIZ-10689: -- Hi Jacques, I think ObjectType.simpleTypeConvert supports

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-03 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708230#comment-16708230 ] Jacques Le Roux commented on OFBIZ-10689: - Hi Deepak, Currently simpleTypeConvert does not

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-03 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708193#comment-16708193 ] Deepak Dixit commented on OFBIZ-10689: -- I think we can remove this method, and it woudl be good to