[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833227#comment-17833227
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832420#comment-17832420
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831003#comment-17831003
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752138#comment-17752138
]
Michael Brohl commented on OFBIZ-12813:
---
+1 for closing
[~deepak] the dependency to the
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751945#comment-17751945
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi,
I think we should close here and open a Jira for
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750210#comment-17750210
]
Deepak Dixit commented on OFBIZ-12813:
--
Now able to build locally,
It seems it was an gradle
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750149#comment-17750149
]
Jacques Le Roux commented on OFBIZ-12813:
-
BTW, thanks for test-suite.xsd in site repo :)
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750145#comment-17750145
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Deepak,
bq. We should not include plugins
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750098#comment-17750098
]
Deepak Dixit commented on OFBIZ-12813:
--
Not able to build trunk on local, disabled the codenarc
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750093#comment-17750093
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750087#comment-17750087
]
Deepak Dixit commented on OFBIZ-12813:
--
>>>Deepak Dixit why shoul we "remove the projectmgr groovy
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749921#comment-17749921
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749920#comment-17749920
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749608#comment-17749608
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749603#comment-17749603
]
Michael Brohl commented on OFBIZ-12813:
---
There is a problem with a duplicate class now:
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749574#comment-17749574
]
Michael Brohl commented on OFBIZ-12813:
---
Everything is merged now.
> Refactor groovy folder
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749572#comment-17749572
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749570#comment-17749570
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749573#comment-17749573
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749568#comment-17749568
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749571#comment-17749571
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749569#comment-17749569
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749566#comment-17749566
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749567#comment-17749567
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749265#comment-17749265
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Michael,
I have applied both patches and all
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749256#comment-17749256
]
Michael Brohl commented on OFBIZ-12813:
---
I've created a new PR fixing the remaining issues in
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748965#comment-17748965
]
Michael Brohl commented on OFBIZ-12813:
---
The changes for the plugins are added to the PR.
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748960#comment-17748960
]
Michael Brohl commented on OFBIZ-12813:
---
Thank you Jacques for the review and the summary of the
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748951#comment-17748951
]
Jacques Le Roux commented on OFBIZ-12813:
-
The ecommerce and project apps seem to work as
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748950#comment-17748950
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Michael,
After succesfully patching from your PR,
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748917#comment-17748917
]
Michael Brohl commented on OFBIZ-12813:
---
I've provided pull request
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748640#comment-17748640
]
Michael Brohl commented on OFBIZ-12813:
---
[~jleroux] [~deepak] we will work on this asap and also
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748636#comment-17748636
]
Jacques Le Roux commented on OFBIZ-12813:
-
The framework still contents:
* The groovyScripts
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748634#comment-17748634
]
Jacques Le Roux commented on OFBIZ-12813:
-
I forgot to put the Jira number so here is manually
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748523#comment-17748523
]
Deepak Dixit commented on OFBIZ-12813:
--
Thanks [~mbrohl],
Need to update the organize
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748465#comment-17748465
]
Jacques Le Roux commented on OFBIZ-12813:
-
plugins contains some more
> Refactor groovy folder
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748463#comment-17748463
]
Michael Brohl commented on OFBIZ-12813:
---
Addition: if I do a search on GitHub with
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748464#comment-17748464
]
Jacques Le Roux commented on OFBIZ-12813:
-
OK, no problems
> Refactor groovy folder structure
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748461#comment-17748461
]
Michael Brohl commented on OFBIZ-12813:
---
We will organise to handle this even when Wiebke is on
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748458#comment-17748458
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi,
We have still 487 occurences of /groovyScripts/
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748448#comment-17748448
]
Deepak Dixit commented on OFBIZ-12813:
--
Thanks [~zhangwei] for reporting, this has been fixed under
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748441#comment-17748441
]
Wei Zhang commented on OFBIZ-12813:
---
Some script locations are incorrect now please search
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748440#comment-17748440
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748410#comment-17748410
]
Deepak Dixit commented on OFBIZ-12813:
--
Hi [~jleroux], [~wpaetzold]
ofbiz-plugins still have the
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748238#comment-17748238
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748162#comment-17748162
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Thanks [~jleroux] and [~deepak] for reviewing :)
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748146#comment-17748146
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748150#comment-17748150
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748145#comment-17748145
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748144#comment-17748144
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748148#comment-17748148
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748149#comment-17748149
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748147#comment-17748147
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748075#comment-17748075
]
Jacques Le Roux commented on OFBIZ-12813:
-
Ah, thanks Michael, it's all clear
> Refactor groovy
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748074#comment-17748074
]
Jacques Le Roux commented on OFBIZ-12813:
-
Apart this question, it's OK with me.
As you
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747913#comment-17747913
]
Michael Brohl commented on OFBIZ-12813:
---
return is a reserved word and cannot be used for package
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747887#comment-17747887
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
I have a question : why order/return was
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747871#comment-17747871
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
Don't worry I don't need help on Eclipse.
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747843#comment-17747843
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi [~jleroux] ,
unfortunately I can not help you
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747605#comment-17747605
]
Jacques Le Roux commented on OFBIZ-12813:
-
OK, it's more work than I thought because of the GH
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747458#comment-17747458
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
Yes, this was just as a note and is in no
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747437#comment-17747437
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi,
since this error was not caused by the groovy
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747354#comment-17747354
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi,
Thanks for spotting that Deepak,
Something to
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747263#comment-17747263
]
Deepak Dixit commented on OFBIZ-12813:
--
Thanks [~wpaetzold]
New PR looks good to me.
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747112#comment-17747112
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi [~deepak],
Thanks for the hint. I simply missed
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746763#comment-17746763
]
Deepak Dixit commented on OFBIZ-12813:
--
Hi [~wpaetzold]
We should follow the package name similar
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746598#comment-17746598
]
Jacques Le Roux commented on OFBIZ-12813:
-
Thanks Wiebke,
Sounds good to me, +1
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746511#comment-17746511
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi Jacques,
I have created a new feature branch for
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746061#comment-17746061
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
Actually it seems that the branch you
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745679#comment-17745679
]
Jacques Le Roux commented on OFBIZ-12813:
-
Thanks Wiebke and Shan,
I'll have a look...
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745564#comment-17745564
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi [~jleroux] ,
the problem was not this one
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744722#comment-17744722
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
We have a problem with
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717905#comment-17717905
]
Jacques Le Roux commented on OFBIZ-12813:
-
A discussion started at
73 matches
Mail list logo
