[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170534#comment-17170534
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Pawan and Jacques.
I have created a new
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167853#comment-17167853
]
Jacques Le Roux commented on OFBIZ-9254:
bq. Jacques Le Roux Lets create a new ticket for the
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167836#comment-17167836
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167835#comment-17167835
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167829#comment-17167829
]
Pawan Verma commented on OFBIZ-9254:
Sure, [~jleroux] On it.
> Inconsistent String Comparisons
>
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167617#comment-17167617
]
Devanshu Vyas commented on OFBIZ-9254:
--
Yes, the last 2 patches which I added in May are pending. I
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308
]
Pawan Verma commented on OFBIZ-9254:
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165680#comment-17165680
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165679#comment-17165679
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165677#comment-17165677
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165682#comment-17165682
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165625#comment-17165625
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165623#comment-17165623
]
ASF subversion and git services commented on OFBIZ-9254:
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165486#comment-17165486
]
Jacques Le Roux commented on OFBIZ-9254:
BTW, just realized that {{} else if
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165480#comment-17165480
]
Jacques Le Roux commented on OFBIZ-9254:
Don't feel bad Devanshu, happens to all of us ;). I'll
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165421#comment-17165421
]
Devanshu Vyas commented on OFBIZ-9254:
--
I feel bad for mistakenly breaking the startsWith method in
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165178#comment-17165178
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Ankush,
In 1st place I wonder why we had:
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164818#comment-17164818
]
Ankush Upadhyay commented on OFBIZ-9254:
[~devanshu.vyas],
Due to this ticket efforts,
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099520#comment-17099520
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks [~jleroux], [~pierresmits]. I will update the patches
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098836#comment-17098836
]
Jacques Le Roux commented on OFBIZ-9254:
Hi Pierre,
I agree, that could be another step, since
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098294#comment-17098294
]
Pierre Smits commented on OFBIZ-9254:
-
I see a lot of the following kinds of string comparisons (even
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098279#comment-17098279
]
Jacques Le Roux commented on OFBIZ-9254:
+1 good for commit
> Inconsistent String Comparisons
>
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098244#comment-17098244
]
Suraj Khurana commented on OFBIZ-9254:
--
Thanks Devanshu,
Both the recently added patches looks good
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097987#comment-17097987
]
Devanshu Vyas commented on OFBIZ-9254:
--
I have prepared 2 patches, one for the ofbiz-framework and
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028507#comment-17028507
]
Devanshu Vyas commented on OFBIZ-9254:
--
I forgot to pick it up and complete it. Thanks [~mbrohl] for
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027584#comment-17027584
]
Michael Brohl commented on OFBIZ-9254:
--
[~devanshu.vyas], [~deepak] how do you plan to go on with
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759367#comment-16759367
]
Deepak Dixit commented on OFBIZ-9254:
-
[~devanshu.vyas], Any update on this?
> Inconsistent String
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205842#comment-16205842
]
Nicolas Malin commented on OFBIZ-9254:
--
thanks for this tasks guys
> Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205786#comment-16205786
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks a bunch Deepak, must have been quite a review!
>
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205781#comment-16205781
]
Deepak Dixit commented on OFBIZ-9254:
-
Thanks Devanshu for your contribution.
Remaining patches has
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079101#comment-16079101
]
Arun Patidar commented on OFBIZ-9254:
-
OFBIZ-9254_FTL-I.patch :- Committed revision 1801268
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079052#comment-16079052
]
Arun Patidar commented on OFBIZ-9254:
-
Thanks Devanshu. I am going to start reviewing and committing
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012752#comment-16012752
]
Deepak Dixit commented on OFBIZ-9254:
-
OFBIZ-9254_groovy_applications.patch has been committed at
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988537#comment-15988537
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Jacques!
Removed the large patch files to avoid
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988527#comment-15988527
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Devanshu,
I suggest we drop the big file, to
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979871#comment-15979871
]
Jacques Le Roux commented on OFBIZ-9254:
Hi Devanshu,
Yes best way to handle it indeed, notably
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978347#comment-15978347
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Jacques, for your courageous efforts!! The patch file
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978338#comment-15978338
]
Deepak Dixit commented on OFBIZ-9254:
-
Its too large patch :)
Devanshu,
Could you please break them
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978318#comment-15978318
]
Jacques Le Roux commented on OFBIZ-9254:
Hi Devanshu,
I agree it needs to be done by hand. I did
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952212#comment-15952212
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Devanshu,
Perfect, I'll try to find a regexp and
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952137#comment-15952137
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Jacques for reviewing the patch.
I have done all the
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950326#comment-15950326
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Devanshu,
I have reviewed the Groovy patch and
42 matches
Mail list logo
