[GitHub] commons-compress pull request #:

2017-07-06 Thread sesuncedu
Github user sesuncedu commented on the pull request: https://github.com/apache/commons-compress/commit/fde66702c33d3888b682adc7e6c35dd21cb1e8da#commitcomment-22956623 In src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java: In src/main/java/org/apache

[GitHub] commons-compress pull request #48: COMPRESS-416 Extended times for Zip shoul...

2017-07-03 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/48 COMPRESS-416Extended times for Zip should be signed values This has fixed code, and almost fixed tests (fixed for jdk9; haven't removed all the invalid checks for jdk8). You can

[GitHub] commons-compress issue #49: COMPRESS-413 set execute back on mvnw

2017-07-04 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/49 Did you also re-add .mvn? On Jul 4, 2017 8:31 AM, "Stefan Bodewig" <notificati...@github.com> wrote: > I've made mvnw executable again with ee

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

2017-06-22 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/39 COMPRESS-413: Performance improvements for Travis builds Change travis configuration to - skip pre-build install (which runs the install goal). - remove after_success code

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

2017-06-22 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/39 Randomly adding coverage tests for coveralls --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

2017-06-22 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

2017-06-22 Thread sesuncedu
GitHub user sesuncedu reopened a pull request: https://github.com/apache/commons-compress/pull/39 COMPRESS-413: Performance improvements for Travis builds Change travis configuration to - skip pre-build install (which runs the install goal). - remove after_success code

[GitHub] commons-compress issue #42: COMPRESS-407: Allow use of invalid record sizes ...

2017-06-22 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/42 The system property is can be discovered by reading the source code. This information could be added to the exception message. --- If your project is set up for it, you can reply

[GitHub] commons-compress pull request #42: COMPRESS-407: Allow use of invalid record...

2017-06-22 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/42 COMPRESS-407: Allow use of invalid record sizes if a system property is set. I do not recommend using this approach. #40 is the preferred solution. You can merge this pull request

[GitHub] commons-compress pull request #41: COMPRESS-407 - Just Warn

2017-06-22 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/41 COMPRESS-407 - Just Warn Warn if an invalid record size is set. I would not recommend using this approach. You can merge this pull request into a Git repository by running

[GitHub] commons-compress pull request #30: COMPRESS-407 - Validate Block and Record ...

2017-06-22 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-compress pull request #40: COMPRESS-407 Validate Block and Record Si...

2017-06-22 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/40 COMPRESS-407 Validate Block and Record Sizes Original (require correct record size) Require block size >=0 that is multiple of 512 bytes. Use block size of 512 if

[GitHub] commons-compress pull request #44: Misc Coverage checks

2017-06-24 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/44 Misc Coverage checks Various coverage increases to pay for coveralls karma Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge this pull request into a Git repo

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

2017-06-24 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-compress pull request #43: COMPRESS-413 : Improved build performance...

2017-06-24 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/43 COMPRESS-413 : Improved build performance with travis Now without unrelated sacrifices to coveralls Signed-off-by: Simon Spero <sesunc...@gmail.com> You can merge thi

[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-24 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/43 That's why there was random coveralls stuff in the PR... coverage/coveralls — Coverage decreased (-0.02%) to 84.742% --- If your project is set up for it, you can reply

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

2017-06-24 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/39 Replaced by PR https://github.com/apache/commons-compress/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

2017-06-24 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/39 Closing because there's a new PR without the coveralls bait. Coveralls complains. The mvnw is not essential yet, but it's good to have 3.5.0 in place. --- If your

[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/43 I think there is also some jacoco oddness related to synthetic methods in certain JDKs , but mostly I blame coveralls, since I'm not sure jacoco is wrong :-) IntelliJ has a bunch

[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

2017-06-26 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/43 Travis has some nice properties, especially when working with forks. It's very easy to enable travis for a fork, so CI can be done before a PR goes in. Travis can also run really

[GitHub] commons-compress pull request #46: COMPRESS-400 : Squashed version of COMPRE...

2017-06-25 Thread sesuncedu
GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/46 COMPRESS-400 : Squashed version of COMPRESS-400-REDUX. Add support for extra PAX headers (local and global). This PR has a single squash commit to simplify final review Signed