[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation
[ https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114651#comment-17114651 ] ASF subversion and git services commented on OFBIZ-11678: - Commit 8bdb6c99856fd4ae17a95ccb0f661a256caaab13 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8bdb6c9 ] Improved: Make shipment services loosely coupled with work-effort generation. (#132) * Improved: Make shipment services loosely coupled with work-effort generation. (OFBIZ-11678) Removed workeffort generation related code in separate service, in createShipment and updateShipment service. In this effort, createShipment has been successfully changed to entity-auto as well. Thanks: Pierre Smits and Arun Patidar for discussion and review. > Make Shipment services loosely coupled with work-effort generation > -- > > Key: OFBIZ-11678 > URL: https://issues.apache.org/jira/browse/OFBIZ-11678 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Labels: Refactoring > > Currently, createShipment and updateShipment services creates/updates > work-effort and related code is written inside the same service, this should > not be tightly coupled with each other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation
[ https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114596#comment-17114596 ] Arun Patidar commented on OFBIZ-11678: -- Changes looks good to me. Thanks Suraj. > Make Shipment services loosely coupled with work-effort generation > -- > > Key: OFBIZ-11678 > URL: https://issues.apache.org/jira/browse/OFBIZ-11678 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Labels: Refactoring > > Currently, createShipment and updateShipment services creates/updates > work-effort and related code is written inside the same service, this should > not be tightly coupled with each other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation
[ https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103207#comment-17103207 ] Pierre Smits commented on OFBIZ-11678: -- Whatever works best, correct? > Make Shipment services loosely coupled with work-effort generation > -- > > Key: OFBIZ-11678 > URL: https://issues.apache.org/jira/browse/OFBIZ-11678 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, createShipment and updateShipment services creates/updates > work-effort and related code is written inside the same service, this should > not be tightly coupled with each other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation
[ https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103196#comment-17103196 ] Suraj Khurana commented on OFBIZ-11678: --- Yes, I was also thinking about it. One proposal is to change the existing mini-lang to groovy with suggested changes being incorporated. Another is to do it in two steps, first change it to groovy code as is and then remove dependency. Tough in a cursory review, if we remove existing work-effort code dependency, shipment services can be converted to entity-auto as well. :) So I am in favour fo first proposal. > Make Shipment services loosely coupled with work-effort generation > -- > > Key: OFBIZ-11678 > URL: https://issues.apache.org/jira/browse/OFBIZ-11678 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, createShipment and updateShipment services creates/updates > work-effort and related code is written inside the same service, this should > not be tightly coupled with each other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation
[ https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103175#comment-17103175 ] Pierre Smits commented on OFBIZ-11678: -- Hi [~surajk], I agree. If in the warehousing department 100s of shipments need to prepared then this would lead to an overkill of tasks (work efforts) that need to be assigned, managed and closed. But given that this is still minilang code, I suggest we implement this after the migration of the relating code to groovy has been implemented. > Make Shipment services loosely coupled with work-effort generation > -- > > Key: OFBIZ-11678 > URL: https://issues.apache.org/jira/browse/OFBIZ-11678 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, createShipment and updateShipment services creates/updates > work-effort and related code is written inside the same service, this should > not be tightly coupled with each other. -- This message was sent by Atlassian Jira (v8.3.4#803005)
