Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-23 Thread via GitHub
PierreSmits commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2072800179 HI Jacques, Thank you for your review and feedback. I can't tell why the screen separation is as it is. But if that is an issue: a new ticket is warranted. Testing the

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-23 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2071653977 The screen separation is static. Did you think about the case where the tree would much grow? What will happen then? The need to see the leaves might be problematic. Even if

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-23 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2071645444 Hi Pierre, Sorry, I simply forgot import the data :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
PierreSmits commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2070842051 HI Jacques, Did you clear your cache? Logging out and in again could also help. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069939651 Ha, maybe it needs PR121 1st, trying... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069927544 Hi @PierreSmits , When applying your PR as patch, I get: > java.lang.RuntimeException: Could not find PortalPage with portalPageId [] -- This is an automated

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-21 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2068082116 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate