Re: [Nouveau] [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-12-06 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 12:45:07PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Nov 17, 2023 at 3:00 PM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Sep 22, 2023 at 2:06 PM Lyude Paul wrote: > > > > > > actually very glad to see this because I think I've seen one bug in the > > > wild > >

Re: [Nouveau] [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-12-05 Thread Doug Anderson
Hi, On Fri, Nov 17, 2023 at 3:00 PM Doug Anderson wrote: > > Hi, > > On Fri, Sep 22, 2023 at 2:06 PM Lyude Paul wrote: > > > > actually very glad to see this because I think I've seen one bug in the wild > > as a result of things not getting shut down :) > > > > Reviewed-by: Lyude Paul > >

Re: [Nouveau] [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-11-17 Thread Doug Anderson
Hi, On Fri, Sep 22, 2023 at 2:06 PM Lyude Paul wrote: > > actually very glad to see this because I think I've seen one bug in the wild > as a result of things not getting shut down :) > > Reviewed-by: Lyude Paul > Tested-by: Lyude Paul Any idea of where / how this patch should land. Would you

Re: [Nouveau] [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-09-22 Thread Lyude Paul
actually very glad to see this because I think I've seen one bug in the wild as a result of things not getting shut down :) Reviewed-by: Lyude Paul Tested-by: Lyude Paul On Thu, 2023-09-21 at 12:26 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears

[Nouveau] [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() (or drm_helper_force_disable_all() if not using atomic) at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at