Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-04-02 Thread Mark Wiebe
On Thu, Mar 31, 2011 at 11:45 AM, Ralf Gommers ralf.gomm...@googlemail.comwrote: On Thu, Mar 31, 2011 at 8:37 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Thu, Mar 31, 2011 at 10:40 AM, Ralf Gommers ralf.gomm...@googlemail.com wrote: It would definitely need to get into beta 2,

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-04-02 Thread Charles R Harris
On Sat, Apr 2, 2011 at 12:39 PM, Mark Wiebe mwwi...@gmail.com wrote: On Thu, Mar 31, 2011 at 11:45 AM, Ralf Gommers ralf.gomm...@googlemail.com wrote: On Thu, Mar 31, 2011 at 8:37 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Thu, Mar 31, 2011 at 10:40 AM, Ralf Gommers

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-04-02 Thread Eli Stevens (Gmail)
On Sat, Apr 2, 2011 at 11:39 AM, Mark Wiebe mwwi...@gmail.com wrote: I've committed the patch adding 'e' to the buffer protocol and back-ported it to the 1.6.x branch. Awesome! Thanks a bunch. :) This leaves the testing with Cython and getting consensus from CPython about the letter to use

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-04-01 Thread Pauli Virtanen
Thu, 31 Mar 2011 11:15:08 -0700, Mark Wiebe wrote: [clip] My reading of Pauli's thoughts was that putting it in unilaterally is undesirable, something I definitely agree with. I think with Eli doing the legwork of getting input and acceptance from the relevant parties, we should help him out

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-04-01 Thread Eli Stevens (Gmail)
On Fri, Apr 1, 2011 at 5:28 PM, Mark Wiebe mwwi...@gmail.com wrote: Your changes look fine to me, and I think the tests are reasonable as is. I would suggest tidying up your commit messages a bit, creating an enhancement bug in the bug tracker, and making a pull request. Some info about the

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Mark Wiebe
On Wed, Mar 30, 2011 at 4:42 PM, Eli Stevens (Gmail) wickedg...@gmail.comwrote: On Fri, Mar 25, 2011 at 10:00 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: Can anyone please give me some suggestions on how to go about writing a unit test for this? Or should I just submit a pull

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Ralf Gommers
On Thu, Mar 31, 2011 at 7:06 PM, Mark Wiebe mwwi...@gmail.com wrote: On Wed, Mar 30, 2011 at 4:42 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:00 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: Can anyone please give me some suggestions on how to go

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Mark Wiebe
On Thu, Mar 31, 2011 at 10:40 AM, Ralf Gommers ralf.gomm...@googlemail.comwrote: On Thu, Mar 31, 2011 at 7:06 PM, Mark Wiebe mwwi...@gmail.com wrote: On Wed, Mar 30, 2011 at 4:42 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:00 AM, Eli Stevens (Gmail)

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Eli Stevens (Gmail)
On Thu, Mar 31, 2011 at 10:40 AM, Ralf Gommers ralf.gomm...@googlemail.com wrote: It would definitely need to get into beta 2, and even then I'm a little hesitant to push in such a change at the last moment. If I miss the 1.6.0b2 cutoff, would a change like this be appropriate for 1.6.1, or

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Ralf Gommers
On Thu, Mar 31, 2011 at 8:37 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Thu, Mar 31, 2011 at 10:40 AM, Ralf Gommers ralf.gomm...@googlemail.com wrote: It would definitely need to get into beta 2, and even then I'm a little hesitant to push in such a change at the last moment. If

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-31 Thread Eli Stevens (Gmail)
On Thu, Mar 31, 2011 at 11:45 AM, Ralf Gommers ralf.gomm...@googlemail.com wrote: On Thu, Mar 31, 2011 at 8:37 PM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: Next up for me is to get a patch onto the CPython issue tracker, but as soon as I have that done, I'll start working on adding unit

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-30 Thread Eli Stevens (Gmail)
On Fri, Mar 25, 2011 at 10:00 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: Can anyone please give me some suggestions on how to go about writing a unit test for this?  Or should I just submit a pull request? I've gotten a bit of positive feedback to adding the 'e' type to the struct

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-28 Thread Eli Stevens (Gmail)
On Fri, Mar 25, 2011 at 11:14 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python core developers about the float16 type is worthwhile. There might be interest in

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-28 Thread Mark Wiebe
On Mon, Mar 28, 2011 at 10:45 AM, Eli Stevens (Gmail) wickedg...@gmail.comwrote: On Fri, Mar 25, 2011 at 11:14 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python

[Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Eli Stevens (Gmail)
I'm working on getting support for 16-bit floats into cython and have run into what seems like a numpy bug (I'm a new contributor to both projects, so bear with me ;). https://github.com/wickedgrey/numpy/commit/29f9f1b709cc2c346b8514859c58a761df80f031 Adding NPY_HALF to the switch statement on

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Pauli Virtanen
Fri, 25 Mar 2011 10:00:24 -0700, Eli Stevens (Gmail) wrote: I'm working on getting support for 16-bit floats into cython and have run into what seems like a numpy bug (I'm a new contributor to both projects, so bear with me ;). https://github.com/wickedgrey/numpy/

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Mark Wiebe
On Fri, Mar 25, 2011 at 10:21 AM, Pauli Virtanen p...@iki.fi wrote: Fri, 25 Mar 2011 10:00:24 -0700, Eli Stevens (Gmail) wrote: I'm working on getting support for 16-bit floats into cython and have run into what seems like a numpy bug (I'm a new contributor to both projects, so bear with

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Eli Stevens (Gmail)
On Fri, Mar 25, 2011 at 10:21 AM, Pauli Virtanen p...@iki.fi wrote: The buffer interface cannot be used to export the half-float types, since the type is not specified in PEP 3118. Numpy cannot unilaterally add nonstandard format codes to the spec. What can be done instead is exporting the

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Eli Stevens (Gmail)
On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python core developers about the float16 type is worthwhile. There might be interest in supporting the float16 type in the struct interface, something that would be required

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Mark Wiebe
On Fri, Mar 25, 2011 at 11:14 AM, Eli Stevens (Gmail) wickedg...@gmail.comwrote: On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python core developers about the float16 type is worthwhile. There might be interest in

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Charles R Harris
On Fri, Mar 25, 2011 at 12:28 PM, Mark Wiebe mwwi...@gmail.com wrote: On Fri, Mar 25, 2011 at 11:14 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python core

Re: [Numpy-discussion] 1.6.0b1 half float buffer bug?

2011-03-25 Thread Mark Wiebe
On Fri, Mar 25, 2011 at 11:28 AM, Mark Wiebe mwwi...@gmail.com wrote: On Fri, Mar 25, 2011 at 11:14 AM, Eli Stevens (Gmail) wickedg...@gmail.com wrote: On Fri, Mar 25, 2011 at 10:35 AM, Mark Wiebe mwwi...@gmail.com wrote: That said, I think starting a discussion with the Python core