Re: [Numpy-discussion] Cross-correlation PR stuck in limbo

2016-05-27 Thread Jaime Fernández del Río
I did an overall review of the code a couple of weeks ago (see the PR for details), and there is quite some work to be done before we can merge Honi's code. But if he can find the time to work on the coding, I'll try to be more diligent about the reviewing. Jaime On Fri, May 27, 2016 at 12:51

Re: [Numpy-discussion] Cross-correlation PR stuck in limbo

2016-05-27 Thread Elliot Hallmark
+1 This would really help with large data sets in certain situations. Is there still disagreement about whether this should be included? Or are there some minor details still? Or just lost in the shuffle? Hopefully, Elliot On Wed, May 4, 2016 at 7:07 AM, Pierre Haessig

Re: [Numpy-discussion] Cross-correlation PR stuck in limbo

2016-05-04 Thread Pierre Haessig
Hi, I don't know how to push the PR forward, but all I can say is that this maxlag feature would be a major improvement for using Numpy in time series analysis! Immediate benefits downstream for Matplotlib and statsmodel. Thanks Honi for having taken the time to implement this! best, Pierre

[Numpy-discussion] Cross-correlation PR stuck in limbo

2016-05-03 Thread Honi Sanders
Hello all, I have completed a pull request to add a “maxlag” functionality to numpy.correlate. See here: https://github.com/numpy/numpy/pull/5978 . This pull request has passed all tests and has been ready to be merged for around six months. Several