Re: [Numpy-discussion] Proposal to support __format__

2017-02-15 Thread Nathan Goldbaum
On Wed, Feb 15, 2017 at 4:05 PM, Ilhan Polat wrote: > On the last item, do we really have to follow that strange, `d`,`g` and so > on conventions on formatting? With all respect to the humongous historical > baggage, I think that notation is pretty archaic and terminal

Re: [Numpy-discussion] Proposal to support __format__

2017-02-15 Thread Ilhan Polat
On the last item, do we really have to follow that strange, `d`,`g` and so on conventions on formatting? With all respect to the humongous historical baggage, I think that notation is pretty archaic and terminal like. If being pythonic is of a concern here, maybe it is better to use a more verbose

Re: [Numpy-discussion] Proposal to support __format__

2017-02-15 Thread Gustav Larsson
> > This is great! Thanks! Glad to be met by enthusiasm about this. 1. You basically have a NEP already! Making a PR from it allows to > give line-by-line comments, so would help! I will do this soon. 2. Don't worry about supporting python2 specifics; just try to ensure > it doesn't break; I

Re: [Numpy-discussion] Proposal to support __format__

2017-02-15 Thread Marten van Kerkwijk
Hi Gustav, This is great! A few quick comments (mostly echo-ing Stephan's). 1. You basically have a NEP already! Making a PR from it allows to give line-by-line comments, so would help! 2. Don't worry about supporting python2 specifics; just try to ensure it doesn't break; I would not say more

Re: [Numpy-discussion] Proposal to support __format__

2017-02-14 Thread Stephan Hoyer
On Tue, Feb 14, 2017 at 5:35 PM, Gustav Larsson wrote: > 1. For object arrays, I would default to calling format on each element >> (your "map principle") rather than raising an error. >> > > I'm glad you brought this up as a possibility. It might be possible, but >

Re: [Numpy-discussion] Proposal to support __format__

2017-02-14 Thread Gustav Larsson
> > I encourage you to submit it as a pull request to the NumPy repository as > a "NumPy Enhancement Proposal", either now or after we've discussed it: > https://docs.scipy.org/doc/numpy-dev/neps/index.html OK, I will let it go through one iteration of comments and then I'll submit one. Thanks!

Re: [Numpy-discussion] Proposal to support __format__

2017-02-14 Thread Stephan Hoyer
On Tue, Feb 14, 2017 at 3:34 PM, Gustav Larsson wrote: > Hi everyone! > > I want to discuss adding support for __format__ in ndarray and I am > willing to > contribute code-wise once consensus has been reached. It was briefly > discussed on GitHub two years ago