Re: [Ocfs2-devel] [PATCH 0/7] [RESEND] Fix some deadlocks in quota code and implement lockdep for cluster locks

2009-06-09 Thread Joel Becker
On Thu, Jun 04, 2009 at 12:09:36PM +0200, Jan Kara wrote: On Wed 03-06-09 19:26:46, Joel Becker wrote: The fixes are now in the merge-window branch of ocfs2.git. They also live on the quota-fixes topic branch. The lockdep changes still need some marinating. Thanks. With lockdep

Re: [Ocfs2-devel] [PATCH] OCFS2: fdatasync should skip unimportant metadata writeout

2009-06-09 Thread Mark Fasheh
On Tue, Jun 09, 2009 at 04:47:45PM +0900, Hisashi Hifumi wrote: Hi. In ocfs2, fdatasync and fsync are identical. I think fdatasync should skip committing transaction when inode-i_state is set just I_DIRTY_SYNC and this indicates only atime or/and mtime updates. Following patch improves

Re: [Ocfs2-devel] [PATCH] OCFS2: fdatasync should skip unimportant metadata writeout

2009-06-09 Thread Joel Becker
On Tue, Jun 09, 2009 at 04:47:45PM +0900, Hisashi Hifumi wrote: In ocfs2, fdatasync and fsync are identical. I think fdatasync should skip committing transaction when inode-i_state is set just I_DIRTY_SYNC and this indicates only atime or/and mtime updates. Following patch improves fdatasync

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-06-09 Thread Sunil Mushran
Srini, I was re-reviewing these patches as part of 1.4 merge and something caught my eye. Specifically that this may slowdown umount unnecessarily. Consider the case if scan_work() is fired a tick before scan_stop(). Currently, scan_stop() will cancel the newly queued scan_work() but do nothing

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-06-09 Thread Tao Ma
Hi Srini/Joel/Sunil, I also have some thoughts for it. Wish it isn't too late. Currently, orphan scan just iterate all the slots and call ocfs2_queue_recovery_completion, but I don't think it is proper for a node to query another mounted one since that node will query it by