[Ocfs2-devel] [PATCH] Track negative dentries

2010-06-18 Thread Goldwyn Rodrigues
Track negative dentries by recording the generation number of the parent directory in d_fsdata. The generation number for the parent directory is recorded in the inode_info, which increments every time the lock on the directory is dropped. If the generation number of the parent directory and the

Re: [Ocfs2-devel] [PATCH] Track negative dentries

2010-06-18 Thread Sunil Mushran
Thanks for taking on this task. One overall comment about comments. Instead of sprinkling the same line everywhere, add the full description in one place. Maybe atop ocfs2_attach_dentry_gen(). Describe it fully. And then let the code speak for itself. Also, do remember to run the patch thru

Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: o2dlm fix race in purge lockres and newlock (orabug 9094491)

2010-06-18 Thread Srinivas Eeda
On 6/17/2010 7:11 PM, Sunil Mushran wrote: This patch looks ok on the surface. Should be usable. But checking into the repo is another matter. ok, won't checkin but will give this as one-off fix for now. My problem is that this flag is very much like inflight_locks but is not the same.

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2 fix o2dlm dlm run purgelist

2010-06-18 Thread Sunil Mushran
On 06/17/2010 07:37 PM, Wengang Wang wrote: On 10-06-17 08:06, Sunil Mushran wrote: On 06/15/2010 11:06 PM, Wengang Wang wrote: still the question. If you have sent DEREF request to the master, and the lockres became in-use again, then the lockres remains in the hash table and