[Ocfs2-devel] [PATCH 1/1] Ocfs2: Add a mount option coherency=* to handle cluster coherency for O_DIRECT writes.

2010-10-11 Thread Tristan Ye
Currently, default behavior of O_DIRECT writes was allowing concurrent writing among nodes, no cluster coherency guaranteed (no EX locks was taken), it hurts buffered reads on other nodes by reading stale data from cache. The new mount option introduce a chance to choose two different behaviors

Re: [Ocfs2-devel] Question: recovery map vs replay map

2010-10-11 Thread Goldwyn Rodrigues
On Fri, Oct 8, 2010 at 2:50 PM, Sunil Mushran sunil.mush...@oracle.com wrote: On 10/08/2010 12:03 PM, Goldwyn Rodrigues wrote: I was reading through the recovery code and got confused with recovery and replay maps. What is the function of recovery maps and replay maps? Is a replay map

[Ocfs2-devel] [PATCH] Initialize max_slots early

2010-10-11 Thread Goldwyn Rodrigues
Functions such as ocfs2_recovery_init() make use of osb-max_slots. Initialize osb-max_slots early so the functions may use the correct value. Signed-off-by: Goldwyn Rodrigues rgold...@suse.de --- diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index fa1be1b..3894c7e 100644 --- a/fs/ocfs2/super.c

Re: [Ocfs2-devel] [PATCH] Initialize max_slots early

2010-10-11 Thread Sunil Mushran
Signed-off-by: Sunil Mushransunil.mush...@oracle.com wow... this bug has been in mainline for 2 years. How come we did not run into this problem earlier. On 10/11/2010 10:57 AM, Goldwyn Rodrigues wrote: Functions such as ocfs2_recovery_init() make use of osb-max_slots. Initialize

Re: [Ocfs2-devel] [PATCH] ocfs2: validate bg_free_bits_count after update

2010-10-11 Thread Joel Becker
On Tue, Oct 05, 2010 at 03:53:06PM -0700, Srinivas Eeda wrote: This patch adds a safe check to ensure bg_free_bits_count doesn't exceed bg_bits in a group descriptor. This is to avoid on disk corruption that was seen recently. debugfs: group 52803072 Group Chain: 179 Parent Inode:

Re: [Ocfs2-devel] [PATCH] /fs/ocfs2/slot_map.c (2.6.35.6): Uninitialized variable

2010-10-11 Thread Joel Becker
On Mon, Sep 27, 2010 at 01:28:37PM -0700, Poyo VL wrote: When I tried to compile I got the following warning: fs/ocfs2/slot_map.c: In function ‘ocfs2_init_slot_info’: fs/ocfs2/slot_map.c:360: warning: ‘bytes’ may be used uninitialized in this function fs/ocfs2/slot_map.c:360: note: ‘bytes’

Re: [Ocfs2-devel] [PATCH] Initialize max_slots early

2010-10-11 Thread Joel Becker
On Mon, Oct 11, 2010 at 12:57:09PM -0500, Goldwyn Rodrigues wrote: Functions such as ocfs2_recovery_init() make use of osb-max_slots. Initialize osb-max_slots early so the functions may use the correct value. Signed-off-by: Goldwyn Rodrigues rgold...@suse.de This patch is now in the

Re: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Add a mount option coherency=* to handle cluster coherency for O_DIRECT writes.

2010-10-11 Thread Joel Becker
On Mon, Oct 11, 2010 at 04:46:39PM +0800, Tristan Ye wrote: Currently, default behavior of O_DIRECT writes was allowing concurrent writing among nodes, no cluster coherency guaranteed (no EX locks was taken), it hurts buffered reads on other nodes by reading stale data from cache. The new

Re: [Ocfs2-devel] [PATCH 02/22] ocfs2: Add an incompat feature flag OCFS2_FEATURE_INCOMPAT_CLUSTERINFO

2010-10-11 Thread Joel Becker
On Sat, Oct 09, 2010 at 10:35:27AM -0700, Sunil Mushran wrote: http://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=summary So there is a new branch global-heartbeat-2 that has this change. I couldn't find that, but I put the branch globalheartbeat-2 into merge-window. ;-) Joel --

Re: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Add a mount option coherency=* to handle cluster coherency for O_DIRECT writes.

2010-10-11 Thread Tao Ma
Hi Joel, Joel Becker wrote: On Mon, Oct 11, 2010 at 04:46:39PM +0800, Tristan Ye wrote: Currently, default behavior of O_DIRECT writes was allowing concurrent writing among nodes, no cluster coherency guaranteed (no EX locks was taken), it hurts buffered reads on other nodes by reading

Re: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Add a mount option coherency=* to handle cluster coherency for O_DIRECT writes.

2010-10-11 Thread Tao Ma
Tao Ma wrote: Hi Joel, Joel Becker wrote: On Mon, Oct 11, 2010 at 04:46:39PM +0800, Tristan Ye wrote: Currently, default behavior of O_DIRECT writes was allowing concurrent writing among nodes, no cluster coherency guaranteed (no EX locks was taken), it hurts buffered reads on

Re: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Add a mount option coherency=* to handle cluster coherency for O_DIRECT writes.

2010-10-11 Thread Joel Becker
On Tue, Oct 12, 2010 at 06:01:11AM +0800, Tao Ma wrote: Joel Becker wrote: On Mon, Oct 11, 2010 at 04:46:39PM +0800, Tristan Ye wrote: Currently, default behavior of O_DIRECT writes was allowing concurrent writing among nodes, no cluster coherency guaranteed (no EX locks was taken), it hurts

[Ocfs2-devel] [PATCH 1/1] ocfs2: Avoid to evaluate xattr block flags again.

2010-10-11 Thread Jeff Liu
It was evaludated to indexed before, check it is ok i think. Signed-off-by: Jeff Liu jeff@oracle.com --- fs/ocfs2/xattr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index e97b348..1e51eb4 100644 --- a/fs/ocfs2/xattr.c +++

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: flush truncate log in case it contains too many clusters.

2010-10-11 Thread Tao Ma
Hi Mark, On 10/12/2010 08:23 AM, Mark Fasheh wrote: Hi Tao, On Sun, Sep 19, 2010 at 03:20:28PM +0800, Tao Ma wrote: When we test whether we need to flush truncate log in ocfs2_truncate_log_needs_flush, we only take care of whether the truncate log is full. But if the volume is small and