Re: [Ocfs2-devel] [PATCH] make ocfs2 do not log ENOENT error

2014-01-24 Thread Andrew Morton
On Fri, 24 Jan 2014 14:11:09 +0800 xiaowei...@oracle.com wrote: From: Xiaowei.Hu xiaowei...@oracle.com suppress log message like this: (open_delete,8328,0):ocfs2_unlink:951 ERROR: status = -2 Orabug:17445485 --- fs/ocfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Ocfs2-devel] stalled ocfs2 patches

2014-01-24 Thread Andrew Morton
Guys, I'm developing an increasingly large backlog of ocfs2 patches which I am unprepared to send upstream. Some I feel need review which is beyond my understanding and some were reviewed, with an unclear outcome. Can we please take another look at all of these and try to get this all cleared

[Ocfs2-devel] [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

2014-01-24 Thread akpm
From: Younger Liu younger.li...@gmail.com Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly If filesystem is readonly, there is no need to flush drive's caches or force any uncommitted transactions. Signed-off-by: Younger Liu younger.li...@gmail.com Cc: Joel Becker

[Ocfs2-devel] [patch 03/11] ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one

2014-01-24 Thread akpm
From: Tariq Saeed tariq.x.sa...@oracle.com Subject: ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one When o2net-accept-one() rejects an illegal connection, it terminates the loop picking up the remaining queued connections. This fix will continue

[Ocfs2-devel] [patch 08/11] ocfs2: should call ocfs2_journal_access_di() before ocfs2_delete_entry() in ocfs2_orphan_del()

2014-01-24 Thread akpm
From: Younger Liu younger@huawei.com Subject: ocfs2: should call ocfs2_journal_access_di() before ocfs2_delete_entry() in ocfs2_orphan_del() While deleting a file into orphan dir in ocfs2_orphan_del(), it calls ocfs2_delete_entry() before ocfs2_journal_access_di(). If ocfs2_delete_entry()

[Ocfs2-devel] [patch 04/11] ocfs2: fix a tiny race when running dirop_fileop_racer

2014-01-24 Thread akpm
From: Yiwen Jiang jiangyi...@huawei.com Subject: ocfs2: fix a tiny race when running dirop_fileop_racer When running dirop_fileop_racer we found a dead lock case. 2 nodes, say Node A and Node B, mount the same ocfs2 volume. Create /race/16/1 in the filesystem, and let the inode number of dir 16

[Ocfs2-devel] [patch 10/11] ocfs2: fix issue that ocfs2_setattr() does not deal with new_i_size==i_size

2014-01-24 Thread akpm
From: Younger Liu younger@huawei.com Subject: ocfs2: fix issue that ocfs2_setattr() does not deal with new_i_size==i_size The issue scenario is as following: - Create a small file and fallocate a large disk space for a file with FALLOC_FL_KEEP_SIZE option. - ftruncate the file back to

[Ocfs2-devel] [patch 07/11] ocfs2: check existence of old dentry in ocfs2_link()

2014-01-24 Thread akpm
From: Xue jiufei xuejiu...@huawei.com Subject: ocfs2: check existence of old dentry in ocfs2_link() System call linkat first calls user_path_at(), check the existence of old dentry, and then calls vfs_link()-ocfs2_link() to do the actual work. There may exist a race when Node A create a hard

[Ocfs2-devel] [patch 11/11] ocfs2: update inode size after zeroing the hole

2014-01-24 Thread akpm
From: Junxiao Bi junxiao...@oracle.com Subject: ocfs2: update inode size after zeroing the hole fs-writeback will release the dirty pages without page lock whose offset are over inode size, the release happens at block_write_full_page_endio(). If not update, dirty pages in file holes may be

[Ocfs2-devel] [patch 06/11] ocfs2/o2net: o2net_listen_data_ready should do nothing if socket state is not TCP_LISTEN

2014-01-24 Thread akpm
From: Tariq Saeed tariq.x.sa...@oracle.com Subject: ocfs2/o2net: o2net_listen_data_ready should do nothing if socket state is not TCP_LISTEN Orabug: 17330860 When accepting an incomming connection o2net_accept_one clones a child data socket from the parent listening socket. It then proceeds to

[Ocfs2-devel] [patch 09/11] ocfs2: llseek requires ocfs2 inode lock for the file in SEEK_END

2014-01-24 Thread akpm
From: Jensen shencanq...@huawei.com Subject: ocfs2: llseek requires ocfs2 inode lock for the file in SEEK_END llseek requires ocfs2 inode lock for updating the file size in SEEK_END. because the file size maybe update on another node. This bug can be reproduce the following scenario: at first,

Re: [Ocfs2-devel] [patch 03/11] ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one

2014-01-24 Thread Mark Fasheh
On Fri, Jan 24, 2014 at 12:47:02PM -0800, a...@linux-foundation.org wrote: From: Tariq Saeed tariq.x.sa...@oracle.com Subject: ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one When o2net-accept-one() rejects an illegal connection, it terminates

Re: [Ocfs2-devel] [patch 05/11] ocfs2: code cleanup: remove unused functions

2014-01-24 Thread Mark Fasheh
On Fri, Jan 24, 2014 at 12:47:04PM -0800, a...@linux-foundation.org wrote: From: Goldwyn Rodrigues rgold...@suse.de Subject: ocfs2: code cleanup: remove unused functions These functions are either coded in individual files as static or not used at all. Remove them. NAK - some of this may

Re: [Ocfs2-devel] [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

2014-01-24 Thread Goldwyn Rodrigues
On 01/24/2014 02:46 PM, a...@linux-foundation.org wrote: From: Younger Liu younger.li...@gmail.com Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly If filesystem is readonly, there is no need to flush drive's caches or force any uncommitted transactions. An ocfs2 filesystem

Re: [Ocfs2-devel] [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

2014-01-24 Thread Mark Fasheh
On Fri, Jan 24, 2014 at 12:46:59PM -0800, a...@linux-foundation.org wrote: From: Younger Liu younger.li...@gmail.com Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly If filesystem is readonly, there is no need to flush drive's caches or force any uncommitted transactions.

Re: [Ocfs2-devel] [patch 03/11] ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one

2014-01-24 Thread Srinivas Eeda
On 01/24/2014 01:55 PM, Mark Fasheh wrote: On Fri, Jan 24, 2014 at 12:47:02PM -0800, a...@linux-foundation.org wrote: From: Tariq Saeed tariq.x.sa...@oracle.com Subject: ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one When o2net-accept-one()

Re: [Ocfs2-devel] [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

2014-01-24 Thread Mark Fasheh
On Fri, Jan 24, 2014 at 04:02:09PM -0600, Goldwyn Rodrigues wrote: On 01/24/2014 02:46 PM, a...@linux-foundation.org wrote: From: Younger Liu younger.li...@gmail.com Subject: ocfs2: fix ocfs2_sync_file() if filesystem is readonly If filesystem is readonly, there is no need to flush

Re: [Ocfs2-devel] [patch 03/11] ocfs2/o2net: incorrect to terminate accepting connections loop upon rejecting an invalid one

2014-01-24 Thread tariq saeed
Thanks for the comments. To understand the consequences of ignoring the err, we need to look at what is going on. We get a softIRQ when a connection packet (tcp SYN). It is critical to note that we may not get a softIRQ_for every connection s_ince connection packets can arrive back-to-back (as

Re: [Ocfs2-devel] [patch 01/11] ocfs2: fix ocfs2_sync_file() if filesystem is readonly

2014-01-24 Thread Andrew Morton
On Fri, 24 Jan 2014 14:21:19 -0800 Mark Fasheh mfas...@suse.de wrote: On Fri, Jan 24, 2014 at 04:02:09PM -0600, Goldwyn Rodrigues wrote: On 01/24/2014 02:46 PM, a...@linux-foundation.org wrote: From: Younger Liu younger.li...@gmail.com Subject: ocfs2: fix ocfs2_sync_file() if