Re: [Ocfs2-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces

2015-01-21 Thread Jan Kara
On Thu 22-01-15 08:38:26, Dave Chinner wrote: On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote: Hello, this is another iteration of patches to unify VFS and XFS quota interfaces so that XFS quotactls work for filesystems with VFS quotas and vice versa. This is useful

Re: [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags

2015-01-21 Thread Srinivas Eeda
Ok, understood. Thanks for explaining :) On 01/21/2015 05:07 PM, Joseph Qi wrote: Hi Srini, On 2015/1/22 1:55, Srinivas Eeda wrote: Hi Joesph, thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances

Re: [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags

2015-01-21 Thread Joseph Qi
Hi Srini, On 2015/1/22 1:55, Srinivas Eeda wrote: Hi Joesph, thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am

Re: [Ocfs2-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces

2015-01-21 Thread Dave Chinner
On Wed, Jan 21, 2015 at 11:23:20PM +0100, Jan Kara wrote: On Thu 22-01-15 08:38:26, Dave Chinner wrote: On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote: Hello, this is another iteration of patches to unify VFS and XFS quota interfaces so that XFS quotactls work for

Re: [Ocfs2-devel] [PATCH 0/9 v6] ocfs2: support append O_DIRECT write

2015-01-21 Thread Junxiao Bi
On 01/20/2015 05:00 PM, Joseph Qi wrote: Hi Junxiao, On 2015/1/20 16:26, Junxiao Bi wrote: Hi Joseph, Did this version make any performance improvement with v5? I tested v5, and it didn't improve performance with original buffer write + sync. No performance difference between these two

Re: [Ocfs2-devel] [PATCH 0/9 v6] ocfs2: support append O_DIRECT write

2015-01-21 Thread Junxiao Bi
On 01/22/2015 11:54 AM, Joseph Qi wrote: On 2015/1/22 10:10, Junxiao Bi wrote: On 01/20/2015 05:00 PM, Joseph Qi wrote: Hi Junxiao, On 2015/1/20 16:26, Junxiao Bi wrote: Hi Joseph, Did this version make any performance improvement with v5? I tested v5, and it didn't improve performance

Re: [Ocfs2-devel] [PATCH 0/9 v6] ocfs2: support append O_DIRECT write

2015-01-21 Thread Joseph Qi
On 2015/1/22 10:10, Junxiao Bi wrote: On 01/20/2015 05:00 PM, Joseph Qi wrote: Hi Junxiao, On 2015/1/20 16:26, Junxiao Bi wrote: Hi Joseph, Did this version make any performance improvement with v5? I tested v5, and it didn't improve performance with original buffer write + sync. No

[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment from ocfs2_calc_refcount_meta_credits()

2015-01-21 Thread Jan Kara
The assigned value is never used. Coverity-id: 1226847 CC: Mark Fasheh mfas...@suse.com CC: Joel Becker jl...@evilplan.org Signed-off-by: Jan Kara j...@suse.cz --- fs/ocfs2/refcounttree.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index