Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

2015-09-01 Thread Mark Fasheh
On Sat, Aug 29, 2015 at 10:38:09AM +0800, Joseph Qi wrote: > Hi Mark, > > On 2015/8/29 7:55, Mark Fasheh wrote: > > On Wed, Aug 26, 2015 at 03:11:48PM -0700, Andrew Morton wrote: > >> From: Xue jiufei > >> Subject: ocfs2: extend enough credits for freeing one truncate

Re: [Ocfs2-devel] [PATCH V2] ocfs2: fix a tiny case that inode can not removed.

2015-09-01 Thread Mark Fasheh
On Mon, Aug 31, 2015 at 03:36:15PM +0800, jiangyiwen wrote: > When running dirop_fileop_racer we found a case that inode > can not removed. > > 2 nodes, say Node A and Node B, mount the same ocfs2 volume. Create > two dirs /race/1/ and /race/2/ in the filesystem. > > Node A

[Ocfs2-devel] ocfs2: clean up redundant NULL checks before kfree

2015-09-01 Thread Joseph Qi
NULL check before kfree is redundant and so clean them up. Signed-off-by: Joseph Qi --- fs/ocfs2/alloc.c| 2 +- fs/ocfs2/suballoc.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 5997c00..73f6684

Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

2015-09-01 Thread Andrew Morton
On Tue, 1 Sep 2015 10:54:03 -0700 Mark Fasheh wrote: > > > Why is this particular change here? > > > --Mark > > > > > I think Joyce wants to get enough credits at first and then call > > ocfs2_replay_truncate_records. > > Oh ok I see. That's fine then, the patch otherwise

Re: [Ocfs2-devel] ocfs2 version issue

2015-09-01 Thread Junxiao Bi
Hi Goldwyn, On 09/01/2015 06:32 PM, Goldwyn Rodrigues wrote: > Hi Junxiao, > > On 08/31/2015 09:22 PM, Junxiao Bi wrote: >> Hi Goldwyn, >> >> Ocfs2 kernel version is removed from commit >> ff8fb335221e2c446b0d4cbea26be371fd2feb64 ("ocfs2: remove versioning >> information"), but Oracle CRS

Re: [Ocfs2-devel] [patch 14/28] ocfs2: take inode lock in ocfs2_iop_set/get_acl()

2015-09-01 Thread Tariq Saeed
On 08/31/2015 12:44 PM, Mark Fasheh wrote: > On Wed, Aug 26, 2015 at 03:11:57PM -0700, Andrew Morton wrote: >> From: Tariq Saeed >> Subject: ocfs2: take inode lock in ocfs2_iop_set/get_acl() >> >> Orabug: 20189959 >> >> This bug in mainline code is pointed out by Mark

Re: [Ocfs2-devel] ocfs2 version issue

2015-09-01 Thread Srinivas Eeda
Hi Goldwyn On 09/01/2015 03:32 AM, Goldwyn Rodrigues wrote: > Hi Junxiao, > > On 08/31/2015 09:22 PM, Junxiao Bi wrote: >> Hi Goldwyn, >> >> Ocfs2 kernel version is removed from commit >> ff8fb335221e2c446b0d4cbea26be371fd2feb64 ("ocfs2: remove versioning >> information"), but Oracle CRS depends

Re: [Ocfs2-devel] [patch 09/28] ocfs2: extend transaction for ocfs2_remove_rightmost_path() and ocfs2_update_edge_lengths() before to avoid inconsistency between inode and et

2015-09-01 Thread Joseph Qi
Hi Mark, Since Joyce is on holiday, I'll try to answer your doubt. On 2015/9/1 5:31, Mark Fasheh wrote: > On Wed, Aug 26, 2015 at 03:11:43PM -0700, Andrew Morton wrote: >> From: Xue jiufei >> Subject: ocfs2: extend transaction for ocfs2_remove_rightmost_path() and >>

Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

2015-09-01 Thread Mark Fasheh
On Tue, Sep 01, 2015 at 03:12:07PM -0700, Andrew Morton wrote: > On Tue, 1 Sep 2015 10:54:03 -0700 Mark Fasheh wrote: > > > > > Why is this particular change here? > > > > --Mark > > > > > > > I think Joyce wants to get enough credits at first and then call > > >

Re: [Ocfs2-devel] ocfs2: clean up redundant NULL checks before kfree

2015-09-01 Thread Mark Fasheh
On Tue, Sep 01, 2015 at 02:54:08PM +0800, Joseph Qi wrote: > NULL check before kfree is redundant and so clean them up. > > Signed-off-by: Joseph Qi Thanks, Reviewed-by: Mark Fasheh --Mark -- Mark Fasheh

Re: [Ocfs2-devel] ocfs2 version issue

2015-09-01 Thread Goldwyn Rodrigues
Hi Junxiao, On 08/31/2015 09:22 PM, Junxiao Bi wrote: > Hi Goldwyn, > > Ocfs2 kernel version is removed from commit > ff8fb335221e2c446b0d4cbea26be371fd2feb64 ("ocfs2: remove versioning > information"), but Oracle CRS depends on this version, and this made > Oracle CRS can't be installed. So i