Re: [Ocfs2-devel] [PATCH v2 26/28] ext4: cleanup transaction restarts during inode deletion

On Jun 14, 2017, at 8:17 AM, Tahsin Erdogan wrote: > > During inode deletion, journal credits that will be needed are hard to > determine, that is why we have journal extend/restart calls in several > places. Whenever a transaction is restarted, filesystem must be in a >

Re: [Ocfs2-devel] [PATCH 03/12] xfs: Set allowed quota types

On Oct 7, 2014, at 1:29 PM, Jan Kara j...@suse.cz wrote: On Tue 07-10-14 07:30:28, Dave Chinner wrote: On Wed, Oct 01, 2014 at 09:31:25PM +0200, Jan Kara wrote: We support user, group, and project quotas. Tell VFS about it. CC: x...@oss.sgi.com CC: Dave Chinner da...@fromorbit.com

Re: [Ocfs2-devel] [PATCH 04/12] fs: Generic infrastructure for optional inode fields

On Oct 1, 2014, at 1:31 PM, Jan Kara j...@suse.cz wrote: There are parts of struct inode which are used only by a few filesystems (e.g. i_dquot pointers, i_mapping-private_list, ...). Thus all the other filesystems are just wasting memory with these fields. On the other hand it isn't simple to

Re: [Ocfs2-devel] [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

On Jul 24, 2014, at 1:22 PM, David Sterba dste...@suse.cz wrote: On Thu, Jul 17, 2014 at 12:07:57AM -0600, Andreas Dilger wrote: any progress on this patch series? I'm sorry I got distracted at the end of year and did not finish the series. I never saw an updated version of this patch

Re: [Ocfs2-devel] [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

. It should be fine to use: #define FIEMAP_EXTENT_PHYS_LENGTH 0x0010 since this flag was never used. Cheers, Andreas On Dec 12, 2013, at 5:02 PM, Andreas Dilger adil...@dilger.ca wrote: On Dec 12, 2013, at 4:24 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Dec 12, 2013 at 04:25

Re: [Ocfs2-devel] [PATCH 0/4 v3] fiemap: introduce EXTENT_DATA_COMPRESSED flag

series looks good to me (one minor nit if it needs to be resubmitted for some reason). You can add my: Reviewed-by: Andreas Dilger adil...@dilger.ca V3: Based on feedback from Andreas, implement #1 from V2, current users of fiemap_fill_next_extent (fs/, ext4, gfs2, ocfs2, nilfs2, xfs) updated

Re: [Ocfs2-devel] [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

On Dec 12, 2013, at 4:24 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Dec 12, 2013 at 04:25:59PM +0100, David Sterba wrote: This flag was not accepted when fiemap was proposed [2] due to lack of in-kernel users. Btrfs has compression for a long time and we'd like to see that an extent

Re: [Ocfs2-devel] [PATCH 00/19 v5] Fix filesystem freezing deadlocks

On 2012-04-16, at 5:43 PM, Dave Chinner wrote: On Mon, Apr 16, 2012 at 03:02:50PM -0700, Andreas Dilger wrote: On 2012-04-16, at 9:13 AM, Jan Kara wrote: Another potential contention point might be patch 19. In that patch we make freeze_super() refuse to freeze the filesystem when

Re: [Ocfs2-devel] [PATCH 00/19 v5] Fix filesystem freezing deadlocks

On 2012-04-16, at 9:13 AM, Jan Kara wrote: Another potential contention point might be patch 19. In that patch we make freeze_super() refuse to freeze the filesystem when there are open but unlinked files which may be impractical in some cases. The main reason for this is the problem with

Re: [Ocfs2-devel] [PATCH 1/6] fs: add hole punching to fallocate

On 2010-11-16, at 20:11, Dave Chinner wrote: On Tue, Nov 16, 2010 at 06:22:47PM -0600, Andreas Dilger wrote: IMHO, it makes more sense for consistency and get what users expect that these be treated as flags. Some users will want KEEP_SIZE, but in other cases it may make sense that a hole

Re: [Ocfs2-devel] [PATCH 1/6] fs: add hole punching to fallocate

On 2010-11-16, at 20:34, Josef Bacik wrote: FWIW I agree with Dave, the only question at this point is do we force users to specify KEEP_SIZE with PUNCH_HOLE? On one hand it makes the interface a bit more consistent, on the other hand it makes the documentation a little weird We have

Re: [Ocfs2-devel] [PATCH 1/6] fs: add hole punching to fallocate

On 2010-11-16, at 07:14, Jan Kara wrote: Yeah I went back and forth on this. KEEP_SIZE won't change the behavior of PUNCH_HOLE since PUNCH_HOLE implicitly means keep the size. I figured since its mode and not flags it would be ok to make either way accepted, but if you prefer PUNCH_HOLE

Re: [Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview

)? Disallowing cleancache on a filesystem that uses 64-bit (or larger) inodes on a 32-bit system reduces its usefulness. Cheers, Andreas -- Andreas Dilger Lustre Technical Lead Oracle Corporation Canada Inc. ___ Ocfs2-devel mailing list Ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check

On 2010-08-12, at 11:42, Joel Becker wrote: +/** + * generic_check_addressable - Check addressability of file system + * @blocksize_bits: log of file system block size + * @num_blocks: number of blocks in file system + * + * Determine whether a file system with @num_blocks blocks

Re: [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check

On 2010-08-12, at 14:15, Joel Becker wrote: On Thu, Aug 12, 2010 at 12:45:41PM -0600, Andreas Dilger wrote: On 2010-08-12, at 11:42, Joel Becker wrote: +int generic_check_addressable(unsigned blocksize_bits, u64 num_blocks) +{ + u64 last_fs_block = num_blocks - 1; + + BUG_ON

Re: [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check

You can add my: Acked-by: Andreas Dilger adil...@dilger.ca On 2010-08-12, at 16:29, Joel Becker wrote: On Thu, Aug 12, 2010 at 03:32:27PM -0600, Andreas Dilger wrote: If I change the BUG_ON()s to -EINVAL, does that work? Or do you have some way you'd like to allow non-pagecache

Re: [Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge ( 16 TiB) volumes to mount

On 2010-07-11, at 11:04, Patrick J. LoPresti wrote: +/* Check to make sure entire volume is addressable on this system. + Requires osb_clusters_at_boot to be valid and for the journal to + have been initialized by ocfs2_journal_init(). */ +static int ocfs2_check_addressable(struct

Re: [Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge ( 16 TiB) volumes to mount

On 2010-07-12, at 19:08, Patrick J. LoPresti wrote: On Mon, Jul 12, 2010 at 5:21 PM, Andreas Dilger adil...@dilger.ca wrote: On 2010-07-11, at 11:04, Patrick J. LoPresti wrote: + /* Absolute addressability check (borrowed from ext4/super.c) */ + if ((max_block + (sector_t

Re: [Ocfs2-devel] [PATCH V2 0/7] Cleancache (was Transcendent Memory): overview

in btrfs and/or a revived compressed ext4. That would mean that the on-disk compression algorithm needs to match the in-memory algorithm, which implies that the in-memory compression algorithm should be selectable on a per-mapping basis. Cheers, Andreas -- Andreas Dilger Lustre Technical Lead Oracle

Re: [Ocfs2-devel] Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook

the minimal changes being done to ext3/ext4, I don't have any objection to this. Being able to hook ext4 into SSDs for hierarchical caching is something that will become increasingly important for huge ext4 filesystems. Acked-by: Andreas Dilger adil...@sun.com Diffstat: super.c

Re: [Ocfs2-devel] Add FIEMAP_EXTENT_SHARED flag

. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/3] fs: Document the reflink(2) system call.

, not an existing semantic. Though cp -p doesn't keep the owner/group of the original file if you are not root. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. ___ Ocfs2-devel mailing list Ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/3] fs: Document the reflink(2) system call.

On May 05, 2009 09:56 -0700, Joel Becker wrote: On Tue, May 05, 2009 at 02:09:36AM -0600, Andreas Dilger wrote: If the reflink caller is always charged for the full space used (as if it were a real copy) by virtue of the user doing the reflink() owning the new inode. Doing anything else

Re: [Ocfs2-devel] copyfile semantics.

, or implementing a reflink or whatever). Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] [RFC] jbd2: Add buffer triggers

-head.h header is shared between jbd.h and jbd2.h, so it seems a bit strange to have a jbd2_* struct here. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. ___ Ocfs2-devel mailing list Ocfs2-devel

[Ocfs2-devel] Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

On Oct 29, 2007 16:13 -0600, Andreas Dilger wrote: On Oct 29, 2007 13:57 -0700, Mark Fasheh wrote: I'm a little bit confused by fe_offset. Is it a physical offset, or a logical offset? The reason I ask is that your description above says FIEMAP ioctl will return the logical to physical

[Ocfs2-devel] Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

, Andreas Dilger wrote: The FIEMAP ioctl (FIle Extent MAP) is similar to the existing FIBMAP ioctl block device ioctl used for mapping an individual logical block address in a file to a physical block address in the block device. The FIEMAP ioctl will return the logical to physical mapping