Acked-by: Joel Becker <jl...@evilplan.org>
On Fri, Feb 26, 2016 at 01:33:51PM +0100, Christoph Hellwig wrote:
> Replace the current NULL-terminated array of default groups with a linked
> list. This gets rid of lots of nasty code to size and/or dynamically
> allocate the array.
&
On Tue, Jan 05, 2016 at 09:46:49AM +0800, Junxiao Bi wrote:
> Hi Mark,
>
> We may fix this issue in another way, without recursive locking and
> without refactoring. We can check before asking for the second locking,
> if lock is already hold, then skip the second locking, do you agree
> fixing
Srini has summed it up, mostly. We shouldn't be hitting these
suboptimal chains of gds unless the localalloc is empty. Hopefully
that's not terribly frequent, but it can happen.
Your solution does increase the complexity of the commit. Pushing a
newly-available gd back on to the available list
On Tue, Oct 21, 2014 at 04:38:33PM +0200, Jan Kara wrote:
CC: Mark Fasheh mfas...@suse.com
CC: Joel Becker jl...@evilplan.org
CC: ocfs2-devel@oss.oracle.com
Signed-off-by: Jan Kara j...@suse.cz
---
fs/ocfs2/inode.h | 4
fs/ocfs2/super.c | 10 ++
2 files changed, 14
alex.c...@huawei.com
Reviewed-by: Joseph Qi joseph...@huawei.com
Good catch. Can you tell me what testing or workload found this issue?
Just for future reference.
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/buffer_head_io.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs
this
to be noticed, but still:
Acked-by: Joel Becker jl...@evilplan.org
.
Could Mark Joel review the two patches? Thanks.
--
Life's Little Instruction Book #139
Never deprive someone of hope; it might be all they have.
http://www.jlbec.org
On Thu, Jan 09, 2014 at 07:35:05AM -0600, Goldwyn Rodrigues wrote:
On 01/09/2014 04:23 AM, Joel Becker wrote:
Unlink can happen from anywhere, but only the last closing node can
actually remove the file. MAYBE_ORPHANED tells the node to try for
removal at close time. It is absolutely
On Thu, Jan 09, 2014 at 11:27:15AM -0600, Goldwyn Rodrigues wrote:
Yes, I did not consider that.
How about using open locks ro_holders count to identify this? That may
just work. Thanks!
One problem I see in using open lock for this is it could be late.
Consider the scenario where node A
On Fri, Jan 10, 2014 at 05:19:13PM -0800, Srinivas Eeda wrote:
From: Srinivas Eeda seeda@srini.(none)
A tiny race between BAST and unlock message causes the NULL dereference.
A node sends an unlock request to master and receives a response. Before
processing the response it receives a BAST
Unlink can happen from anywhere, but only the last closing node can
actually remove the file. MAYBE_ORPHANED tells the node to try for
removal at close time. It is absolutely necessary.
Joel
On Wed, Jan 08, 2014 at 09:30:49PM -0800, Srinivas Eeda wrote:
On 01/08/2014 07:12 PM, Goldwyn
to debug issues.
Changes since v1:
* Added MODULE_DESCRIPTION
Signed-off-by: Goldwyn Rodrigues rgold...@suse.com
Acked-by: Sunil Mushran sunil.mush...@gmail.com
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/Makefile | 1 -
fs/ocfs2/cluster/Makefile | 2 +-
fs
-by: Joel Becker jl...@evilplan.org
---
fs/jbd2/transaction.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 7aa9a32..b0b74e5 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -1290,7 +1290,10
On Mon, Dec 02, 2013 at 04:06:35PM -0800, Mark Fasheh wrote:
On Tue, Nov 26, 2013 at 05:37:27PM -0600, Goldwyn Rodrigues wrote:
The versioning information is confusing for end-users. The numbers
are stuck at 1.5.0 while the tools version have moved to 1.8.2.
I suggest removing the
...@suse.cz
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/aops.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index f37d3c0e2053..04df2ae18592 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -592,26
On Fri, Oct 18, 2013 at 01:04:55PM -0700, Andrew Morton wrote:
On Fri, 18 Oct 2013 09:44:54 -0500 Goldwyn Rodrigues rgold...@suse.de wrote:
This is an effort of removing ocfs2_controld.pcmk and getting ocfs2 DLM
handling up to the times with respect to DLM (=4.0.1) and corosync
(2.3.x).
On Sat, Sep 28, 2013 at 09:39:42AM -0500, Goldwyn Rodrigues wrote:
On 09/27/2013 02:02 PM, Joel Becker wrote:
On Fri, Sep 27, 2013 at 12:07:53PM -0500, Goldwyn Rodrigues wrote:
- /*
-* running_proto must have been set before we allowed any mounts
-* to proceed
On Fri, Oct 04, 2013 at 10:01:34AM -0500, Goldwyn Rodrigues wrote:
On 10/03/2013 06:25 AM, Lars Marowsky-Bree wrote:
On 2013-10-03T00:48:55, Goldwyn Rodrigues rgold...@suse.de wrote:
And, perhaps, a compile-time option to disable this earlier, so that
users can choose the stacks they want
On Mon, Oct 07, 2013 at 07:17:46PM -0500, Goldwyn Rodrigues wrote:
On 10/07/2013 07:00 PM, Joel Becker wrote:
On Sat, Sep 28, 2013 at 09:39:42AM -0500, Goldwyn Rodrigues wrote:
On 09/27/2013 02:02 PM, Joel Becker wrote:
On Fri, Sep 27, 2013 at 12:07:53PM -0500, Goldwyn Rodrigues wrote
On Fri, Sep 27, 2013 at 12:06:47PM -0500, Goldwyn Rodrigues wrote:
Try locking with the new DLM semantics with the dlm operations.
If operation fails with EOPNOTSUPP, try the old semantics.
This would ensure that filesystems are mounted for those who
are upgrading the kernel but not the tools.
On Fri, Sep 27, 2013 at 12:07:53PM -0500, Goldwyn Rodrigues wrote:
This is done primarily for backward compatibility. I hope we do
away with this sooner than later ;)
---
fs/ocfs2/stack_user.c | 70
---
1 file changed, 44 insertions(+), 26
On Fri, Sep 27, 2013 at 12:08:25PM -0500, Goldwyn Rodrigues wrote:
This is required because we need the live_connection structure ready
when we perform the dlm_new_lockspace().
Why? You just allocate it and pass it in. Is it for a future change?
Mention what that change is.
Joel
---
I thought we already prevented this. Why a new mechanism?
Joel
On Fri, Sep 27, 2013 at 12:10:11PM -0500, Goldwyn Rodrigues wrote:
---
fs/ocfs2/dlmglue.c | 3 ++-
fs/ocfs2/stackglue.c | 18 ++
fs/ocfs2/stackglue.h | 3 +++
3 files changed, 23 insertions(+), 1
Acked-by: Joel Becker jl...@evilplan.org
On Sun, Sep 22, 2013 at 06:51:55PM +0800, Younger Liu wrote:
If ocfs2_journal_access_di fails, group-bg_next_group should rollback.
Otherwise, there would be a inconsistency between group_bh and main_bm_bh.
Signed-off-by: Younger Liu younger
Acked-by: Joel Becker jl...@evilplan.org
On Sun, Sep 22, 2013 at 06:52:04PM +0800, Younger Liu wrote:
If group_bh is not initialized, there is no need to release.
This problem does not cause anything wrong, but the patch
would make the code more logical.
Signed-off-by: Younger Liu younger
On Wed, Jul 03, 2013 at 04:22:02PM -0400, Waiman Long wrote:
Because of the changes made in dcache.h header file, files that
use the d_lock field of the dentry structure need to be changed
accordingly. All the d_lock's spin_lock() and spin_unlock() calls
are replaced by the corresponding
.
Signed-off-by: Yiwen Jiang jiangyi...@huawei.com
Signed-off-by: joyce xuejiu...@huawei.com
Good catch.
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/cluster/heartbeat.c |9 +
1 file changed, 9 insertions(+)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2
On Tue, Jul 02, 2013 at 11:12:33AM +0800, Junxiao Bi wrote:
Hi Joel,
On 07/02/2013 09:50 AM, Joel Becker wrote:
On Tue, Jul 02, 2013 at 09:08:36AM +0800, Junxiao Bi wrote:
Hi Joel,
On 07/02/2013 06:57 AM, Joel Becker wrote:
On Fri, Jun 28, 2013 at 10:56:23AM +0800, Junxiao Bi wrote
On Tue, Jul 02, 2013 at 12:17:53PM -0700, Andrew Morton wrote:
On Tue, 2 Jul 2013 08:40:42 -0700 Joel Becker jl...@evilplan.org wrote:
On Tue, Jul 02, 2013 at 11:12:33AM +0800, Junxiao Bi wrote:
4244 mutex_lock_nested(new_inode-i_mutex, I_MUTEX_CHILD);
4245 ret
On Thu, Jun 20, 2013 at 05:01:25PM +0800, Jeff Liu wrote:
On 06/20/2013 02:17 PM, Junxiao Bi wrote:
free space checking will be done in ocfs2_xattr_ibody_init().
So remove here.
Signed-off-by: Junxiao Bi junxiao...@oracle.com
Reviewed-by: Jie Liu jeff@oracle.com
Acked-by: Joel
On Fri, Jun 28, 2013 at 10:56:23AM +0800, Junxiao Bi wrote:
Inlined xattr shared free space of inode block with inlined data
or data extent record, so the size of the later two should be
adjusted when inlined xattr is enabled. See ocfs2_xattr_ibody_init().
But this isn't done well when
On Sat, Jun 29, 2013 at 12:01:19PM +0800, Jeff Liu wrote:
From: Jie Liu jeff@oracle.com
Adjust switch..case syntax at o2net_state_change to meet
the kernel coding standard.
s/printk/pr_info/.
Signed-off-by: Jie Liu jeff@oracle.com
Switching to pr_info() hasn't been
On Sat, Jun 29, 2013 at 12:01:14PM +0800, Jeff Liu wrote:
From: Jie Liu jeff@oracle.com
Fix a comments typo at o2quo_hb_still_up()
Signed-off-by: Jie Liu jeff@oracle.com
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/cluster/quorum.c |2 +-
1 file changed, 1
On Mon, Jul 01, 2013 at 04:22:28PM -0700, Andrew Morton wrote:
On Mon, 1 Jul 2013 16:04:21 -0700 Joel Becker jl...@evilplan.org wrote:
On Sat, Jun 29, 2013 at 12:01:19PM +0800, Jeff Liu wrote:
From: Jie Liu jeff@oracle.com
Adjust switch..case syntax at o2net_state_change to meet
On Sun, Jun 23, 2013 at 01:36:28PM -0400, Theodore Ts'o wrote:
On Fri, Jun 21, 2013 at 09:29:31PM +0800, Younger Liu wrote:
This bug was triggered by the following scenario:
In ocfs2 file system, allocate a very large disk space for a small file
with ocfs2_fallocate(), while the journal
On Thu, Jun 20, 2013 at 04:23:59PM +0800, shencanquan wrote:
llseek requires ocfs2 inode lock for updating the file size in SEEK_END.
because the file size maybe update on another node.
if it not . after call llseek in SEEK_END. the position is old.
this bug can be reproduce the following
I can't really comment on the concept, but if security folks agree, the
ocfs2 part looks fine.
Reviewed-by: Joel Becker jl...@evilplan.org
On Sat, Jun 08, 2013 at 09:54:56PM +0900, Tetsuo Handa wrote:
From 96df8b4be7f8702913a0245b2312958e2eea6caf Mon Sep 17 00:00:00 2001
From: Tetsuo Handa
On Wed, Jun 05, 2013 at 04:53:34PM +0800, Xue jiufei wrote:
dlm_mig_lockres_handler goes to leave, when lockres with state
DLM_LOCK_RES_RECOVERING, not putting lockres taken in dlm_lookup_lockres.
Signed-off-by: joyce xuejiu...@huawei.com
Acked-by: Joel Becker jl...@evilplan.org
---
fs
Acked-by: Joel Becker jl...@evilplan.org
On Fri, Jun 07, 2013 at 08:09:09PM +0800, Jeff Liu wrote:
On 06/07/2013 07:49 PM, Goldwyn Rodrigues wrote:
Code cleanup: needs_checkpoint is only assigned but never used to check.
Delete the variable.
Signed-off-by: Goldwyn Rodrigues rgold
/available_events |grep ocfs2_set_inode_attr
ocfs2:ocfs2_set_inode_attr
Signed-off-by: Jie Liu jeff@oracle.com
Cc: Joel Becker jl...@evilplan.org
Cc: Mark Fasheh mfas...@suse.com
---
fs/ocfs2/ioctl.c |3 +++
fs/ocfs2/ocfs2_trace.h |6 ++
2 files changed, 9 insertions
On Mon, Mar 11, 2013 at 05:27:05PM +0800, Jeff Liu wrote:
Hi Joel,
On 03/11/2013 05:10 PM, Joel Becker wrote:
Hey Jeff,
What made you want this trace point? Did you have a particular
scenario that required it?
Or were you just thinking it would be nice
to have?
Yes, and I
On Sat, Mar 09, 2013 at 01:49:37PM +0200, Alexandru Gheorghiu wrote:
Replaced calls to kmalloc followd by memcpy with a single call to kmemdup.
This patch was found using coccicheck.
Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com
Acked-by: Joel Becker jl...@evilplan.org
in ocfs2_begin_truncate_log_recovery()
Cc: Joel Becker jl...@evilplan.org
Cc: Mark Fasheh mfas...@suse.com
Cc: Tim Gardner tim.gard...@canonical.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
I think this is actually OK without the change. The caller uses
*tl_copy, but it is always clear when
-by: Tim Gardner tim.gard...@canonical.com
Cc: Mark Fasheh mfas...@suse.com
Cc: Joel Becker jl...@evilplan.org
Signed-off-by: Andrew Morton a...@linux-foundation.org
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/alloc.c |5 ++---
fs/ocfs2/cluster/heartbeat.c |6
On Thu, Feb 07, 2013 at 03:52:19PM +0100, Jan Kara wrote:
ocfs2_file_splice_write() was missed when adding freeze protection to all
write paths. Fix that.
CC: Joel Becker jl...@evilplan.org
CC: ocfs2-devel@oss.oracle.com
Signed-off-by: Jan Kara j...@suse.cz
Acked-by: Joel Becker jl
...@kernel.org
Cc: Mark Fasheh mfas...@suse.com
Cc: Joel Becker jl...@evilplan.org
Signed-off-by: Andrew Morton a...@linux-foundation.org
Acked-by: Joel Becker jl...@evilplan.org
---
fs/ocfs2/cluster/tcp.c | 32 +---
1 file changed, 13 insertions(+), 19
On Wed, Jan 30, 2013 at 02:45:35PM +, Al Viro wrote:
On Wed, Jan 30, 2013 at 12:27:57AM +0100, Jan Kara wrote:
Hi,
since nobody seem to have picked up any of the patches (at least
nobody told me so), I've added acks I received to the patches and I'm
sending them to Al for
Acked-by: Joel Becker jl...@evilplan.org
On Tue, Jan 29, 2013 at 10:23:32AM -0600, Dave Kleikamp wrote:
From: Zach Brown z...@zabbo.net
ocfs2's .aio_read and .aio_write methods are changed to take
iov_iter and pass it to generic functions. Wrappers are made to pack
the iovecs into iters
On Sat, Dec 22, 2012 at 12:26:35AM +0100, Jan Kara wrote:
Ocfs2 doesn't do data journalling. Thus its -invalidatepage and -releasepage
functions never get called on buffers that have journal heads attached. So
just use standard variants of functions from buffer.c.
Indeed, we do not. I suppose
On Tue, Oct 23, 2012 at 09:02:38AM -0400, Christoph Hellwig wrote:
On Tue, Oct 23, 2012 at 01:54:48AM -0700, Joel Becker wrote:
On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
Removed vmtruncate
Signed-off-by: Marco Stornelli marco.storne...@gmail.com
Acked
On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote:
2012/10/23 Joel Becker jl...@evilplan.org:
On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote:
2012/10/23 Joel Becker jl...@evilplan.org:
On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote
Help me understand the issue. Who broke this? Do I need to push this
patch, or is someone else?
Thanks,
Joel
On Fri, Oct 19, 2012 at 10:56:42AM -0700, Dan Magenheimer wrote:
FYI, it is likely that ocfs2 will not work on 3.7-rcN until
the following one-line patch is merged, as the code in
On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
Removed vmtruncate
Signed-off-by: Marco Stornelli marco.storne...@gmail.com
Acked-by: Joel Becker jl...@evilplan.org
Do you want me to pull this, or are you going to send it with your set?
Joel
---
fs/ocfs2/file.c | 19
On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote:
2012/10/23 Joel Becker jl...@evilplan.org:
On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
Removed vmtruncate
Signed-off-by: Marco Stornelli marco.storne...@gmail.com
Acked-by: Joel Becker jl
On Thu, Jun 02, 2011 at 12:43:40PM +0800, Tiger Yang wrote:
On 06/01/2011 09:43 AM, Joel Becker wrote:
On Sat, May 28, 2011 at 12:34:52AM +0800, Tiger Yang wrote:
We have already mlog all error and positive status is not error.
Positive status is turned into -EIO. There are actually
On Wed, Jul 11, 2012 at 02:49:56PM +0800, Junxiao Bi wrote:
Signed-off-by: Junxiao Bi junxiao...@oracle.com
This patch is now part of the fixes branch of ocfs2.git.
Joel
---
fs/ocfs2/dlm/dlmmaster.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On Thu, Jul 26, 2012 at 04:05:05PM +0300, Dan Carpenter wrote:
My static checker complains that this is called with a spin_lock held
in dlm_master_requery_handler() from dlmrecovery.c. Probably the reason
we have not received any bug reports about this is that recovery is not
a common
On Tue, Aug 14, 2012 at 10:03:17AM +0800, Xue jiufei wrote:
A parallel umount on 4 nodes triggered a bug in
dlm_process_recovery_date(). Here’s the situation:
Receiving MIG_LOCKRES message, A node processes the locks in migratable
lockres. It copys lvb from migratable lockres when
On Fri, Aug 03, 2012 at 05:36:17PM +0100, sunil.mush...@gmail.com wrote:
From: Sunil Mushran smush...@yahoo.com
Commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 was missing a var init.
Reported-and-Tested-by: Vincent Etienne vetie...@aprogsys.com
Signed-off-by: Sunil Mushran
On Tue, Aug 14, 2012 at 10:06:37AM +0800, Xue jiufei wrote:
We trigger a bug in __dlm_lockres_reserve_ast() when we parallel umount 4
nodes. The situation is as follows:
1) Node A migrate all lockres it owned(eg. lockres A) to other nodes say
node B when it umounts.
2) Receiving
need to be removed as they look to be in this list.
On Fri, Jul 6, 2012 at 12:44 AM, Joel Becker jl...@evilplan.org wrote:
Linus et al,
Here are the all of the ocfs2 fixes that have been stewing in my
tree. Please pull.
Joel
The following changes since commit
On Tue, Aug 14, 2012 at 11:37:11PM -0700, Joel Becker wrote:
On Thu, Jun 02, 2011 at 12:43:40PM +0800, Tiger Yang wrote:
On 06/01/2011 09:43 AM, Joel Becker wrote:
On Sat, May 28, 2011 at 12:34:52AM +0800, Tiger Yang wrote:
We have already mlog all error and positive status is not error
On Wed, Aug 15, 2012 at 10:29:18AM +0200, Marek Królikowski wrote:
Hey
I see You remove ocfs2_global_read_info errors from dmesg can You remove
other stupid errors too?
I got kernel 3.2.27 with enable quota on OCFS2 and i got many many errors
likes:
(local,19395,1):ocfs2_write_begin:1953
EDQUOT is a user-visible error, not a logic problem. Teach mlog_errno()
to ignore it like it ignores -ENOSPC, etc.
Signed-off-by: Joel Becker jl...@evilplan.org
Cc: Jan Kara j...@suse.cz
Reported-by: Marek Królikowski ad...@wset.edu.pl
---
fs/ocfs2/cluster/masklog.h |3 ++-
1 files changed
On Thu, Aug 02, 2012 at 08:59:10AM -0400, J. Bruce Fields wrote:
On Thu, Aug 02, 2012 at 12:57:44AM -0700, Joel Becker wrote:
On Tue, Jul 31, 2012 at 06:33:23PM -0400, J. Bruce Fields wrote:
From: J. Bruce Fields bfie...@redhat.com
XXX: I don't understand this code, but I also can't
On Tue, Jul 31, 2012 at 06:33:23PM -0400, J. Bruce Fields wrote:
From: J. Bruce Fields bfie...@redhat.com
XXX: I don't understand this code, but I also can't see how it can be
right as is: a dentry marked DCACHE_DISCONNECTED can in fact be a
fully-connected member of the dcache. Is
On Sat, Jul 28, 2012 at 12:18:30AM +0200, Vincent ETIENNE wrote:
Hello
Get this on first write made ( by deliver sending mail to inform of the
restart of services )
Home partition (the one receiving the mail) is based on ocfs2 created
from drbd block device in primary/primary mode
These
On Mon, Jul 30, 2012 at 09:45:14AM +0200, Vincent ETIENNE wrote:
HI,
Le 30/07/2012 08:30, Joel Becker a écrit :
On Sat, Jul 28, 2012 at 12:18:30AM +0200, Vincent ETIENNE wrote:
Hello
Get this on first write made ( by deliver sending mail to inform of the
restart of services
On Wed, Jul 11, 2012 at 02:49:56PM +0800, Junxiao Bi wrote:
Signed-off-by: Junxiao Bi junxiao...@oracle.com
---
fs/ocfs2/dlm/dlmmaster.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index 005261c..1fadc39
Linus et al,
Here are the all of the ocfs2 fixes that have been stewing in my
tree. Please pull.
Joel
The following changes since commit 9e85a6f9dc231f3ed3c1dc1b12217505d970142a:
Merge tag 'clk-fixes-for-linus' of
git://git.linaro.org/people/mturquette/linux (2012-07-03 18:06:49
On Wed, Jul 04, 2012 at 03:51:57PM +0800, Junxiao Bi wrote:
On 07/04/2012 03:34 PM, Joel Becker wrote:
On Wed, Jun 27, 2012 at 05:09:55PM +0800, Junxiao Bi wrote:
The unaligned io flag is set in the kiocb when an unaligned
dio is issued, it should be cleared even when the dio fails
On Fri, Jun 29, 2012 at 06:49:43PM +0800, Junxiao Bi wrote:
On 06/29/2012 05:22 PM, Joel Becker wrote:
On Thu, Jun 28, 2012 at 03:39:56PM -0700, Andrew Morton wrote:
On Wed, 27 Jun 2012 17:09:54 +0800
Junxiao Bi junxiao...@oracle.com wrote:
Ocfs2 uses kiocb.*private as a flag
I have Jan's patch, which keeps mlog_errno near the errors. this is
good for locating the problem.
Joel
On Mon, Jun 25, 2012 at 04:03:24PM +0800, Tiger Yang wrote:
out_err already logged all the negative status, so remove mlog_errno
before goto there. If quota_read succeed, positive (non
On Mon, Jan 30, 2012 at 09:51:22PM -0800, Srinivas Eeda wrote:
When ocfs2dc thread holds dc_task_lock spinlock and receives soft IRQ it
deadlock itself trying to get same spinlock in ocfs2_wake_downconvert_thread.
Below is the stack snippet.
The patch disables interrupts when acquiring
On Thu, Feb 09, 2012 at 02:42:22PM +0800, Jeff Liu wrote:
Hello,
Since ENXIO only means offset beyond EOF for SEEK_DATA/SEEK_HOLE,
Hence we should return the internal error unchanged if ocfs2_inode_lock() or
ocfs2_get_clusters_nocache() call failed rather than ENXIO.
Otherwise, it will
On Fri, Feb 10, 2012 at 10:50:07AM +0100, Jan Kara wrote:
'status' variable in ocfs2_global_read_info() is always != 0 when leaving the
function because it happens to contain number of read bytes. Thus we always
log
error message although everything is OK. Since all error cases properly call
On Wed, Jun 27, 2012 at 05:09:55PM +0800, Junxiao Bi wrote:
The unaligned io flag is set in the kiocb when an unaligned
dio is issued, it should be cleared even when the dio fails,
or it may affect the following io which are using the same
kiocb.
Signed-off-by: Junxiao Bi
On Mon, Dec 12, 2011 at 11:40:51PM +0100, roel wrote:
Fix misplaced parentheses
Signed-off-by: Roel Kluin roel.kl...@gmail.com
This patch is now (finally) part of the 'fixes' branch of ocfs2.git.
Joel
---
fs/ocfs2/dlmglue.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
will hang forever at ocfs2_aiodio_wait() in ocfs2_file_aio_write().
Signed-off-by: Junxiao Bi junxiao...@oracle.com
Cc: sta...@vger.kernel.org
Acked-by: Jeff Moyer jmo...@redhat.com
Acked-by: Joel Becker jl...@evilplan.org
---
include/linux/aio.h |1 +
1 file changed, 1
On Wed, Jun 20, 2012 at 04:18:23PM -0700, Mark Fasheh wrote:
This should've been upstream a while ago :/
Indeed. I've been fighting my kernel.org setup and life since December.
Sorry I dropped the ball on this one.
Joel
On Wed, Jun 20, 2012 at 11:34:44PM +0100, Luis Henriques wrote:
As
On Thu, Jun 21, 2012 at 03:46:32AM +, Guozhonghua wrote:
The first problem is as below:
One issue is the files copied to the device but it can't be list on node2,
using ls -al the mounted directory.
But using debug.ocfs2 on node2, it is ok to list the files copied. After
remount of the
-by: Junxiao Bi junxiao...@oracle.com
Cc: sta...@vger.kernel.org
Acked-by: Jeff Moyer jmo...@redhat.com
Acked-by: Joel Becker jl...@evilplan.org
---
include/linux/aio.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/aio.h b/include/linux/aio.h
index 2314ad8..b1a520e 100644
On Mon, May 07, 2012 at 04:21:27PM -0700, Srinivas Eeda wrote:
can you please review following 3 patches that implement discontiguous
localalloc bitmap support for ocfs2 file system. This feature helps
applications that significantly fragment the filesystem.
Hi Srini. Have you some
On Mon, May 07, 2012 at 04:21:28PM -0700, Srinivas Eeda wrote:
Current local alloc handles single contiguous free chunk of clusters. This
patch enhances local alloc to handle discontigous free chunks. It adds a new
ocfs2_local_alloc_rec structure which tracks single contiguous free chunk. An
On Mon, May 07, 2012 at 04:21:29PM -0700, Srinivas Eeda wrote:
This patch adds supporting functions and modifies localalloc code to implement
discontiguous localalloc bitmap.
Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com
---
fs/ocfs2/localalloc.c | 523
On Mon, May 07, 2012 at 04:21:28PM -0700, Srinivas Eeda wrote:
Current local alloc handles single contiguous free chunk of clusters. This
patch enhances local alloc to handle discontigous free chunks. It adds a new
ocfs2_local_alloc_rec structure which tracks single contiguous free chunk. An
On Mon, May 07, 2012 at 04:21:30PM -0700, Srinivas Eeda wrote:
Currently reservation code assumes a bitmap given to it is all one contigous
chunk. This patch enhances it to handle a discontigous chunks. It adds new
fields m_bitmap_ext_cnt and m_bitmap_ext_arr. m_bitmap_ext_arr tracks the
On Tue, Apr 17, 2012 at 11:32:46AM +0200, Jan Kara wrote:
On Mon 16-04-12 15:02:50, Andreas Dilger wrote:
On 2012-04-16, at 9:13 AM, Jan Kara wrote:
Another potential contention point might be patch 19. In that patch
we make freeze_super() refuse to freeze the filesystem when there
are
CC: Mark Fasheh mfas...@suse.com
CC: Joel Becker jl...@evilplan.org
CC: David S. Miller da...@davemloft.net
BugLink: https://bugs.launchpad.net/bugs/897421
Tested-by: Kamal Mostafa ka...@canonical.com
Tested-by: Peter M. Petrakis peter.petra...@canonical.com
Tested-by: Dann Frazier dann.fraz
On Mon, Apr 16, 2012 at 06:13:57PM +0200, Jan Kara wrote:
Protect ocfs2_page_mkwrite() and ocfs2_file_aio_write() using the new
freeze protection. We also protect several ioctl entry points which
were missing the protection.
CC: Mark Fasheh mfas...@suse.com
CC: Joel Becker jl
On Mon, Feb 13, 2012 at 04:50:47PM +0300, Dan Carpenter wrote:
If ret is NULL, then hs is also NULL, so there is no need to free
it. config_group_init_type_name() can't fail if the name (heartbeat
in this case) is less than CONFIGFS_ITEM_NAME_LEN (20) characters long
so we can just remove
Cao
Jan Kara
Joel Becker
MM
Andrea Arcangeli
Hugh Dickins
Mel Gorman
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Stephen,
Can you please point linux-next back at:
git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/configfs.git linux-next
git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/ocfs2.git linux-next
Thanks!
Joel
--
Life's Little Instruction Book #450
Don't be afraid to say,
On Sun, Nov 27, 2011 at 01:27:24PM +0800, Cong Wang wrote:
Signed-off-by: Cong Wang amw...@redhat.com
Acked-by: Joel Becker jl...@evilplan.org
I'm presuming you'll handle pushing this with the entire series.
Joel
---
fs/ocfs2/aops.c | 16
1 files changed, 8 insertions
()
ocfs2: Use filemap_write_and_wait() instead of write_inode_now()
Joel Becker (1):
Merge branch 'mw-3.1-jul25' of
git://oss.oracle.com/git/smushran/linux-2.6 into ocfs2-fixes
Julia Lawall (1):
fs/ocfs2/dlm/dlmlock.c: free kmem_cache_zalloc'd data using
kmem_cache_free
Mark Fasheh (2
On Fri, Dec 02, 2011 at 10:39:03AM +1100, Stephen Rothwell wrote:
Hi Joel,
On Thu, 1 Dec 2011 12:15:54 -0800 Joel Becker jl...@evilplan.org wrote:
Can you please point linux-next back at:
git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/configfs.git linux-next
That one never
.
But it should probably still be cleaned up.
regards,
dan carpenter
On Wed, Aug 11, 2010 at 05:03:56PM -0700, Joel Becker wrote:
On Sat, Aug 07, 2010 at 11:09:13AM +0200, Julia Lawall wrote:
From: Julia Lawallju...@diku.dk
list_for_each_entry uses its first argument to move from one
On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote:
On 2011-11-10 15:33:19, Jan Kara wrote:
On Thu 10-11-11 00:45:00, Tyler Hicks wrote:
This patch removes the negation from the conditional so that the i_mutex
lockdep class is properly set for directory inodes. Special classes
On Wed, Oct 12, 2011 at 03:22:15PM +0800, Wengang Wang wrote:
There are three cases found that in error cases, journal transactions are not
committed nor aborted. We should take care of these case by committing the
transactions. Otherwise, there would left a journal handle which will lead to
,
On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote:
ocfs2: Fix cleancache initialization call to correctly pass uuid
As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
the ocfs2 volume UUID is incorrectly passed to cleancache.
As a result, shared-ephemeral
On Wed, Oct 19, 2011 at 09:34:19AM +0800, xiaowei...@oracle.com wrote:
From: Xiaowei.Hu xiaowei...@oracle.com
With indexed_dir enabled, ocfs2 maintains a list of dirblocks having
space.
The credit calculation in ocfs2_link_credits() did not correctly account
for adding an entry that
1 - 100 of 1244 matches
Mail list logo
