Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery V2

2013-06-24 Thread Xue jiufei
Hi, xiaowei, On 2013/6/24 12:57, xiaowei.hu wrote: On 06/23/2013 07:12 PM, Jeff Liu wrote: On 06/18/2013 11:13 AM, Xue jiufei wrote: From: Xiaowei.Hu xiaowei.hu at oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery V2

2013-06-23 Thread xiaowei.hu
On 06/23/2013 07:12 PM, Jeff Liu wrote: On 06/18/2013 11:13 AM, Xue jiufei wrote: From: Xiaowei.Hu xiaowei.hu at oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before send out the locks packages, the recovery will fall

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-07-26 Thread Xiaowei
Hi Sunil, I considered your suggestion about this patch, it's possible to change the status in dlm hb down event, but what need to change are the dlm_reco_node_data structures in dlm-reco.node_data list. This list is initialized in dlm_remaster_locks when it begins the lock remaster and

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-30 Thread Sunil Mushran
On Tue, May 29, 2012 at 5:41 PM, Xiaowei xiaowei...@oracle.com wrote: On 05/30/2012 06:09 AM, Sunil Mushran wrote: I would suggest exploring adding this in dlm hb down event. Checking live map all over the place is hacky. We do it more than we should right now. Let's not add to the mess.

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-29 Thread Sunil Mushran
On Thu, May 24, 2012 at 10:53 PM, xiaowei...@oracle.com wrote: diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 01ebfd0..62659e8 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c @@ -555,6 +555,7 @@ static int dlm_remaster_locks(struct

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-29 Thread Xiaowei
On 05/30/2012 06:09 AM, Sunil Mushran wrote: On Thu, May 24, 2012 at 10:53 PM, xiaowei...@oracle.com mailto:xiaowei...@oracle.com wrote: diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 01ebfd0..62659e8 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-25 Thread srinivas eeda
comments inline On 5/24/2012 10:53 PM, xiaowei...@oracle.com wrote: From: Xiaowei.Huxiaowei...@oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before send out the locks packages, the recovery will fall into endless

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-25 Thread Xiaowei
Thanks Srini , This sounds good, I tried to use dlm_is_node_dead in this patch , but this function can't report another node is dead if this node already in recovery process. It was blocked to set the bit in domain_map, but the live_nodes_map could always reflect the really live nodes. I will

[Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery V2

2012-05-25 Thread xiaowei . hu
From: Xiaowei.Hu xiaowei...@oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before send out the locks packages, the recovery will fall into endless loop,waiting for the status changed to finalize NodeA

[Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-24 Thread xiaowei . hu
From: Xiaowei.Hu xiaowei...@oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before send out the locks packages, the recovery will fall into endless loop,waiting for the status changed to finalize NodeA