Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-02 Thread piaojun
Hi Andrew, Thanks for your suggestion, I will give a more comprehensive changelog in patch v2 later. thanks, Jun On 2018/3/2 7:29, Andrew Morton wrote: > On Thu, 1 Mar 2018 20:37:50 +0800 piaojun wrote: > >> Hi Changwei, >> >> Thanks for your quick reply, please see my

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-02 Thread piaojun
Hi Changwei, On 2018/3/2 13:53, Changwei Ge wrote: > On 2018/3/2 10:09, piaojun wrote: >> Hi Changwei, >> >> On 2018/3/2 9:49, Changwei Ge wrote: >>> Hi Jun, >>> I still have some doubts about your problematic situation description . >>> Please check my reply inline your sequence diagram. >>> >>>

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-01 Thread piaojun
Hi Changwei, On 2018/3/2 9:49, Changwei Ge wrote: > Hi Jun, > I still have some doubts about your problematic situation description . > Please check my reply inline your sequence diagram. > > On 2018/3/1 20:38, piaojun wrote: >> Hi Changwei, >> >> Thanks for your quick reply, please see my

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-01 Thread Andrew Morton
On Thu, 1 Mar 2018 20:37:50 +0800 piaojun wrote: > Hi Changwei, > > Thanks for your quick reply, please see my comments below. > > On 2018/3/1 17:39, Changwei Ge wrote: > > Hi Jun, > > > > On 2018/3/1 17:27, piaojun wrote: > >> We should not handle migrate lockres if we

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-01 Thread piaojun
Hi Changwei, Thanks for your quick reply, please see my comments below. On 2018/3/1 17:39, Changwei Ge wrote: > Hi Jun, > > On 2018/3/1 17:27, piaojun wrote: >> We should not handle migrate lockres if we are already in >> 'DLM_CTXT_IN_SHUTDOWN', as that will cause lockres remains after >>

[Ocfs2-devel] [PATCH] ocfs2/dlm: don't handle migrate lockres if already in shutdown

2018-03-01 Thread piaojun
We should not handle migrate lockres if we are already in 'DLM_CTXT_IN_SHUTDOWN', as that will cause lockres remains after leaving dlm domain. At last other nodes will get stuck into infinite loop when requsting lock from us. N1 N2 (owner)