Hi Dan,
I think O2NM_MAX_NAME_LEN is the max valid length of the domain name.
Regarding your patch, it changed to be that a domain name with length
O2NM_MAX_NAME_LEN (NULL character not included) is not permitted.
Though that check seems useless for current calls, we'd better keep it.
Checking
Hi Dan,
On 10-07-12 15:39, Dan Carpenter wrote:
On Mon, Jul 12, 2010 at 07:30:06PM +0800, Wengang Wang wrote:
Also, the uuid shouldn't be treated as NULL tailed string.
142 struct ocfs2_control_message_down {
143 chartag[OCFS2_CONTROL_MESSAGE_OP_LEN];
144 char
Acked-by: Sunil Mushran sunil.mush...@oracle.com
On 07/10/2010 07:33 AM, Dan Carpenter wrote:
This function is only called from one place and it's like this:
dlm_register_domain(conn-cc_name, dlm_key,fs_version);
The conn-cc_name is 64 characters long. If strlen(conn-cc_name)
were
So o2dlm expects a null terminated domain name. The original
patch is good as it adds the check in o2dlm only.
For userspace, we allow non-null terminating group (domain) name.
That remains unchanged.
On 07/12/2010 04:30 AM, Wengang Wang wrote:
Hi Dan,
I think O2NM_MAX_NAME_LEN is the max
On Sat, Jul 10, 2010 at 04:33:36PM +0200, Dan Carpenter wrote:
This function is only called from one place and it's like this:
dlm_register_domain(conn-cc_name, dlm_key, fs_version);
The conn-cc_name is 64 characters long. If strlen(conn-cc_name)
were equal to O2NM_MAX_NAME_LEN (64)
On Mon, Jul 12, 2010 at 07:30:06PM +0800, Wengang Wang wrote:
Also, the uuid shouldn't be treated as NULL tailed string.
142 struct ocfs2_control_message_down {
143 chartag[OCFS2_CONTROL_MESSAGE_OP_LEN];
144 charspace1;
145 charuuid[OCFS2_TEXT_UUID_LEN];
This function is only called from one place and it's like this:
dlm_register_domain(conn-cc_name, dlm_key, fs_version);
The conn-cc_name is 64 characters long. If strlen(conn-cc_name)
were equal to O2NM_MAX_NAME_LEN (64) that would be a bug because
strlen() doesn't count the NULL
