Re: [Ocfs2-devel] o2net: log socket state changes

2010-04-06 Thread Joel Becker
On Wed, Mar 31, 2010 at 02:32:29PM -0700, Srinivas Eeda wrote: This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com This patch is now in the 'merge-window' branch of ocfs2.git. It had two lines with trailing

Re: [Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Sunil Mushran
KERN_INFO is a good idea. But the message is a mouthful. Currently it reads: node %s (num %u) at %u.%u.%u.%u:%u socket state changed to X. Shutting down the socket connection How about this: o2net: connection to node %s (num %u) at %u.%u.%u.%u:%u shutdown, state %d printk(KERN_INFO connection

Re: [Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Sunil Mushran
Can you also provide a snippet of the messages after some mounts and umounts. Sunil Mushran wrote: KERN_INFO is a good idea. But the message is a mouthful. Currently it reads: node %s (num %u) at %u.%u.%u.%u:%u socket state changed to X. Shutting down the socket connection How about this:

[Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Srinivas Eeda
This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 334f231..8bda1ea

Re: [Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Sunil Mushran
Please can you prepend o2net: to the message. Easier to grep. Srinivas Eeda wrote: This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0

Re: [Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Sunil Mushran
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com Srinivas Eeda wrote: This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[Ocfs2-devel] o2net: log socket state changes

2010-03-30 Thread Srinivas Eeda
This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 334f231..6d0d228