Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-08 Thread Wengang Wang
On 10-06-03 18:06, Srinivas Eeda wrote: Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do not inform recovery master if DLM_LOCK_RES_DROPPING_REF

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-05 Thread Srinivas Eeda
On 6/3/2010 10:37 PM, Wengang Wang wrote: Srini, On 10-06-03 19:17, Srinivas Eeda wrote: Can you please explain the idea of the new flag DLM_LOCK_RES_DE_DROP_REF :) If the idea of the fix is to address the race between purging and recovery, I am wondering DLM_LOCK_RES_DROPPING_REF and

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Srinivas Eeda
Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do not inform recovery master if DLM_LOCK_RES_DROPPING_REF is set and don't resend deref in this

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Wengang Wang
Srini, On 10-06-03 18:06, Srinivas Eeda wrote: Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do not inform recovery master if

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Srinivas Eeda
On 6/3/2010 6:43 PM, Wengang Wang wrote: Srini, On 10-06-03 18:06, Srinivas Eeda wrote: Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do not

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Wengang Wang
Srini, On 10-06-03 19:17, Srinivas Eeda wrote: Can you please explain the idea of the new flag DLM_LOCK_RES_DE_DROP_REF :) If the idea of the fix is to address the race between purging and recovery, I am wondering DLM_LOCK_RES_DROPPING_REF and DLM_LOCK_RES_RECOVERING flags may be enough to