[Ocfs2-devel] [patch 1/4] ocfs2: fix a couple of memory leaks at o2hb_map_slot_data()

2012-08-22 Thread Jeff Liu
This patch can fix a couple of potential memory leaks at o2hb_map_slot_data(). Signed-off-by: Jie Liu jeff@oracle.com --- fs/ocfs2/cluster/heartbeat.c | 33 + 1 files changed, 25 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c

[Ocfs2-devel] [PATCH 3/4] ocfs2: trivial fix a comments typo at o2quo_hb_still_up()

2012-08-22 Thread Jeff Liu
Signed-off-by: Jie Liu jeff@oracle.com --- fs/ocfs2/cluster/quorum.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/cluster/quorum.c b/fs/ocfs2/cluster/quorum.c index 8f9cea1..50583d2 100644 --- a/fs/ocfs2/cluster/quorum.c +++ b/fs/ocfs2/cluster/quorum.c

[Ocfs2-devel] [PATCH 2/4] ocfs2: s/o2hb_hearbeat_xxx/o2hb_heartbeat_xxx/g at heartbeat.c

2012-08-22 Thread Jeff Liu
Not sure if this patch does make sense or not, but it could make the signature of those routines in a consistent manner with others for heartbeating. CC: Sunil Mushran sunil.mush...@gmail.com Signed-off-by: Jie Liu jeff@oracle.com --- fs/ocfs2/cluster/heartbeat.c |8 1 files

[Ocfs2-devel] [PATCH 4/4] ocfs2: trivial fix the switch..case syntax at o2net_state_change()

2012-08-22 Thread Jeff Liu
Syntax adjustment, I have to fix printk to pr_info(), or else, checkpatch.pl will alert me. Signed-off-by: Jie Liu jeff@oracle.com --- fs/ocfs2/cluster/tcp.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c

[Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Jie Liu
Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too high, etc... I suspect it might caused by ocfs2 fencing if it's BIO reading/writing can not be

Re: [Ocfs2-devel] [PATCH 2/4] ocfs2: s/o2hb_hearbeat_xxx/o2hb_heartbeat_xxx/g at heartbeat.c

2012-08-22 Thread Sunil Mushran
Acked-by: Sunil Mushran sunil.mush...@gmail.com On Wed, Aug 22, 2012 at 2:38 AM, Jeff Liu jeff@oracle.com wrote: Not sure if this patch does make sense or not, but it could make the signature of those routines in a consistent manner with others for heartbeating. CC: Sunil Mushran

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread srinivas eeda
On 8/22/2012 7:17 AM, Jie Liu wrote: Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too high, etc... I suspect it might caused by ocfs2 fencing

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Sunil Mushran
Yes. WRITE_SYNC should be good. Not FUA. Also, you may want to look into using io priorities. The code is all there. Just needs activation. On Wed, Aug 22, 2012 at 10:13 AM, srinivas eeda srinivas.e...@oracle.comwrote: On 8/22/2012 7:17 AM, Jie Liu wrote: Hi All, These days, I am

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Jie Liu
On 08/23/12 01:13, srinivas eeda wrote: On 8/22/2012 7:17 AM, Jie Liu wrote: Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too high, etc...

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Jie Liu
On 08/23/12 01:18, Sunil Mushran wrote: Yes. WRITE_SYNC should be good. Not FUA. Also, you may want to look into using io priorities. The code is all there. Just needs activation. Yes, I'll search the list to find them out. Thanks, -Jeff On Wed, Aug 22, 2012 at 10:13 AM, srinivas eeda

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Tao Ma
Hi Jeff, On 08/22/2012 10:17 PM, Jie Liu wrote: Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too high, etc... I suspect it might caused by

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread Jie Liu
Hi Tao, On 08/23/12 11:44, Tao Ma wrote: Hi Jeff, On 08/22/2012 10:17 PM, Jie Liu wrote: Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too