but I guess it should be
sufficient.
Honza
Jan Kara wrote:
Hello,
because SLES10 SP2 is closer than I thought, I've written the patch to
dynamically size the hash table with locks in DLM. First, there's new
mount
option
you try this out confirm this fixes the problem for you?
(Currently it only passes the It builds, ship it! test, but it's
pretty straightforward; and I'm on an airplane at the moment. :-)
The patch looks fine. You can add:
Acked-by: Jan Kara [EMAIL PROTECTED
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index f38a5af..ff5b789 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1018,8 +1018,7 @@ static int
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
include/linux/quotaops.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h
index f7dcc30..94f00ec 100644
--- a/include/linux/quotaops.h
+++ b/include/linux/quotaops.h
This is going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 222 -
fs
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index d318c7e..6bf9de4 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8 +994,7 @@ static
OCFS2 needs to peek whether quota structure is already in memory so
that it can avoid expensive cluster locking in that case. Similarly
when freeing dquots, it checks whether it is the last quota structure
user or not.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 30
new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
checking of the return value.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/namei.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index d5d808f
in dquot-dq_flags which entries have been set by SETQUOTA
and quota format can clear these flags when it properly propagated
the changes.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c| 12 ++--
include/linux/quota.h | 26 --
2 files changed, 30
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h| 33
Checks like = 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c | 191
Add quota calls for allocation and freeing of inodes and space, also update
estimates on number of needed credits for a transaction. Move out inode
allocation from ocfs2_mknod_locked() because vfs_dq_init() must be called
outside of a transaction.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs
to
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 50 ++---
fs
This patch implements functions and timer setup which handles periodic
syncing of locally cached quota information to global quota file.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota.h|3 ++
fs/ocfs2/quota_global.c | 66
-by: Jan Kara [EMAIL PROTECTED]
---
fs/quota_v2.c| 49 ++
include/linux/dqblk_v1.h |4 ---
include/linux/dqblk_v2.h |4 ---
include/linux/quota.h|5 +---
4 files changed, 33 insertions(+), 29 deletions(-)
diff --git a/fs/quota_v2
On Tue 21-10-08 13:26:18, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:51PM +0200, Jan Kara wrote:
On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
Thus checks for !handle are wrong. Fix them to use IS_ERR().
Signed-off-by: Jan Kara [EMAIL PROTECTED]
Signed-off
On Tue 21-10-08 13:32:10, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:52PM +0200, Jan Kara wrote:
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
I'm guessing this is required for the quota code
On Tue 21-10-08 13:43:18, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:55PM +0200, Jan Kara wrote:
Signed-off-by: Jan Kara [EMAIL PROTECTED]
This patch actually looks fine except for one thing:
diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
index 4f61985..bb41c6a 100644
On Tue 21-10-08 13:35:03, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:53PM +0200, Jan Kara wrote:
new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
checking of the return value.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
Signed-off-by: Joel Becker [EMAIL
On Tue 21-10-08 16:51:55, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:59PM +0200, Jan Kara wrote:
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
Signed-off-by: Jan Kara
On Tue 21-10-08 16:10:46, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:57PM +0200, Jan Kara wrote:
Signed-off-by: Jan Kara [EMAIL PROTECTED]
The commit message could maybe use a little discussion of what
quota bits go in the local file and what goes in the global. It seems
like
On Tue 21-10-08 16:34:46, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:58PM +0200, Jan Kara wrote:
Add quota calls for allocation and freeing of inodes and space, also update
estimates on number of needed credits for a transaction. Move out inode
allocation from ocfs2_mknod_locked
Hello,
the following patch series implements quotas for OCFS2. The patch
series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next
I've adressed Joel's comments, also node recovery is now fully working
and I've fixed a few issues I found during my testing. So
Oops, and now really the patch series... Sorry for the bad post.
Honza
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Some filesystems would like to keep private information together with each
dquot. Add callbacks alloc_dquot and destroy_dquot allowing filesystem to
allocate larger dquots from their private slab in a similar fashion we
currently allocate inodes.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs
track of a state which has been suspended.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 10 ++
include/linux/quotaops.h |6 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 9eda830..46d46df 100644
--- a/fs
to
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 50 ++---
fs
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index d318c7e..6bf9de4 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8 +994,7 @@ static
.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c|6 --
include/linux/quota.h |3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 5b82722..9d2a1f0 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -845,7 +845,8 @@ static inline
This is going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 222 -
fs
Checks like = 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h| 33
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
include/linux/quotaops.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h
index f7dcc30..94f00ec 100644
--- a/include/linux/quotaops.h
+++ b/include/linux/quotaops.h
in dquot-dq_flags which entries have been set by SETQUOTA
and quota format can clear these flags when it properly propagated
the changes.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c| 12 ++--
include/linux/quota.h | 26 --
2 files changed, 30
-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c| 45 ++---
fs/quota.c|3 +++
include/linux/quota.h |7 +++
3 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 96ed45b..5b82722
and quota type when recovering quota file after crash.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 38 --
include/linux/quotaops.h |4
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index
new_inode() does not return ERR_PTR() but NULL in case of failure. Correct
checking of the return value.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/namei.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 485a6aa
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/ocfs2
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/inode.c|2 ++
fs/ocfs2/ocfs2_fs.h | 23 ---
fs/ocfs2/super.c| 17 +
3 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 4903688..da3a360
We forgot to set i_nlink to 0 when returning due to error from
ocfs2_mknod_locked()
and thus inode was not properly released via ocfs2_delete_inode() (e.g. claimed
space was not released). Fix it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/namei.c |4 +++-
1 files changed, 3
This patch implements functions and timer setup which handles periodic
syncing of locally cached quota information to global quota file.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota.h|3 ++
fs/ocfs2/quota_global.c | 71
Add quota calls for allocation and freeing of inodes and space, also update
estimates on number of needed credits for a transaction. Move out inode
allocation from ocfs2_mknod_locked() because vfs_dq_init() must be called
outside of a transaction.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs
Hello,
attached is a patch which implements necessary support for
mkfs so that quota files can be created.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
From c5de88cee9136605dc64f943aa31d2ebdd9bd8c7 Mon Sep 17 00:00:00 2001
From
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 399a96a..12c2e22 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1018,8 +1018,7 @@ static int
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 20 -
fs/ocfs2/ocfs2.h |3 +
fs/ocfs2/super.c | 217
-by: Jan Kara [EMAIL PROTECTED]
---
fs/quota_v2.c| 53 +
include/linux/dqblk_v1.h |4 ---
include/linux/dqblk_v2.h |4 ---
include/linux/quota.h|5 +---
4 files changed, 35 insertions(+), 31 deletions(-)
diff --git a/fs/quota_v2.c
Mark system files as not subject to quota accounting. This prevents
possible recursions into quota code and thus deadlocks.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/inode.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2
filesystems if they decide to use VFS quotas.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 36
include/linux/quotaops.h |3 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index f6bcacd
On Wed 22-10-08 10:31:49, Joel Becker wrote:
On Wed, Oct 22, 2008 at 04:49:00PM +0200, Jan Kara wrote:
On Tue 21-10-08 16:34:46, Joel Becker wrote:
On Mon, Oct 20, 2008 at 07:23:58PM +0200, Jan Kara wrote:
Add quota calls for allocation and freeing of inodes and space, also
update
On Fri 24-10-08 15:40:25, Joel Becker wrote:
On Fri, Oct 24, 2008 at 11:57:02PM +0200, Jan Kara wrote:
while playing with quota support I found two bugs in OCFS2 mount/umount
code. The first problem is, that if mount fails, we call
ocfs2_dismount_volume(). That is fine but after
On Sat 25-10-08 00:10:22, Jan Kara wrote:
Hello,
attached is a patch which implements necessary support for
mkfs so that quota files can be created.
As Mark pointed to me, the patch missed the libocfs2/quota.c
file. So a fixed patch is attached
On Tue 28-10-08 12:11:03, Joel Becker wrote:
On Sat, Oct 25, 2008 at 12:08:22AM +0200, Jan Kara wrote:
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options.
snip
diff --git a/fs
On Tue 28-10-08 15:16:06, Joel Becker wrote:
On Sat, Oct 25, 2008 at 12:08:16AM +0200, Jan Kara wrote:
diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
index f24ce3d..dd17137 100644
--- a/fs/ocfs2/ocfs2_fs.h
+++ b/fs/ocfs2/ocfs2_fs.h
@@ -93,7 +93,9
it.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
On Wed 29-10-08 15:58:32, Mark Fasheh wrote:
On Sat, Oct 25, 2008 at 12:05:04AM +0200, Jan Kara wrote:
Hello,
the following patch series implements quotas for OCFS2. The patch
series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next
Great
On Wed 29-10-08 03:51:39, Joel Becker wrote:
On Wed, Oct 29, 2008 at 03:29:02AM +0100, Jan Kara wrote:
+/* Structure with global user / group information. We reserve some
space
+ * for future use. */
+struct ocfs2_global_disk_dqblk {
+/*00*/ __le32 dqb_id; /* ID
On Thu 30-10-08 16:52:34, Mark Fasheh wrote:
On Sat, Oct 25, 2008 at 12:08:15AM +0200, Jan Kara wrote:
We forgot to set i_nlink to 0 when returning due to error from
ocfs2_mknod_locked()
and thus inode was not properly released via ocfs2_delete_inode() (e.g.
claimed
space
Some filesystems would like to keep private information together with each
dquot. Add callbacks alloc_dquot and destroy_dquot allowing filesystem to
allocate larger dquots from their private slab in a similar fashion we
currently allocate inodes.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs
Checks like = 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs
track of a state which has been suspended.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 10 ++
include/linux/quotaops.h |6 --
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 735e2c3..1f9f1f1 100644
--- a/fs
Hi,
in this thread comes the third version of the patches implementing quotas for
OCFS2 (sorry for spamming ocfs2-devel so often with such a big pile of patches
;). I've now addressed all Joel's comments (feature bits added among supported
bits in the last patch, hopefully fixed an oops when
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ext3/super.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 18eaa78..6078bd3 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1031,8 +1031,7 @@ static int
to
handle this. Also update inode allocation / checking functions to use qsize_t
and make global structure keep quota limits in bytes so that things are
consistent.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 50 ++---
fs
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ext4/super.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index bdddea1..be34b66 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1139,8 +1139,7 @@ static int
-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c| 45 ++---
fs/quota.c|3 +++
include/linux/quota.h |7 +++
3 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index adf59ce..f4d6f7e
.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c|6 --
include/linux/quota.h |3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index f4d6f7e..cf0dac7 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -847,7 +847,8 @@ static inline
Since these include files are used only by implementation of quota formats,
there's no need to have them in include/linux/.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/quota_v1.c |3 +-
fs/quota_v2.c |7 ++--
fs/quotaio_v1.h| 33
This is going to be useful when quota is treated as filesystem metadata - we
then want to keep quota information uptodate all the time and just enable /
disable limits enforcement.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 222 -
fs
Increase reported version number of quota support since quota core has changed
significantly. Also remove __DQUOT_NUM_VERSION__ since nobody uses it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
include/linux/quota.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
OCFS2 can easily support nested transactions. We just have to
take care and not spoil statistics acquire semaphore unnecessarily.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/ocfs2
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/reiserfs/super.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 663a91f..a9b393a 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -994,8 +994,7 @@ static
Mark system files as not subject to quota accounting. This prevents
possible recursions into quota code and thus deadlocks.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/inode.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2
OCSF2 will need to queue up work for periodic syncing of quotas
among nodes in the cluster. pdflush() is good thread for this so
export it's controlling function so that OCFS2 can use it.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
mm/pdflush.c |1 +
1 files changed, 1 insertions(+), 0
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/inode.c|2 ++
fs/ocfs2/ocfs2_fs.h | 21 ++---
fs/ocfs2/super.c| 17 +
3 files changed, 37 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 7aa00d5..c80489d
filesystems if they decide to use VFS quotas.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 36
include/linux/quotaops.h |3 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index 8774be6
and quota type when recovering quota file after crash.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c | 38 --
include/linux/quotaops.h |4
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/fs/dquot.c b/fs/dquot.c
index
This patch implements functions and timer setup which handles periodic
syncing of locally cached quota information to global quota file.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota.h|3 ++
fs/ocfs2/quota_global.c | 71
Implement functions for recovery after a crash. Functions just
read local quota file and sync info to global quota file.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 106 +---
fs/ocfs2/journal.h |1 +
fs/ocfs2/ocfs2.h|4 +-
fs/ocfs2
Enable quota usage tracking on mount and disable it on umount. Also
add support for quota on and quota off quotactls and usrquota and
grpquota mount options. Add quota features among supported ones.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 20 -
fs/ocfs2/ocfs2.h
etc.)
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
---
From ae793c411ae24a8b097ab441813d3cde709909a7 Mon Sep 17 00:00:00 2001
From: Jan Kara [EMAIL PROTECTED]
Date: Wed, 20 Aug 2008 15:43:36 +0200
Subject: [PATCH 21/27] ocfs2
the function is
right when I submit next version of patches.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http
On Wed 05-11-08 16:06:29, Mark Fasheh wrote:
On Sat, Oct 25, 2008 at 12:08:19AM +0200, Jan Kara wrote:
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 9af16e0..75cdb0e 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -35,6 +35,7 @@
#include linux/mount.h
#include linux
On Wed 05-11-08 16:52:27, Mark Fasheh wrote:
On Sat, Oct 25, 2008 at 12:08:21AM +0200, Jan Kara wrote:
Implement functions for recovery after a crash. Functions just
read local quota file and sync info to global quota file.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2
prototype of ocfs2_read_virt_blocks() avoids this error handling
confusion. Let's change ocfs2_read_quota_block() to match.
Signed-off-by: Joel Becker [EMAIL PROTECTED]
OK, thanks. Tha patch looks fine.
Acked-by: Jan Kara [EMAIL PROTECTED
Make function return error status and not buffer pointer so that it's
consistent with ocfs2_read_quota_block().
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota_global.c | 27 +--
1 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/fs/ocfs2
We have to mark buffer as uptodate before calling ocfs2_journal_access() and
ocfs2_set_buffer_uptodate() does not do this for us.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota_global.c | 28
1 files changed, 12 insertions(+), 16 deletions(-)
diff
Add missing variable initialization to ocfs2_dquot_drop_slow().
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota_global.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
index d2a5bfa..7f561e4 100644
--- a/fs
Unexport header files dqblk_v[12].h since except for quota format ID they
don't contain information userspace should be interested in. Move ID
definitions to quota.h.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
include/linux/Kbuild |2 --
include/linux/dqblk_v1.h |3 ---
include
These are default functions for creating and destroying quota structures
and they should be used from filesystems.
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/dquot.c |6 --
include/linux/quotaops.h |2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff
From: Joel Becker [EMAIL PROTECTED]
ocfs2_bread() has become ocfs2_read_virt_blocks(), with a prototype to
match ocfs2_read_blocks(). The quota code, converting from
ocfs2_bread(), wraps the call to ocfs2_read_virt_blocks() in
ocfs2_read_quota_block(). Unfortunately, the prototype of
Signed-off-by: Jan Kara [EMAIL PROTECTED]
---
fs/reiserfs/super.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index a9b393a..c55651f 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -649,6 +649,8 @@ static struct
also
the patch from Joel changing ocfs2_read_quota_block(). Please merge them.
The patches should be against your linux-next branch from today.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
-by: Jan Kara [EMAIL PROTECTED]
---
fs/ocfs2/quota_global.c |6 +++---
fs/ocfs2/quota_local.c |3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
index 27a8123..b0eae79 100644
--- a/fs/ocfs2/quota_global.c
+++ b/fs/ocfs2
/* JOURNAL_HEAD_H_INCLUDED */
Otherwise the patch looks nice.
Honza
--
Jan Kara j...@suse.cz
SuSE CR Labs
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com
, just create a
workqueue, 'o2quota' and just constantly queue a delayed work item. The
impact of this should be pretty minimal.
Signed-off-by: Mark Fasheh mfas...@suse.com
The patch looks fine. You can add 'Acked-by: Jan Kara j...@suse.cz
()?
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Hello,
the following series of patches fixes some issues with OCFS2 quotas.
The first patch modifies VFS quota locking, the next patch uses the
fact to simplify OCFS2 quota locking and solves a few deadlock issues.
The third and the fourth patches fix another possible deadlocks in OCFS2
quota
.
Signed-off-by: Jan Kara j...@suse.cz
---
fs/ocfs2/quota_global.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
index f4efa89..1ed0f7c 100644
--- a/fs/ocfs2/quota_global.c
+++ b/fs/ocfs2/quota_global.c
@@ -754,7 +754,9
Since -acquire_dquot and -release_dquot callbacks aren't called under
dqptr_sem anymore, we don't have to start a transaction and obtain locks
so early. So we can just remove all this complicated stuff.
Signed-off-by: Jan Kara j...@suse.cz
---
fs/ocfs2/quota_global.c | 169
1 - 100 of 594 matches
Mail list logo
