Re: [Ocfs2-devel] mount gnenerates an error : Unable to access cluster service while starting heartbeat

2007-03-28 Thread Srinivas Eeda
That might because you have configured user mode dlm. What does |cat /sys/o2cb/heartbeat_mode show, user?. If so run, /etc/init.d/o2cb configure and answer n for the following ||Use user-space driven heartbeat? (y/n) [y] n thanks, --Srini || |Andy Johnson wrote: Hello, I have

[Ocfs2-devel] [PATCH 1/1] Patch to clean orphans in all offline slots during recovery.

2009-02-19 Thread Srinivas Eeda
things: a) Recover orphans during mount of the slot that it is using. b) Recover orphans in all offline slots during recovery. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c | 44 +++- 1 files changed, 27 insertions(+), 17

[Ocfs2-devel] [PATCH 1/1] Patch to recover orphans from the slot during mount

2009-02-27 Thread Srinivas Eeda
are clean they will not queue to recover their orphan directory. This patch queues to recover orphans when the slot is next used. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git

[Ocfs2-devel] Patch to move ocfs2_slot_info to slot_map.h

2009-02-27 Thread Srinivas Eeda
Next 3 patches does the following 1) movies ocfs2_slot_info struct from slot_map.c to slot_map.h 2) patch to recover orphans during mount even if the journal is clean 3) patch to recovery orphans in offline slots ___ Ocfs2-devel mailing list

[Ocfs2-devel] [PATCH 1/1] Patch to recover orphans in offline slots during recovery and mount

2009-03-04 Thread Srinivas Eeda
recovers it's own slot, which leaves orphans in offline slots. This patch queues complete_recovery to clean orphans for all offline slots during mount and node recovery. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c | 106

[Ocfs2-devel] [PATCH 1/1] Patch to recover orphans in offline slots during recovery and mount

2009-03-05 Thread Srinivas Eeda
recovers it's own slot, which leaves orphans in offline slots. This patch queues complete_recovery to clean orphans for all offline slots during mount and node recovery. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c | 136

[Ocfs2-devel] [PATCH 1/1] ocfs2: recover orphans in offline slots during recovery and mount

2009-03-06 Thread Srinivas Eeda
recovers it's own slot, which leaves orphans in offline slots. This patch queues complete_recovery to clean orphans for all offline slots during mount and node recovery. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com Signed-off-by: Joel Becker joel.bec...@oracle.com --- fs/ocfs2/journal.c | 140

[Ocfs2-devel] Backport to 1.4 of patch that recovers orphans from offline slots

2009-04-07 Thread Srinivas Eeda
The following patch is a backport of patch that recovers orphans from offline slots. It is being backported from mainline to 1.4 mainline patch: 0001-Patch-to-recover-orphans-in-offline-slots-during-rec.patch Thanks, --Srini ___ Ocfs2-devel mailing

Re: [Ocfs2-devel] orphan cleanup

2009-04-30 Thread Srinivas Eeda
hmm, even if we queue the orphan recovery, inode may not get cleaned if the inode is still around on some node right? The node where the inode is still cached will vote no again? Sunil Mushran wrote: Joel Becker wrote: Srini, Ok, you can go ahead and cook up the background orphan

Re: [Ocfs2-devel] FW: Oracle 9204 installation on linux x86-64 on ocfs

2009-05-04 Thread Srinivas Eeda
did you use -o datavolume, nointr options for mounting? keyur patel wrote: Hello All, I have installed Oracle Cluster Manager on linux x86-64 nit. I am using ocfs file system for quorum file. But I am getting following error. Please see ocfs configureation below. I would appreciate, if

[Ocfs2-devel] [PATCH 1/1] OCFS2: timer to queue scan of all orphan slots

2009-05-19 Thread Srinivas Eeda
-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlmglue.c | 58 + fs/ocfs2/dlmglue.h |8 +++ fs/ocfs2/journal.c | 109 +++ fs/ocfs2/journal.h | 12 + fs/ocfs2/ocfs2.h|2 + fs

[Ocfs2-devel] [PATCH 1/1] OCFS2: timer to queue scan of all orphan slots

2009-05-21 Thread Srinivas Eeda
at a time. It is done once every X seconds, where X is a value between ORPHAN_SCAN_SCHEDULE_TIMEOUT/2 and ORPHAN_SCAN_SCHEDULE_TIMEOUT milliseconds. Each time the scan is done by different node so eventually the node that has the inode cached will get to wipe the file. Signed-off-by: Srinivas Eeda

[Ocfs2-devel] [PATCH 2/2] ocfs2 patch to track delayed orphan scan timer statistics

2009-06-02 Thread Srinivas Eeda
Patch to track delayed orphan scan timer statistics. Modifies ocfs2_osb_dump to print the following: Orphan Scan= Local: 10 Global: 21 Last Scan: 67 seconds ago Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c |2 ++ fs/ocfs2/ocfs2.h |4 +++- fs/ocfs2

[Ocfs2-devel] [PATCH 1/2] OCFS2: timer to queue scan of all orphan slots

2009-06-02 Thread Srinivas Eeda
at a time. It is done once every X seconds, where X is a value between ORPHAN_SCAN_SCHEDULE_TIMEOUT/2 and ORPHAN_SCAN_SCHEDULE_TIMEOUT milliseconds. Each time the scan is done by different node so eventually the node that has the inode cached will get to wipe the file. Signed-off-by: Srinivas Eeda

[Ocfs2-devel] Patches that adds delayed orphan scan timer

2009-06-02 Thread Srinivas Eeda
Resending after adding another patch to display delayed orphan scan statistics. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-06-02 Thread Srinivas Eeda
the cluster so that no one node has to perform the task all the time. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlmglue.c | 47 + fs/ocfs2/dlmglue.h | 11 + fs/ocfs2/journal.c | 106 +++ fs

[Ocfs2-devel] [PATCH 2/2] ocfs2 patch to track delayed orphan scan timer statistics

2009-06-02 Thread Srinivas Eeda
Patch to track delayed orphan scan timer statistics. Modifies ocfs2_osb_dump to print the following: Orphan Scan= Local: 10 Global: 21 Last Scan: 67 seconds ago Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/journal.c |2 ++ fs/ocfs2/ocfs2.h |4 +++- fs/ocfs2

[Ocfs2-devel] Patches that adds delayed orphan scan timer (rev 2)

2009-06-02 Thread Srinivas Eeda
Resending after implementing review comments. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH 2/2] ocfs2 patch to track delayed orphan scan timer statistics

2009-06-03 Thread Srinivas Eeda
Patch to track delayed orphan scan timer statistics. Modifies ocfs2_osb_dump to print the following: Orphan Scan= Local: 10 Global: 21 Last Scan: 67 seconds ago Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/journal.c

[Ocfs2-devel] Patches that adds delayed orphan scan timer (rev 3)

2009-06-03 Thread Srinivas Eeda
Resending after implementing review comments. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-06-04 Thread Srinivas Eeda
such inodes. Care has been taken to distribute the workload across the cluster so that no one node has to perform the task all the time. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlmglue.c | 51 ++ fs/ocfs2/dlmglue.h | 10 fs/ocfs2

[Ocfs2-devel] Backport that adds delayed orphan scan timer to 1.4

2009-06-04 Thread Srinivas Eeda
Next two patches are backport of orphan scan timer patches to ocfs2-1.4 ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-06-10 Thread Srinivas Eeda
in ocfs2_super when reflink is ongoing(I will do it). Make sense? Yes, I can restrict the node to recover it's own and offline slots. I can make the node to recover it's own slot every time the timer fires and offline slots in round robin way(current way) Regards, Tao Srinivas Eeda wrote

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: timer to queue scan of all orphan slots

2009-07-17 Thread Srinivas Eeda
Tao Ma wrote: Hi Joel, This reply may be really too late. :) Joel Becker wrote: On Wed, Jun 10, 2009 at 01:37:53PM +0800, Tao Ma wrote: I also have some thoughts for it. Wish it isn't too late. Well, if we come up with changes it will affect what I push, but that's OK.

[Ocfs2-devel] [PATCH] o2net: delay ENOTCONN for sends receives till quorum decision

2009-11-19 Thread Srinivas Eeda
is cancelled and messaging resumes. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c | 94 +++ fs/ocfs2/cluster/tcp_internal.h |9 ++-- 2 files changed, 60 insertions(+), 43 deletions(-) diff --git a/fs/ocfs2

[Ocfs2-devel] [PATCH] ocfs2: avoid panic for local mounts on corruptions

2009-11-23 Thread Srinivas Eeda
When a file system is mounted local, it may be enough to remount it read only on seeing corruptions. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/super.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c

[Ocfs2-devel] [PATCH 2/3] o2net: delay enotconn for sends receives till quorum decision

2010-01-28 Thread Srinivas Eeda
messages to/from evicted node. If network connection comes back before the eviction, quorum decision is cancelled and messaging resumes. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c | 69 +++ fs/ocfs2/cluster

[Ocfs2-devel] [PATCH 1/3] o2net: rollback reconnect on network timeout.

2010-01-28 Thread Srinivas Eeda
This patch rollbacks earlier fix that tries to re-establish network connection when network timeout happens. Reconnect was re-cycling sockets which results in lost messages resulting in hangs. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c | 50

[Ocfs2-devel] o2net patches

2010-01-28 Thread Srinivas Eeda
Following 3 patches fixes: 1. rollback's reconnect fix 2. delay enotconn for sends, receives till a node reconnects/dies after a lost connection. 3. Correct's keepalive protocol Thanks, --Srini ___ Ocfs2-devel mailing list

Re: [Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol

2010-02-17 Thread Srinivas Eeda
they received. So nodes with this patch will always receive a response message. So, in a mixed setup, both nodes will always hear the heartbeat from each other :). thanks, --Srini Joel Becker wrote: On Thu, Jan 28, 2010 at 08:51:11PM -0800, Srinivas Eeda wrote: case

Re: [Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol

2010-02-17 Thread Srinivas Eeda
No harm, just doubles heartbeat messages which is not required at all. Sunil Mushran wrote: What's the harm in leaving it in? Srinivas Eeda wrote: Each node that has this patch would send a O2NET_MSG_KEEP_REQ_MAGIC every 2 seconds(default). So, nodes without this patch would always

Re: [Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol

2010-02-17 Thread Srinivas Eeda
alive every 2 seconds. Sunil Mushran wrote: How will it double? The node will send a keepalive only if it has not heard from the other node for 2 secs. Srinivas Eeda wrote: No harm, just doubles heartbeat messages which is not required at all. Sunil Mushran wrote: What's the harm in leaving

Re: [Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol

2010-02-17 Thread srinivas eeda
. As in, not wait for the response to requeue. But we'll still be smart about it in the sense that not send a hb even if the nodes are communicating otherwise. Srinivas Eeda wrote: In old code a node cancels and re queues keep alive message when it hears from the other node. If it didn't hear in 2

Re: [Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol

2010-02-17 Thread srinivas eeda
Yea, they don't expect/wait for a response for keep alive message. On 2/17/2010 5:49 PM, Joel Becker wrote: On Wed, Feb 17, 2010 at 10:24:30AM -0800, Srinivas Eeda wrote: Each node that has this patch would send a O2NET_MSG_KEEP_REQ_MAGIC every 2 seconds(default). So, nodes without

[Ocfs2-devel] [PATCH 3/3] o2net: correct keepalive message protocol (revision 2)

2010-02-18 Thread Srinivas Eeda
delivery. However the intention of this feature was to send a keepalive message every timeout seconds. This patch sends a message for every keepalive time interval. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |6 +- 1 files changed, 5 insertions(+), 1

[Ocfs2-devel] [PATCH 1/1] dlm: fix a race in lockres mastery

2010-03-22 Thread Srinivas Eeda
DLM_ASSERT_RESPONSE_MASTERY_REF) which creates a hole that results in loss of refmap bit on the master node. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmmaster.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm

Re: [Ocfs2-devel] [PATCH 1/1] dlm: fix a race in lockres mastery

2010-03-22 Thread SRINIVAS EEDA
Sunil, Joel, thanks for modifying the comments :) On 3/22/2010 6:47 PM, Joel Becker wrote: On Mon, Mar 22, 2010 at 06:20:32PM -0700, Sunil Mushran wrote: yes, your wording is better. and yes, dlm-spinlock is the top level lock. This patch is now in the 'fixes' branch of

[Ocfs2-devel] [PATCH 1/1] ocfs2: Fix a race in o2dlm lockres mastery(backport to 1.4)

2010-03-23 Thread Srinivas Eeda
informing the master directly. This is easily fixed by holding the dlm spinlock a little longer in the mastery handler. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmmaster.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/dlm

[Ocfs2-devel] o2net: log socket state changes

2010-03-30 Thread Srinivas Eeda
This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 334f231..6d0d228

[Ocfs2-devel] o2net: log socket state changes

2010-03-31 Thread Srinivas Eeda
This patch logs socket state changes that lead to socket shutdown. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/cluster/tcp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 334f231..8bda1ea

[Ocfs2-devel] o2net patch to lock socket shutdown message

2010-03-31 Thread Srinivas Eeda
The following patch logs socket shutdown messages. Below is the snippet of how the message looks (new message ends with ... shutdown, state #) [r...@el532p-3 ~]# mount /dev/hdb /vol1 Mar 31 11:14:18 el532p-3 kernel: connection to node el532p-2 (num 64) at 10.35.70.104: shutdown, state 8 Mar

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: resend deref to new master if recovery occures

2010-05-24 Thread Srinivas Eeda
thanks for doing this patch. I have a little comment, wondering if there could be a window where node B sent the lock info to node C as part of recovery and removed flag DLM_LOCK_RES_RECOVERING while dlm_thread was still purging it. In that case dlm_thread will still continue to remove it from

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: resend deref to new master if recovery occures

2010-05-24 Thread Srinivas Eeda
On 5/24/2010 7:50 PM, Wengang Wang wrote: delay deref message if DLM_LOCK_RES_RECOVERING is set (which means recovery got to the lockres before dlm_thread could), move the lockres to the end of the purgelist and retry later. If you meant checking before sending DEREF, it could cause a

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Srinivas Eeda
Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do not inform recovery master if DLM_LOCK_RES_DROPPING_REF is set and don't resend deref in this

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-03 Thread Srinivas Eeda
On 6/3/2010 6:43 PM, Wengang Wang wrote: Srini, On 10-06-03 18:06, Srinivas Eeda wrote: Comments inline On 6/3/2010 9:37 AM, Wengang Wang wrote: Changes to V1: 1 move the msleep to the second runs when the lockres is in recovery so the purging work on other lockres' can go. 2 do

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master

2010-06-05 Thread Srinivas Eeda
On 6/3/2010 10:37 PM, Wengang Wang wrote: Srini, On 10-06-03 19:17, Srinivas Eeda wrote: Can you please explain the idea of the new flag DLM_LOCK_RES_DE_DROP_REF :) If the idea of the fix is to address the race between purging and recovery, I am wondering DLM_LOCK_RES_DROPPING_REF

[Ocfs2-devel] [PATCH 1/1] ocfs2: o2dlm fix race in purge lockres and newlock (orabug 9094491)

2010-06-09 Thread Srinivas Eeda
. The fix is to add new state DLM_LOCK_RES_IN_USE which would prevent dlm_thread from purging the lockres and/or unhashing lockres. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmcommon.h |1 + fs/ocfs2/dlm/dlmlock.c |4 fs/ocfs2/dlm/dlmmaster.c |5

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: remove lockres from purge when a lock is added

2010-06-10 Thread Srinivas Eeda
Wengang, thanks for the patch. My comments are inline :) On 6/8/2010 7:38 AM, Wengang Wang wrote: dlm_thread(when purges a lockres) races with another thread that is running on dlmlock_remote(). dlmlock_remote() can add a lock to the blocked list of the lockres without taking dlm-spinlock.

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2: o2dlm fix race in purge lockres and newlock (orabug 9094491)

2010-06-14 Thread Srinivas Eeda
Please ignore this patch. I'll resend this patch along with dlm purge lockres for completeness. On 6/9/2010 7:07 PM, Srinivas Eeda wrote: dlm_thread sends a deref message to the master node. At the same time, another thread sends a new lock request to the master node. Since dlm_thread

[Ocfs2-devel] [PATCH 2/2] ocfs2: o2dlm fix race in purge lockres and newlock (orabug 9094491)

2010-06-15 Thread Srinivas Eeda
from the master lockres is not found This patch marks the lockres with a new state DLM_LOCK_RES_IN_USE which would protect lockres from dlm_thread purging it. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmcommon.h |1 + fs/ocfs2/dlm/dlmlock.c |4 fs/ocfs2

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: check dlm_state under spinlock

2010-06-15 Thread Srinivas Eeda
The lock order in this code causes dead lock, not caused by your patch. The lock order in dlm_query_join_handler is dlm_domain_lock -dlm-spinlock dead locks with .. dlm_lockres_put calls dlm_lockres_release while holding dlm-spinlock which calls dlm_put which gets dlm_domain_lock. So the

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: delay the migration when the lockres is in recovery

2010-06-16 Thread Srinivas Eeda
patch looks good, it fixes the umount code path which prevents a lockres from migrating if it needs to be recovered. I have few comments on the scenario you described. On 6/11/2010 3:25 AM, Wengang Wang wrote: Any comment on this patch? regards, wengang. On 10-05-25 15:59, Wengang Wang

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2 fix o2dlm dlm run purgelist

2010-06-17 Thread Srinivas Eeda
On 6/17/2010 1:32 AM, Joel Becker wrote: On Wed, Jun 16, 2010 at 06:44:43PM -0700, Sunil Mushran wrote: One way to skip a lockres in the purgelist is to list_del_init() and list_add_tail(). That simplifies the patch a lot. I have attached a quick dirty patch. See if that satisfies all the

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2 fix o2dlm dlm run purgelist

2010-06-17 Thread Srinivas Eeda
On 6/17/2010 7:48 AM, Sunil Mushran wrote: On 06/17/2010 01:35 AM, Srinivas Eeda wrote: On 6/17/2010 1:32 AM, Joel Becker wrote: On Wed, Jun 16, 2010 at 06:44:43PM -0700, Sunil Mushran wrote: One way to skip a lockres in the purgelist is to list_del_init() and list_add_tail

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2 fix o2dlm dlm run purgelist

2010-06-17 Thread Srinivas Eeda
Sunil, as of now, there is still a window in dlm_get_lock_resource, where it finds the lockres but it doesn't protect it from getting purged. Second patch fixes this by marking it in_use, can you please review that one as well. Thanks, --Srini On 6/17/2010 8:06 AM, Sunil Mushran wrote: On

Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: o2dlm fix race in purge lockres and newlock (orabug 9094491)

2010-06-18 Thread Srinivas Eeda
is adding more messiness to an area that is already very messy. Sunil On 06/15/2010 09:43 PM, Srinivas Eeda wrote: This patch fixes the following hole. dlmlock tries to create a new lock on a lockres that is on purge list. It calls dlm_get_lockresource and later adds a lock to blocked list

[Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist

2010-06-19 Thread Srinivas Eeda
it from getting reused. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmthread.c | 55 + 1 files changed, 26 insertions(+), 29 deletions(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index 11a6d1f..79d1ef6

[Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3

2010-06-22 Thread Srinivas Eeda
it from getting reused. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmthread.c | 76 -- 1 files changed, 33 insertions(+), 43 deletions(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index 11a6d1f..cb74689

[Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3

2010-06-22 Thread Srinivas Eeda
it from getting reused. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmthread.c | 79 +++-- 1 files changed, 33 insertions(+), 46 deletions(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index 11a6d1f..6822f9a

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3

2010-06-23 Thread Srinivas Eeda
Sunil, Joel, Wengang. Thanks for reviewing the patch and your comments. On 6/23/2010 10:00 AM, Sunil Mushran wrote: Signed-off-by: Sunil Mushransunil.mush...@oracle.com On 06/22/2010 10:48 PM, Srinivas Eeda wrote: There are two problems in dlm_run_purgelist 1. If a lockres is found

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3

2010-07-12 Thread Srinivas Eeda
Joel Becker wrote: On Tue, Jun 22, 2010 at 10:48:28PM -0700, Srinivas Eeda wrote: +if (!__dlm_lockres_unused) { +mlog(ML_ERROR, found lockres %s:%.*s: in use after deref\n, + dlm-name, res-lockname.len, res-lockname.name

[Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3

2010-07-12 Thread Srinivas Eeda
it from getting reused. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com Signed-off-by: Sunil Mushransunil.mush...@oracle.com --- fs/ocfs2/dlm/dlmthread.c | 79 +++-- 1 files changed, 33 insertions(+), 46 deletions(-) diff --git a/fs/ocfs2/dlm

[Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist (rev 3)

2010-07-19 Thread Srinivas Eeda
protecting it from getting reused. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com Acked-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/dlm/dlmthread.c | 80 +++-- 1 files changed, 34 insertions(+), 46 deletions(-) diff --git a/fs/ocfs2/dlm

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: avoid incorrect bit set in refmap on recovery master

2010-07-23 Thread Srinivas Eeda
thanks for making this patch, it looks good just few minor changes about comments On 7/23/2010 5:15 AM, Wengang Wang wrote: In the following situation, there remains an incorrect bit in refmap on the recovery master. Finally the recovery master will fail at purging the lockres due to the

[Ocfs2-devel] [PATCH 1/1] o2dlm: free block mles during shutdown

2010-09-20 Thread Srinivas Eeda
on master list after the node sent DLM_EXIT_DOMAIN_MSG to other nodes. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmcommon.h |1 + fs/ocfs2/dlm/dlmdomain.c |1 + fs/ocfs2/dlm/dlmmaster.c | 33 + 3 files changed, 35 insertions

[Ocfs2-devel] [PATCH] o2dlm: force free mles during dlm exit

2010-09-21 Thread Srinivas Eeda
as leaving. Only block mles are expected to be around, so we log ERROR for other mles but still free them. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmcommon.h |1 + fs/ocfs2/dlm/dlmdomain.c |1 + fs/ocfs2/dlm/dlmmaster.c | 34 ++ 3

[Ocfs2-devel] [PATCH 1/1] o2dlm: force free mles during dlm exit

2010-09-21 Thread Srinivas Eeda
as leaving. Only block mles are expected to be around, so we log ERROR for other mles but still free them. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmcommon.h |1 + fs/ocfs2/dlm/dlmdomain.c |1 + fs/ocfs2/dlm/dlmmaster.c | 40

[Ocfs2-devel] [PATCH 1/1] ocfs2: validate bg_free_bits_count after update

2010-10-01 Thread Srinivas Eeda
## Block#TotalUsed Free Contig Size 052803072 322564294965350 34202182074032 .. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/suballoc.c | 16 1 files changed, 16 insertions(+), 0

[Ocfs2-devel] [PATCH] ocfs2: validate bg_free_bits_count after update

2010-10-05 Thread Srinivas Eeda
## Block#TotalUsed Free Contig Size 052803072 322564294965350 34202182074032 .. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/suballoc.c | 16 1 files changed, 16 insertions(+), 0

[Ocfs2-devel] [PATCH 2/2] ocfs2/cluster: Add per-region debugfs file to show the elapsed time

2010-11-02 Thread Srinivas Eeda
From: Sunil Mushran sunil.mush...@oracle.com Mainline fa16655a622e7c0fda76ca5155db6efc86968c65 A per-region debugfs file, elapsed_time_in_ms, shows the time since the heartbeat timer was last armed. Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/cluster/heartbeat.c | 46

[Ocfs2-devel] backports to 1.4 from mainline

2010-11-02 Thread Srinivas Eeda
The following two patches are backports from mainline to 1.4. These patches create debugfs entry for heartbeat regions and to show elapsed time. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH 1/2] ocfs2/cluster: Create debugfs dir for heartbeat regions

2010-11-02 Thread Srinivas Eeda
From: Sunil Mushran sunil.mush...@oracle.com Mainline 0841ed580fe8a3e51ba9dbb133dafc787cce428f Signed-off-by: Sunil Mushran sunil.mush...@oracle.com --- fs/ocfs2/cluster/heartbeat.c | 27 +++ 1 files changed, 19 insertions(+), 8 deletions(-) diff --git

Re: [Ocfs2-devel] [PATCH] remove lockres from purge list when we are getting it for creating lock

2011-06-08 Thread Srinivas Eeda
I think I have seen this problem in ocfs2-1.2 and it was addressed by using a new state DLM_LOCK_RES_IN_USE. But we didn't merge into mainline as sunil suggested we need to look for a different approach http://oss.oracle.com/pipermail/ocfs2-devel/2010-June/006669.html

Re: [Ocfs2-devel] [PATCH] remove lockres from purge list when we are getting it for creating lock

2011-06-09 Thread Srinivas Eeda
+ spin_unlock(tmpres-spinlock); + spin_unlock(dlm-spinlock); lockres could still get added to purgelist at this point and we could still have the same problem? I think, here we need some mechanism that marks the lockres is in use that would protect it from adding to the

Re: [Ocfs2-devel] [PATCH 0/3] ocfs2: fix slow deleting

2011-07-07 Thread Srinivas Eeda
On 7/5/2011 11:17 PM, Sunil Mushran wrote: 2. All nodes have to scan all slots. Even live slots. I remember we did for a reason. And that reason should be in the comment in the patch written by Srini. When a node unlinks a file it inserts an entry into it's own orphan slot. If another node

Re: [Ocfs2-devel] [PATCH 0/3] ocfs2: fix slow deleting

2011-07-08 Thread Srinivas Eeda
node 2's orphan dir. This patch exists because that wasn't happening. On 7/7/2011 1:26 PM, Sunil Mushran wrote: On 07/07/2011 01:02 PM, Sunil Mushran wrote: On 07/06/2011 11:19 PM, Srinivas Eeda wrote: On 7/5/2011 11:17 PM, Sunil Mushran wrote: 2. All nodes have to scan all slots. Even live

[Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch

2012-01-28 Thread Srinivas Eeda
When ocfs2dc thread holds dc_task_lock spinlock and receives soft IRQ for I/O completion it deadlock itself trying to get same spinlock in ocfs2_wake_downconvert_thread The patch disables interrupts when acquiring dc_task_lock spinlock Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch

2012-01-29 Thread srinivas eeda
Hi Tao, thanks for reviewing. When ocfs2dc thread holds dc_task_lock spinlock and receives soft IRQ for I/O completion it deadlock itself trying to get same spinlock in ocfs2_wake_downconvert_thread could you please describe it in more detail? When ocfs2dc thread is running on a cpu and

[Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch

2012-01-30 Thread Srinivas Eeda
] Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlmglue.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 81a4cd2..d8552a5 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2

[Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch

2012-01-30 Thread Srinivas Eeda
] Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlmglue.c | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 81a4cd2..67af5db 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch

2012-01-30 Thread srinivas eeda
sorry ignore this patch, resent another one after adding the new line. On 1/30/2012 9:47 PM, Srinivas Eeda wrote: When ocfs2dc thread holds dc_task_lock spinlock and receives soft IRQ it deadlock itself trying to get same spinlock in ocfs2_wake_downconvert_thread. Below is the stack snippet

[Ocfs2-devel] [PATCH 1/1] o2dlm: fix NULL pointer dereference in o2dlm_blocking_ast_wrapper

2012-01-30 Thread Srinivas Eeda
[ocfs2_nodemanager] [a030aac8] o2net_rx_until_empty+0x762/0x90d [ocfs2_nodemanager] [81071802] worker_thread+0x14d/0x1ed Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmast.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/dlm

[Ocfs2-devel] [PATCH 3/3] ocfs2: modify reservation code to support discontigous localalloc

2012-05-07 Thread Srinivas Eeda
of m_bitmap_ext_arr. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/reservations.c | 41 ++--- fs/ocfs2/reservations.h |7 ++- 2 files changed, 40 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/reservations.c b/fs/ocfs2

[Ocfs2-devel] [PATCH 1/3] ocfs2: new structure to implment discontiguous local alloc bitmap

2012-05-07 Thread Srinivas Eeda
chunks. In best case there is only one record and increases as the filesystem gets fragmented. Number of records at a time are limited depending on the size of the bitmap and the max limit is defined by OCFS2_MAX_LOCAL_ALLOC_RECS. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2

[Ocfs2-devel] ocfs2 discontiguous localalloc patches

2012-05-07 Thread Srinivas Eeda
Hi all, can you please review following 3 patches that implement discontiguous localalloc bitmap support for ocfs2 file system. This feature helps applications that significantly fragment the filesystem. These fixes needs changes to ocfs2 tools as well. I am sending those patches for review

[Ocfs2-devel] [PATCH 2/3] ocfs2: implement discontiguous localalloc bitmap

2012-05-07 Thread Srinivas Eeda
This patch adds supporting functions and modifies localalloc code to implement discontiguous localalloc bitmap. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c | 523 - 1 files changed, 342 insertions(+), 181

Re: [Ocfs2-devel] ocfs2 discontiguous localalloc patches

2012-05-07 Thread Srinivas Eeda
Joel Becker wrote: On Mon, May 07, 2012 at 04:21:27PM -0700, Srinivas Eeda wrote: can you please review following 3 patches that implement discontiguous localalloc bitmap support for ocfs2 file system. This feature helps applications that significantly fragment the filesystem

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: implement discontiguous localalloc bitmap

2012-05-07 Thread Srinivas Eeda
Joel Becker wrote: On Mon, May 07, 2012 at 04:21:29PM -0700, Srinivas Eeda wrote: OH MY DOG NO. NEVER EVER DO THIS. You cannot update an old filesystem on the fly! What about other nodes that are running older versions of the software? They will crash or corrupt data

Re: [Ocfs2-devel] [PATCH] Fix waiting status race condition in dlm recovery

2012-05-25 Thread srinivas eeda
comments inline On 5/24/2012 10:53 PM, xiaowei...@oracle.com wrote: From: Xiaowei.Huxiaowei...@oracle.com when the master requested locks ,but one/some of the live nodes died, after it received the request msg and before send out the locks packages, the recovery will fall into endless

Re: [Ocfs2-devel] a bug about deadlock when enable quota on ocfs2

2012-07-16 Thread Srinivas Eeda
Hi Jan, thanks for helping. Jan Kara wrote: Hello, his comments: @ With those patches in, all other nodes will now queue downgrade of dentry @ locks to ocfs2_wq thread. Then Node 1 gets a lock is in use when it calls @ ocfs2_try_open_lock and so does other nodes and hence orphans lie

Re: [Ocfs2-devel] RFC: OCFS2 heartbeat improvements

2012-08-22 Thread srinivas eeda
On 8/22/2012 7:17 AM, Jie Liu wrote: Hi All, These days, I am investigating an issue regarding OCFS2 unexpected reboot in some real world use cases. This problem occurred when the network status goes south, when the disk IO load is too high, etc... I suspect it might caused by ocfs2 fencing

[Ocfs2-devel] ocfs2 discontig localalloc patches (ver 2)

2012-09-18 Thread Srinivas Eeda
Hi Joel, et al, sorry for the delay in resending discontiguous localalloc patches. Can you please review when you get a chance. I'll email the tools patches once kernel patches are approved. I came across two use cases where this feature will help. 1. On a customer site, after running an

[Ocfs2-devel] [PATCH 5/5] ocfs2 set min default contig localalloc size

2012-09-18 Thread Srinivas Eeda
will try to look for atleast that big of chunk. If it's not available then it reduces the size by half and retries. #define OCFS2_DEFAULT_LOCALALLOC_CHUNK_SIZE (128*1024) /* 128kb */ Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c | 28

[Ocfs2-devel] [PATCH 1/5] ocfs2: modifiy reservation code to support discontiguous allocations

2012-09-18 Thread Srinivas Eeda
of m_bitmap_ext_arr Callers should pass number of discontiguous chunks during ocfs2_resmap_restart and later call ocfs2_resmap_set_extent_size for every chunk. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c |4 +++- fs/ocfs2/reservations.c | 39

[Ocfs2-devel] [PATCH 3/5] ocfs2: new structure to implement discontiguous localalloc bitmap

2012-09-18 Thread Srinivas Eeda
and as the filesystem gets fragmented you may see multipe records. This feature can be enabled/disabled when the file system is offline. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c | 22 ++-- fs/ocfs2/ocfs2.h |7 + fs/ocfs2/ocfs2_fs.h

[Ocfs2-devel] [PATCH 4/5] ocfs2: implement discontiguous localalloc bitmap

2012-09-18 Thread Srinivas Eeda
This patch adds code to support discontiguous localalloc bitmap. At any given time there can be a combination of volumes that have discontigous feature enabled or disabled. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c | 478

[Ocfs2-devel] [PATCH 2/5] ocfs2: move ocfs2-local-alloc-inode to ocfs2-super

2012-09-18 Thread Srinivas Eeda
ocfs2_local_alloc_inode is used in multiple functions. It is convenient if we move ocfs2_local_alloc_inode to ocfs2 super. Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/localalloc.c | 53 - fs/ocfs2/ocfs2.h |1 + 2

Re: [Ocfs2-devel] [PATCH] ocfs2: resend master request when lost connection with someone

2013-05-31 Thread Srinivas Eeda
On 05/31/2013 03:38 AM, Xue jiufei wrote: Hi, Xiaowei It's OK to simlify the patch just as you did. But we don't want to resend master request to all others nodes in consideration of network traffic. So we record those maybe down nodes in down_nodemap. 于 2013/5/28 14:12, xiaowei.hu 写道: Hi,

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: ocfs2 dlm umount skip migrating lockres

2013-09-11 Thread Srinivas Eeda
is unset by migrate handler thread. umount thread will ultimately migrate this lockres during another pass of the lockres hash list. Signed-off-by: Tariq Saeed tariq.x.sa...@oracle.com Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com --- fs/ocfs2/dlm/dlmmaster.c |4 1 files

Re: [Ocfs2-devel] What's the need of OCFS2_INODE_MAYBE_ORPHANED?

2014-01-08 Thread Srinivas Eeda
Hi Goldwyn, On 01/08/2014 04:12 PM, Goldwyn Rodrigues wrote: Hi, From the comments in fs/ocfs2/inode.h:90 it seems, this was used in legacy ocfs2 systems when a node received unlink votes. Since unlink votes has been done away with and replaced with open locks, is this flag still required?

  1   2   >