[PATCH 0/5] Prototype to handle asynchronized callback

Hi, These patches are the prototype to handle the asynchronized callback for AtServer. During the callback function execution period, GAtServer waits for its result and then process next command. At the same time, the server is capable to accept new data comes from the client side and cache them

[PATCH 4/5] Add register S3-S5 basic command callbacks

--- gatchat/gatserver.c | 162 +++ 1 files changed, 162 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 5d2a036..9d4d221 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -294,6 +294,159 @@

Re: [PATCH 0/4] add PPP_DEAD and PPP_TERMINATE support

Hi Kristen, These patches complete implementation of the PPP_DEAD and PPP_TERMINATE phases, as well as allow this to be tested via gsmdial. Kristen Carlson Accardi (4): remove unneeded debug statement add tracing for PPP terminate path separate memory cleanup from PPP shutdown

[PATCH 5/5] Add register ATE and other basic command callbacks

--- gatchat/gatserver.c | 195 +- 1 files changed, 191 insertions(+), 4 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 9d4d221..06b5751 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -302,10 +302,10 @@

[PATCH 1/7] Unify some macro names of ber-tlv and comprehension tlv

--- src/stkutil.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index e66b4c0..23c6a3f 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -54,7 +54,7 @@ enum stk_command_type { STK_COMMAND_TYPE_GET_INPUT =

[PATCH 2/7] Make the function to parse mcc and mnc public

--- src/simutil.c |6 +++--- src/simutil.h |1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index d9383b7..9fb111f 100644 --- a/src/simutil.c +++ b/src/simutil.c @@ -538,7 +538,7 @@ static char *sim_network_name_parse(const unsigned char

[PATCH 6/7] Use common bool parser to reimplement immediate response object

--- src/stkutil.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ecf1301..4e42ae4 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -637,18 +637,8 @@ static gboolean parse_dataobj_icon_id(struct comprehension_tlv_iter

[PATCH 7/7] Add parser for help request objects

--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 4e42ae4..9a91a25 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -611,6 +611,14 @@ static gboolean parse_dataobj_imei(struct comprehension_tlv_iter *iter,

[PATCH 3/7] Add parser for location information objects

--- src/stkutil.c | 36 src/stkutil.h | 11 +++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9c83f49..d67c5c4 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -519,6 +519,40 @@ error:

Re: [PATCH 1/7] Unify some macro names of ber-tlv and comprehension tlv

Hi Yang, --- src/stkutil.h |8 1 files changed, 4 insertions(+), 4 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/7] Make the function to parse mcc and mnc public

Hi Yang, --- src/simutil.c |6 +++--- src/simutil.h |1 + 2 files changed, 4 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/7] Add parser for location information objects

Hi Yang, --- src/stkutil.c | 36 src/stkutil.h | 11 +++ 2 files changed, 47 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 4/7] Add parser for imei objects

Hi Yang, --- src/stkutil.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) Patch has been applied, with a small fix afterwards. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 6/7] Use common bool parser to reimplement immediate response object

Hi Yang, --- src/stkutil.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 7/7] Add parser for help request objects

Hi Yang, --- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/5] Refactor the command parsing framework

Hi Zhenhua, --- gatchat/gatserver.c | 182 +++--- gatchat/gatserver.h | 7 ++- 2 files changed, 133 insertions(+), 56 deletions(-) - at_command_notify(server, buf, prefix, type); + notify = at_node_new(server, buf, prefix, type);

[PATCH] ppp: change debug output to include control protocol prefix

--- gatchat/ppp_cp.c | 12 ++-- gatchat/ppp_cp.h | 10 +- gatchat/ppp_lcp.c | 12 ++-- gatchat/ppp_net.c | 12 ++-- 4 files changed, 35 insertions(+), 11 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index 75b3bec..137f6b9 100644 ---

Re: [PATCH] ppp: change debug output to include control protocol prefix

Hi Kristen, gatchat/ppp_cp.c | 12 ++-- gatchat/ppp_cp.h | 10 +- gatchat/ppp_lcp.c | 12 ++-- gatchat/ppp_net.c | 12 ++-- 4 files changed, 35 insertions(+), 11 deletions(-) patch has been applied. Thanks. Regards Marcel

[PATCH 1/2] ppp: allow empty secret for chap challenge

Just do a checksum over the identifier if we have an empty password for our chap secret. --- gatchat/ppp_auth.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c index 6c3913e..95b2f96 100644 --- a/gatchat/ppp_auth.c +++

[PATCH 2/2] ppp: send PPP_FAIL when authentication fails

--- gatchat/ppp_auth.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c index 95b2f96..fe3c501 100644 --- a/gatchat/ppp_auth.c +++ b/gatchat/ppp_auth.c @@ -128,7 +128,8 @@ static void chap_process_failure(struct auth_data *data,

RE: [PATCH 1/5] Refactor the command parsing framework

Hi Denis, Denis Kenzior wrote: Hi Zhenhua, --- gatchat/gatserver.c | 182 +++--- gatchat/gatserver.h | 7 ++- 2 files changed, 133 insertions(+), 56 deletions(-) -at_command_notify(server, buf, prefix, type); +notify =

Re: [PATCH 1/5] Refactor the command parsing framework

Hi Zhenhua Err, OK stop right there. This is really way too complicated. How about we simply set a flag before calling at_command_notify. If after executing it send_final or send_ext_final response has been sent, then we continue processing, otherwise we restart when send_ext_final or