Re: [Patch]: Reducing clutter in the src directory + Introduction of HACKING file

Naresh Mehta nareshte...@gmail.com writes: Sorry for the size of the patch. It basically increased because of the moving around of files. Hope it is not much of a problem. A git tip of the day: git format-patch has switch -M which enables rename detection. It should make patches like this a

[PATCH] Took ownership of the Status report task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 758778b..c20678e 100644 --- a/TODO +++ b/TODO @@ -108,6 +108,7 @@ SMS Priority: Medium Complexity: C4 + Owner: Pasi Miettinen pasi.miettinen at ixonos.com SIM / SIM File system --

VS: [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

Hi Denis, - { SendMessage,ss, , sms_send_message, + { SendMessage,ssb, , sms_send_message, G_DBUS_METHOD_FLAG_ASYNC }, { } }; I don't like this being an argument to

[PATCH] Flight mode owner.

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 758778b..3f94753 100644 --- a/TODO +++ b/TODO @@ -193,6 +193,7 @@ Flight Mode Complexity: C4 Priority: High + Owner: Pekka Pessi pekka.pe...@nokia.com GPRS -- 1.6.3.3

VS: [PATCH 04/11] Changes for SMS statur report.

On Thu, 2010-05-27 at 12:54 +0200, ext pasi.mietti...@ixonos.com wrote: diff --git a/include/sms.h b/include/sms.h index daaec37..c007675 100644 --- a/include/sms.h +++ b/include/sms.h @@ -54,7 +54,7 @@ struct ofono_sms_driver { void ofono_sms_deliver_notify(struct ofono_sms *sms,

Re: [PATCH] Flight mode owner.

Hi Pekka, --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Took ownership of the Status report task

Hi Pasi, --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [RFC patches 02/13] sms_send_message: add a short roadmap

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- src/sms.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 3a1cff0..594481e 100644 --- a/src/sms.c +++ b/src/sms.c @@ -398,6 +398,19 @@ static

Re: [PATCH 5/6] Change hfpmodem's header define

Hi Gustavo, -#ifndef __BLUETOOTH_H__ -#define __BLUETOOTH_H__ +#ifndef __HFPMODEM_H__ +#define __HFPMODEM_H__ This one should actually be removed altogether. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [RFC patches 03/13] documentation: add note about referencing standards

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- doc/standards.txt |8 1 files changed, 8 insertions(+), 0 deletions(-) create mode 100644 doc/standards.txt diff --git a/doc/standards.txt b/doc/standards.txt new file mode 100644 index

Re: [RFC patches 01/13] Update .gitignore to ignore cscope databases and backup files

On Fri, May 28, 2010 at 11:08, Marcel Holtmann mar...@holtmann.org wrote: Hi Inaky, diff --git a/.gitignore b/.gitignore index 1ce7067..d7e9254 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +*~ believe it or not, I always left that out on purpose. I like having git status

Re: [RFC patches 05/13] util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com These have been stolen from the Linux kernel source; come pretty handy to make build-time consistency checks and thus avoid run-time surprises. --- src/util.h | 29 + 1 files changed, 29

Re: [PATCH 6/6] Bluetooth DUN modem prototype

Hi Gustavo, Add a still dummy DUN code, now it can only creates and removes modems. The DUN plugin follows the HFP one a lot, the is basics a copy of some HFP plugin's parts. Me and Marcel talked about this a few weeks ago, and we decided that we'd prefer the DUN client to be a separate

Re: [RFC patches 06/13] smutil.h: add missing header file dependencies

Hi Inaky, diff --git a/src/smsutil.h b/src/smsutil.h index 469a49e..356ec5d 100644 --- a/src/smsutil.h +++ b/src/smsutil.h @@ -18,6 +18,14 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * */ +#ifndef __smsutil_h__ +#define __smsutil_h__ please

Re: [RFC patches 10/13] doc: explain debugging options to -d, add a pointer in -h to manpage

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com Modified HACKING and man page to have more formation on what are the debugging options and how to enable them. --- HACKING | 10 ++ doc/ofonod.8 |5 - src/main.c |4 +++- 3 files changed,

Re: [RFC patches 11/13] automake: fix installation of udev rules in VPATH builds

Hi Inaky, When the build directory is different than the source directory, we need to specify the source prefix to the original file we are copying. --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index ed13346..31c157c

Re: [RFC patches 04/13] sms_assembly_add_fragment_backup: clarify how insertion spot is found

Hi Inaky, + /* Iterate over the bitmap to find in which position + * should the fragment be inserted -- basically we + * walk each bit in the bitmap until the bit we care + * about (offset:bit) and count which are stored -- + *

Re: [RFC patches 12/13] SMS: introduce message ID API

Hi Inaky, +/** + * Create a random UUID + * + * \param msg_id Descriptor + * + * \internal + * + * Crams the msg_id ID buffer with random 32-bit numbers; because we + * use a byte based buffer, we play the cast to guint32 trick (as that + * is what g_random_int() returns). + */ can we

Re: [RFC patches 06/13] smutil.h: add missing header file dependencies

Hi Inaky, +#include glib/gtypes.h +#include glib/gslist.h +#include glib/gmessages.h +#include glib/gchecksum.h Isn't it sufficient to just add glib/glib.h here? Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [RFC patches 02/13] sms_send_message: add a short roadmap

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- src/sms.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) Applied with s/D-BUS/D-Bus Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [RFC patches 07/13] write_file: make transaction-safe

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com write_file(), as written wasn't transaction-safe; a crash bewtween a file being open and the buffer being written before a safe close would leave the file with a set of undetermined contents. Modified to the file is

Re: [RFC patches 08/13] storage: add __attribute__((format)) to {write, read}_file() for printf-like variable arg verification

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- src/storage.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Patch has been applied with a modified commit message. Thanks, -Denis ___ ofono mailing list

Re: [RFC patches 09/13] Add function doc headers to ofono_sms_{create, register}

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com Signed-off-by: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com We don't use signed off lines here, please don't include them in the future. Patch has been applied with a modified commit message. Thanks, -Denis

Re: [RFC patches 11/13] automake: fix installation of udev rules in VPATH builds

Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com When the build directory is different than the source directory, we need to specify the source prefix to the original file we are copying. Patch has been applied with a modified commit message. Thanks, -Denis

[PATCH] Volunteering for a task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index d949210..25b6688 100644 --- a/TODO +++ b/TODO @@ -51,6 +51,7 @@ SMS Priority: High Complexity: C2 + Owner: Aki Niemi aki.ni...@nokia.com - Smart Messaging Service. This is a separate

Re: [PATCH 01/20] stkutil: Add Set Up Call response builder

Hi Andrew, --- src/stkutil.c | 37 + src/stkutil.h |9 + 2 files changed, 46 insertions(+), 0 deletions(-) All 20 patches in this series have now been pushed with some style fixes in between. Thanks, -Denis

Re: [PATCH 02/11] Made needed changes to at_cds_notify() for status report and corrected at_cmgl_cpms_cb() to meet the ISO standard.

Hi Pasi, From: Pasi Miettinen pasi.mietti...@ixonos.com --- drivers/atmodem/sms.c | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index 27de77b..a1c885b 100644 --- a/drivers/atmodem/sms.c

Re: [PATCH 03/11] Enable status report.

Hi Pasi, From: Pasi Miettinen pasi.mietti...@ixonos.com --- src/smsutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index e634764..2679cc2 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2596,7 +2596,7 @@ GSList

Re: [PATCH 04/11] Changes for SMS statur report.

Hi Pasi, From: Pasi Miettinen pasi.mietti...@ixonos.com --- include/sms.h |2 +- src/sms.c | 124 ++--- 2 files changed, 119 insertions(+), 7 deletions(-) diff --git a/include/sms.h b/include/sms.h index daaec37..c007675

Re: [PATCH 07/11] Removed Siemens TC65 specific code.

Hi Pasi, From: Pasi Miettinen pasi.mietti...@ixonos.com --- drivers/atmodem/sms.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index a1c885b..adaf4f2 100644 --- a/drivers/atmodem/sms.c +++

Re: [PATCH 11/11] Style corrections.

Hi Pasi, From: Pasi Miettinen pasi.mietti...@ixonos.com --- src/sms.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) Style correction patches for code introduced in the same series should simply be squished into the previous changes. This makes it