How about offering a raw way for SMS

Hi all, Ofono stack encodes SMS before send it. User may need send some special SMS. Such as send a v-card via SMS. It need to add user data header to indicate it is a v-card. Ofono currently does not support this feature. How about offering an API for user to sending raw PDU directly? such

Re: How about offering a raw way for SMS

Hi Caiwen, please don't piggy-back on other threads. For new questions/discussion, please start a brand new thread. Ofono stack encodes SMS before send it. User may need send some special SMS. Such as send a v-card via SMS. It need to add user data header to indicate it is a v-card. Ofono

RE: Crash in at_gprs_context_remove()

Hi, Zhang, Zhenhua wrote: Hi Kalle, Kalle Valo wrote: Hi, (gdb) bt #0 0x7790b642 in IA__g_atomic_int_exchange_and_add (atomic=0x0, val=-1) at /build/buildd/glib2.0-2.25.8/glib/gatomic-gcc.c:30 #1 0x004325a3 in g_at_ppp_unref (ppp=0x0) at gatchat/gatppp.c:448 #2

Re: [PATCH 3/5] test-server: Add PPP server support

Hi Zhenhua, static void server_destroy(gpointer user) @@ -706,15 +825,11 @@ static void server_destroy(gpointer user) static void set_raw_mode(int fd) { - struct termios options; - - tcgetattr(fd,options); - - /* Set TTY as raw mode to disable echo back of input characters -

Re: [PATCH] Voicecall gaps.

On 06/30/2010 08:01 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessipekka.pe...@nokia.com Missing voicecall functionality pieces from tp-ring point-of-view. --- TODO | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index

Re: [PATCH 3/3] huawei: Remove call meter support for EM770

Hi Zhenhua, EM770W returns COMMAND NOT SUPPORT when we send AT+CCWE=1 to initialize call meter atom. So disable it. when re-doing patch 2/3 then please fix this properly so that this extra patch is not needed anymore. Regards Marcel ___ ofono

Re: [PATCH 1/3] stkutil: display text attributes as html

Hi Kristen, + +char *stk_text_to_html(char *text, int text_len, + const unsigned char *attrs, int attrs_len) +{ + GString *string = g_string_sized_new(text_len + 1); + int formats[257]; /* maximum number of chars in text + 1 */ + int pos = 0, i, j,

Re: [PATCH 1/3] stkutil: display text attributes as html

On Thu, 01 Jul 2010 11:30:07 -0500 Denis Kenzior denk...@gmail.com wrote: + start = attrs[i++]; + len = attrs[i++]; + code = attrs[i++]; You might want to be extra paranoid here that attrs_len is a multiple of 4. attrs_len does not have to be a multiple

Re: [PATCH 1/3] stkutil: display text attributes as html

Hi Kristen, On 07/01/2010 01:29 PM, Kristen Carlson Accardi wrote: On Thu, 01 Jul 2010 11:30:07 -0500 Denis Kenzior denk...@gmail.com wrote: + start = attrs[i++]; + len = attrs[i++]; + code = attrs[i++]; You might want to be extra paranoid here that

Re: [PATCH 1/9] stk: Utilities for proactive command/envelope handling

Hi Andrew, @@ -43,10 +43,61 @@ struct ofono_stk { const struct ofono_stk_driver *driver; void *driver_data; struct ofono_atom *atom; + struct stk_command *pending_cmd; + void (*cancel_cmd)(struct ofono_stk *stk); I notice that you remove cancel_cmd in a later

Re: [PATCH 4/9] Make sim operations return sim error codes to core.

Hi Andrew, On 06/29/2010 05:14 AM, Andrzej Zaborowski wrote: --- drivers/atmodem/stk.c | 20 include/types.h |1 + When you're touching more than two directories, always break the patches up / directory. In this case resubmit two patches, one for types.h and

Re: [PATCH 5/9] stk: Handle ENVELOPEs in a queue, retry on sim busy.

Hi Andrew, + + gboolean envelope_q_busy; In my opinion we can get rid of this variable. The SMS tx_queue does almost the same thing without requiring such a variable. + GQueue *envelope_q; +}; + +struct envelope_op { + struct stk_envelope e; + int retries; + void

Re: [PATCH 1/3] stkutil: display text attributes as html

On 07/01/2010 03:54 PM, Kristen Carlson Accardi wrote: On Thu, 01 Jul 2010 13:54:16 -0500 Denis Kenzior denk...@gmail.com wrote: Hi Kristen, On 07/01/2010 01:29 PM, Kristen Carlson Accardi wrote: On Thu, 01 Jul 2010 11:30:07 -0500 Denis Kenzior denk...@gmail.com wrote: + start

[PATCH 01/10] stkutil: display text attributes as html

--- src/stkutil.c | 219 + src/stkutil.h |2 + 2 files changed, 221 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6f072e7..5da356c 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5819,3 +5819,222 @@

[PATCH 00/10] html text attributes patches

Incorporated feedback from last review. Added requested unit tests. Kristen Carlson Accardi (10): stkutil: display text attributes as html test-stkutil: add unit test for html text attributes test-stkutil: add html attribute test for Display Text tests test-stkutil: add html attribute

[PATCH 02/10] test-stkutil: add unit test for html text attributes

--- unit/test-stkutil.c | 76 +++ 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 8b7e254..57e894b 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -472,6 +472,22 @@

[PATCH 03/10] test-stkutil: add html attribute test for Display Text tests

--- unit/test-stkutil.c | 204 +++ 1 files changed, 204 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 57e894b..bc0e018 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -524,6 +524,7 @@

[PATCH 04/10] test-stkutil: add html attribute tests for get_inkey_test

--- unit/test-stkutil.c | 69 +++ 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index bc0e018..3b19227 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -964,6 +964,7 @@

[PATCH 06/10] test-stkutil: add html attribute tests for play_tone_test

--- unit/test-stkutil.c | 69 +++ 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 4d22d94..3ab3528 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -3319,6 +3319,7 @@

[PATCH 05/10] test-stkutil: add html attribute tests for get_input_test

--- unit/test-stkutil.c | 69 +++ 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 3b19227..4d22d94 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -1938,6 +1938,7 @@

[PATCH 07/10] test-stkutil: add html attribute test for setup_menu_test

--- unit/test-stkutil.c | 50 ++ 1 files changed, 38 insertions(+), 12 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 3ab3528..fca4526 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -4644,6 +4644,7 @@

[PATCH 08/10] test-stkutil: add html attribute test for select_item_test

--- unit/test-stkutil.c | 69 +++ 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index fca4526..ada02c0 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -5927,6 +5927,7 @@

[PATCH 09/10] test-stkutil: add html attribute tests for setup idle mode tests

--- unit/test-stkutil.c | 69 +++ 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index ada02c0..74e2ec2 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -13719,6 +13719,7 @@

[PATCH 10/10] test-stkutil: add html_attr_test for special chars

--- unit/test-stkutil.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 74e2ec2..c2e1327 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -22383,6 +22383,16 @@ static struct html_attr_test

Re: [PATCH 1/3] stkutil: display text attributes as html

Hi Andrew, On 07/01/2010 05:10 PM, Andrzej Zaborowski wrote: Hi On 1 July 2010 18:30, Denis Kenzior denk...@gmail.com wrote: +char *stk_text_to_html(char *text, int text_len, + const unsigned char *attrs, int attrs_len) +{ + GString *string =

Re: [PATCH 1/3] stkutil: display text attributes as html

On 2 July 2010 00:35, Denis Kenzior denk...@gmail.com wrote: Hi Andrew, On 07/01/2010 05:10 PM, Andrzej Zaborowski wrote: Hi On 1 July 2010 18:30, Denis Kenzior denk...@gmail.com wrote: +char *stk_text_to_html(char *text, int text_len, +                             const unsigned char

Re: [PATCH 1/3] stkutil: display text attributes as html

On Thu, 01 Jul 2010 16:15:35 -0500 Denis Kenzior denk...@gmail.com wrote: On 07/01/2010 03:54 PM, Kristen Carlson Accardi wrote: On Thu, 01 Jul 2010 13:54:16 -0500 Denis Kenzior denk...@gmail.com wrote: Hi Kristen, On 07/01/2010 01:29 PM, Kristen Carlson Accardi wrote: On Thu, 01

Re: [PATCH 1/3] stkutil: display text attributes as html

Hi Kristen, Then this code is incorrect, as it handles len 3 attrs only at the end of the array. Also please note that SIM Toolkit Text Attributes are always coded on 4 bytes (see 102.223 Section 8.72 for details). You might want to assume 4 byte alignment or invent a data structure for

Re: [PATCH 01/10] stkutil: display text attributes as html

Hi Kristen, +#define STK_TEXT_FORMAT_INIT -1 I'd really prefer 0x here +char *stk_text_to_html(const char *text, int text_len, + const unsigned char *attrs, int attrs_len) +{ I think that text_len is not required, this function can figure it out itself by

Re: [PATCH 1/3] stkutil: display text attributes as html

Hi Kristen, On 07/01/2010 06:05 PM, Kristen Carlson Accardi wrote: On Thu, 01 Jul 2010 18:08:47 -0500 Denis Kenzior denk...@gmail.com wrote: Hi Kristen, Then this code is incorrect, as it handles len 3 attrs only at the end of the array. Also please note that SIM Toolkit Text Attributes

RE: [PATCH 2/3] huawei: Add Huawei EM770 modem support

Hi Marcel, Marcel Holtmann wrote: Hi Zhenhua Zhang, Huawei EM770W is a 3G WCDMA modem that supports HSPA/UMTS/EDGE/GPRS/GSM data service and WCDMA/GSM short message services. It also has voice call capability that supports both 2G and 3G network. --- plugins/huawei.c| 31

Re: [PATCH 5/9] stk: Handle ENVELOPEs in a queue, retry on sim busy.

Hi, On 1 July 2010 21:57, Denis Kenzior denk...@gmail.com wrote: Hi Andrew, + +     gboolean envelope_q_busy; In my opinion we can get rid of this variable.  The SMS tx_queue does almost the same thing without requiring such a variable. True, I didn't think of it. +     GQueue

[PATCH 1/2] huawei: Remove existing Huawei EM770 plugin

--- Makefile.am |3 - plugins/em770.c | 229 --- plugins/ofono.rules |2 - plugins/udev.c | 26 -- 4 files changed, 0 insertions(+), 260 deletions(-) delete mode 100644 plugins/em770.c diff --git a/Makefile.am

Help regarding understanding of ofono atoms

Hi all, i am trying to understand the ofono source code and structure . but i am not able find the exact usage of ofono atoms and logical definition of ofono atoms , can somebody please help by giving some info about ofono atoms. Thanks, ssk.