[PATCH 01/14] stk: Utilities for proactive command/envelope handling.

--- include/stk.h |2 + src/stk.c | 173 +++-- 2 files changed, 157 insertions(+), 18 deletions(-) diff --git a/include/stk.h b/include/stk.h index ad3f6c5..638da9c 100644 --- a/include/stk.h +++ b/include/stk.h @@ -65,6 +65,8 @@ void

[PATCH 02/14] mbmmodem: End session on *STKEND.

--- drivers/mbmmodem/stk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/stk.c b/drivers/mbmmodem/stk.c index 77bd7b5..613b257 100644 --- a/drivers/mbmmodem/stk.c +++ b/drivers/mbmmodem/stk.c @@ -179,6 +179,9 @@ static void stkn_notify(GAtResult

[PATCH 03/14] stk: Handle the More Time proactive command as a nop.

--- src/stk.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 66b0a6b..ba66fe2 100644 --- a/src/stk.c +++ b/src/stk.c @@ -143,6 +143,15 @@ static void stk_command_cb(const struct ofono_error *error, void *data)

[PATCH 04/14] Add OFONO_ERROR_TYPE_SIM for negative SIM statuses.

Expected value of the .error field is status word 1 and status word 2 in bits 8:15 and 0:7 of the field. --- include/types.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index 2b154f0..6098cba 100644 --- a/include/types.h +++

[PATCH 05/14] atmodem: Make sim operations return sim error codes.

--- drivers/atmodem/sim.c | 32 +--- drivers/atmodem/stk.c | 20 2 files changed, 37 insertions(+), 15 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 2b4a8c6..d5d5ff9 100644 --- a/drivers/atmodem/sim.c +++

[PATCH 06/14] stk: Handle ENVELOPEs in a queue, retry on sim busy.

Some envelope types need to be retried when sim reports busy status. Then envelopes such as Event Download need to be returned in the order of the event occurences, so need to be handled in a queue. --- src/stk.c | 91 +++- 1 files

[PATCH 08/14] stk: Handle the Send SMS proactive command.

--- src/stk.c | 104 + 1 files changed, 104 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index b4b65c1..a57342a 100644 --- a/src/stk.c +++ b/src/stk.c @@ -34,6 +34,7 @@ #include ofono.h +#include common.h

[PATCH 09/14] Add Dbus interface names for STK.

--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index d988760..d959754 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -49,6 +49,8 @@ extern C { #define OFONO_VOICECALL_MANAGER_INTERFACE org.ofono.VoiceCallManager

[PATCH 11/14] sktutil: Use the Mandatory flag in parse_dataobj.

We need to look at the Mandatory flag and not at the Minimum flag when parsing CTLVs. The Minimum flag is important when encoding CTLVs because CR bit is set according to it. --- src/stkutil.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/stkutil.c

[PATCH 12/14] stkutil: Timer Value is conditional, not optional.

Make the parser check that the value is present when necessary, so that stk.c doesn't have to check this. --- src/stkutil.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index d2cd126..94ff182 100644 --- a/src/stkutil.c +++

[PATCH 10/14] stk: Handle the Set Up Idle Text proactive command.

This adds a SimToolkit dbus interface with just one property (IdleModeText). --- src/stk.c | 98 + 1 files changed, 98 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index a57342a..940c65d 100644 --- a/src/stk.c +++

[PATCH 13/14] stk: Handle the Timer Management proactive command.

--- src/stk.c | 165 + 1 files changed, 165 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 940c65d..6edce2c 100644 --- a/src/stk.c +++ b/src/stk.c @@ -31,6 +31,7 @@ #include glib.h #include gdbus.h #include

[PATCH 14/14] stk: Handle the Poll Interval proactive command.

--- src/stk.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 6edce2c..e77c723 100644 --- a/src/stk.c +++ b/src/stk.c @@ -534,6 +534,47 @@ static gboolean handle_command_timer_mgmt(const struct

[PATCH 03/15] emulator: Add status watches for ofono emulator

The status watches monitor the emulator activities. Other atoms like gprs, netreg could register notification to watch emulator status changes. --- include/emulator.h |6 + src/emulator.c | 55 src/ofono.h| 11 ++

[PATCH 06/15] emulator: Add emulator status watches in gprs atom

Add dun_watch to watch emulator status update in gprs atom. So that gprs atom could get notified when we get request to create new PPP connection from DUN client; --- src/gprs.c | 63 1 files changed, 63 insertions(+), 0 deletions(-)

[PATCH 04/15] emulator: Add get properities for emulator

oFono properties: Powered: Whether the emulator is powered on. Type: Type could be one of supported emulator type, default is DUN. --- src/emulator.c | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index

[PATCH 07/15] emulator: Add emulator status watches in netreg

Add dun_watch to watch emulator status update for netreg atom. --- src/network.c | 58 + 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index c6410a8..b9f0a08 100644 --- a/src/network.c +++

[PATCH 09/15] emulator: Implement dialing up for DUN

It handles client ATD*99# request and complete GPRS connection. Pass client IP address through IPCP packet to client side. --- include/emulator.h | 34 src/emulator.c | 226 2 files changed, 260 insertions(+), 0 deletions(-)

[PATCH 10/15] emulator: Add emulator dial up support in GPRS

Implement dial up support in GPRS atom. --- src/gprs.c | 439 +++- 1 files changed, 437 insertions(+), 2 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index dd58c51..cb83e23 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -39,6 +39,7 @@

[PATCH 12/15] emulator: Watch GPRS status changes

Watch GPRS status changes to notify DUN client any unsolicited result, like +CGREG status changes. --- include/gprs.h | 11 +++ src/emulator.c | 88 src/gprs.c | 64 3 files changed,

[PATCH 13/15] emulator: Watch netreg status changes

Watch netreg status changes to notify DUN client any unsolicited result, like +CREG status changes. --- src/emulator.c | 94 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index

[PATCH 14/15] gprs: Add DUN +CGATT support in gprs atom

DUN client may request us to attach/deattach GPRS network. In such case, use gprs_netreg_update to update gprs status. --- src/gprs.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 3ed056a..1f9e396 100644 --- a/src/gprs.c +++

Re: [PATCH 11/15] emulator: Register mandatory AT command handlers

On Wed, 7 Jul 2010 18:01:48 +0800, Zhenhua Zhang zhenhua.zh...@intel.com wrote: +static void cfun_cb(GAtServerRequestType type, GAtResult *cmd, + gpointer user_data) +{ + struct ofono_emulator *e = user_data; + char buf[50]; + + switch

Re: [PATCH 11/15] emulator: Register mandatory AT command handlers

Hi Remi, +static void cfun_cb(GAtServerRequestType type, GAtResult *cmd, + gpointer user_data) +{ + struct ofono_emulator *e = user_data; + char buf[50]; + + switch (type) { + case G_AT_SERVER_REQUEST_TYPE_SUPPORT: +

Re: [PATCH] Introduction of HACKING file in phonesim

Denis Kenzior denk...@... writes: Hi Naresh, Signed-off-by: Naresh Mehta nareshte...@... We don't use Signed-off-by in ofono / phonesim. Fixed it for you, but please keep that in mind next time. --- HACKING | 102

Re: FYI: Emergency calls with MBM modem

Hi Marcel, 2010/7/7 Marcel Holtmann mar...@holtmann.org: Hi Pekka, I just did some emergency calls in our lab with the Ericsson MBM modem (3507g). The modem firmware has the voice calls enabled, even while there is no audio input/output from the modem (as far as I know). Main results are:

Re: FYI: Emergency calls with MBM modem

Hi Pekka, However, 27.007 implies (see, for instance, commentary on +CPIN) that things the atmodem voicecall driver takes as granted (+CLCC, +CHLD) do not necessary work when there is no SIM or SIM is missing PIN code. +CIND polling is only thing promised by spec (however, it did not work on

Re: [PATCH 2/2] Clarified VoiceCallManager.SendTones documentation.

Hi Pekka, On 07/06/2010 12:17 PM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- doc/voicecallmanager-api.txt |8 1 files changed, 4 insertions(+), 4 deletions(-) I applied this patch with a slightly reworded commit header. Regards, -Denis

Re: [PATCH 1/2] Voicecall gaps.

On 07/06/2010 12:17 PM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Missing voicecall functionality pieces from tp-ring point-of-view. --- TODO | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) Applied with a modified commit

Re: FYI: Emergency calls with MBM modem

Hi Pekka, On 07/07/2010 11:40 AM, Pekka Pessi wrote: 2010/7/7 Denis Kenzior denk...@gmail.com: Main results are: - emergency calls are not possible in offline mode (CFUN=4), ATD112; returns NO DIALTONE That was expected, do we have a solution in mind on how to do emergency dialing in

Re: [SMS D-Bus 08/23] export sms_assembly_encode_address

Hi Inaky, void sms_assembly_expire(struct sms_assembly *assembly, time_t before); +gboolean sms_assembly_encode_address(const struct sms_address *in, + char *straddr); struct status_report_assembly *status_report_assembly_new(const char *imsi); void

Re: [SMS D-Bus 11/23] struct tx_queue_entry: add fields and destructor

Hi Inaky, On 07/07/2010 06:24 PM, Inaky Perez-Gonzalez wrote: On Wed, 2010-07-07 at 16:04 -0700, Denis Kenzior wrote: Hi Inaky, snip if (sms-txq) { - g_queue_foreach(sms-txq, (GFunc)g_free, NULL); + g_queue_foreach(sms-txq, tx_queue_entry_destroy_free,

Re: [SMS D-Bus 07/23] introduce DECLARE_SMS_ADDR_STR()

On Wed, 2010-07-07 at 15:54 -0700, Denis Kenzior wrote: Hi Inaky, +enum { SMS_ADDR_STR_SIZE = 25 }; +#define DECLARE_SMS_ADDR_STR(a) char a[SMS_ADDR_STR_SIZE] + gboolean sms_decode_address_field(const unsigned char *pdu, int len, int *offset,

Re: [SMS D-Bus 08/23] export sms_assembly_encode_address

Hi Inaky, On 07/07/2010 06:28 PM, Inaky Perez-Gonzalez wrote: On Wed, 2010-07-07 at 15:57 -0700, Denis Kenzior wrote: Hi Inaky, void sms_assembly_expire(struct sms_assembly *assembly, time_t before); +gboolean sms_assembly_encode_address(const struct sms_address *in, +

Re: [SMS D-Bus 11/23] struct tx_queue_entry: add fields and destructor

Hi Inaky, On 07/07/2010 06:31 PM, Inaky Perez-Gonzalez wrote: On Wed, 2010-07-07 at 16:32 -0700, Denis Kenzior wrote: Hi Inaky, settles that last one. Will do the _create() rename too. Good, can you resubmit this one separately soonish? I'm touching this area of the code because