[RFC_PATCH 3/4] smsutil:add proper checking of sms-address in status report-function

--- src/smsutil.c | 54 ++ 1 files changed, 26 insertions(+), 28 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 0972988..25e405c 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -46,7 +46,7 @@ #define SMS_BACKUP_PATH_FILE

[RFC_PATCH 2/4] smsutil: Editorial changes to sms status report function

--- src/smsutil.c | 202 +++- 1 files changed, 198 insertions(+), 4 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 22c70cf..0972988 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -45,6 +45,10 @@ #define SMS_BACKUP_PATH_DIR

[RFC_PATCH 4/4] smsutil: added function for data handling of status report

--- src/smsutil.c | 158 + 1 files changed, 92 insertions(+), 66 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 25e405c..a12bede 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -57,6 +57,15 @@ static GSList

Add 3GPP2 relative specifications

Add 3GPP2 relative specifications. --- diff --git a/doc/standards.txt b/doc/standards.txt index a7eaa5e..1b8c23f 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -81,3 +81,88 @@ technology specific features (e.g. UMTS/CDMA). - 102.384: Card Application

Re: Add 3GPP2 relative specifications

Hi Caiwen, Add 3GPP2 relative specifications. --- diff --git a/doc/standards.txt b/doc/standards.txt index a7eaa5e..1b8c23f 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -81,3 +81,88 @@ technology specific features (e.g. UMTS/CDMA). -

Re: Terminating emergency calls

Denis Kenzior denk...@gmail.com wrote: Hi Sjur, I have to verify this with some of my colleagues, but I am pretty sure emergency calls cannot be applied to the AT+CHLD command. i.e. they cannot be part of mpty. Initial testing on STE modem indicates that emergency call cannot participate

[PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation.

--- Changes: o Use MBM stk driver implementation (avoid copying code). Note: stemodm.h has to declare the mbm_stk_init/exit functions because importing mbmdriver causes compile errors due to duplicated declarations. drivers/stemodem/stemodem.c |2 ++

[PATCHv2 0/7] Resubmitting STE Driver patches.

Resubmitting based on rebase comments from Denis K. Changes: o SIM-ready and Radio-Settings are now split in two parts, one patch for driver and one for plugin. o Use MBM stk driver implementation (avoid copying code). o Updated error handling for Radio Settings. o Various Style issues

[PATCHv2 3/7] stemodem: Add polling for SIM ready.

Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) diff --git a/plugins/ste.c

[PATCHv2 5/7] plugins/ste: Add Radio-Settings

--- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index e1ca06c..1e3ed9d 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -55,6 +55,7 @@ #include ofono/gprs.h #include ofono/gprs-context.h #include ofono/stk.h +#include

[PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

--- Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 + drivers/stemodem/stemodem.c |2 +

[PATCHv2 6/7] stemodem: Use RTNL for creating CAIF interface

CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- Makefile.am |4 +- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 4

[PATCHv2 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

--- plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/plugins/modem.conf b/plugins/modem.conf index 66bf932..b577114 100644 --- a/plugins/modem.conf +++

Re: [PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation.

Hi Sjur, Changes: o Use MBM stk driver implementation (avoid copying code). Note: stemodm.h has to declare the mbm_stk_init/exit functions because importing mbmdriver causes compile errors due to duplicated declarations. drivers/stemodem/stemodem.c |2 ++

Re: [PATCHv2 2/7] atmodem: Enable STE usage of AT*EPEV and AT*EPEE for PIN handling.

Hi Sjur, drivers/atmodem/sim.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index eb40ad7..8e7c403 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -567,10 +567,12 @@ static void

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

Hi Sjur, Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 + drivers/stemodem/stemodem.c

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

Marcel Holtmann mar...@holtmann.org wrote: Hi Sjur, Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues.  Makefile.am                       |    4 +-  drivers/stemodem/radio-settings.c |  223

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

Hi Sjur, Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 +

[PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Marcel Holtmann wrote: ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c plugins/ste.c |2 ++ 1 files

[PATCH v3 3/7] stemodem: Add polling for SIM ready.

From: Sjur Brændeland sjur.brandel...@stericsson.com Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+),

[PATCH v3 6/7] stemodem: Use RTNL for creating CAIF interface

From: Sjur Brændeland sjur.brandel...@stericsson.com CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h |

[PATCH v3 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/plugins/modem.conf b/plugins/modem.conf index 66bf932..b577114

Re: [PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

Hi Sjur, ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH v4 1/7] plugins/ste: Include STK support from MBM driver.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Marcel Holtmann wrote: ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c one minor nitpick here. Can you

[PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Marcel Holtmann wrote: ... do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE

[PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface

From: Sjur Brændeland sjur.brandel...@stericsson.com CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h |

Re: [PATCH v3 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

Hi Sjur, do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c --- plugins/ste.c |2 +- 1 files

Re: [PATCH v4 1/7] plugins/ste: Include STK support from MBM driver.

Hi Sjur, ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c one minor nitpick here. Can you please not squeeze this in between GPRS and GPRS Context atoms.

Re: [PATCH v4 4/7] stemodem: Add Radio Settings to STE Modem

Hi Sjur, Makefile.am |3 +- drivers/stemodem/radio-settings.c | 225 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + 4 files changed, 231 insertions(+), 1 deletions(-) create mode

Re: [PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

Hi Sjur, ... do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c --- plugins/ste.c |2 +- 1 files

Re: [PATCH v4 3/7] stemodem: Add polling for SIM ready.

Hi Sjur, Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface

Hi Sjur, CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 3 files changed, 380

Re: [PATCH v4 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

Hi Sjur, plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) please don't intermix modemconf and STE plugin changes. I need two separate patches for this. Regards Marcel

Re: [RFC_PATCH 1/4] TODO: Owner of Status report task

Hi Petteri, On 08/16/2010 02:26 AM, Petteri Tikander wrote: --- TODO |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index 5221324..3481018 100644 --- a/TODO +++ b/TODO @@ -101,7 +101,7 @@ SMS Priority: Medium Complexity: C4 - Owner: