Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]

2019-06-21 Thread Marcel Holtmann
Hi Denis, >>> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote: CC drivers/mbimmodem/mbim-message.o drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’: drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required alignment of target type

Re: [PATCH 2/2] udevng: Catch network interface renames

2019-04-03 Thread Marcel Holtmann
Hi Pau, > If for whatever reason a network interface belonging to a modem is > renamed after ofono startup, ofono then keeps advertising the old > non-existing interface name instead of the new one. > To catch the changes we use udev's "move" action together with > DEVPATH_OLD variable, which

Re: [PATCH] document getting of ell, point people at useful docs

2019-02-02 Thread Marcel Holtmann
Hi Pavel, >>> diff --git a/README b/README >>> index 45bb2e9..04a50a5 100644 >>> --- a/README >>> +++ b/README >>> @@ -16,11 +16,14 @@ To configure run: >>> ./configure --prefix=/usr --mandir=/usr/share/man \ >>> --sysconfdir=/etc --localstatedir=/var >>> >>>

Re: [PATCH] mbim: add optional copy of TEMP_FAILURE_RETRY macro (fix musl compile)

2019-01-28 Thread Marcel Holtmann
Hi Nicolas, > TEMP_FAILURE_RETRY is not available on musl. > > Signed-off-by: Nicolas Serafini > --- > drivers/mbimmodem/mbim.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mbimmodem/mbim.c b/drivers/mbimmodem/mbim.c > index 54b18acf..4b040528 100644 > ---

Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3

2019-01-22 Thread Marcel Holtmann
Hi Denis, > CC drivers/rilmodem/network-registration.o > drivers/rilmodem/network-registration.c:40:32: error: unknown option > after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] >#pragma GCC diagnostic ignored "-Wrestrict" > cc1: error: unrecognized command

Re: [PATCH] document getting of ell, point people at useful docs

2019-01-22 Thread Marcel Holtmann
Hi Pavel, > Currently there's README and HACKING... each describing part of what > needs to be done to build ofono. > > Provide some cross-links and fix build example. > > diff --git a/HACKING b/HACKING > index 15ea291..b1bd599 100644 > --- a/HACKING > +++ b/HACKING > @@ -45,7 +45,8 @@

Re: sd-bus

2019-01-03 Thread Marcel Holtmann
Hi Giacinto, > > would it be interesting to port ofono from GDBus, which comes with the > > huge GLib dependency, to sd-bus? > > It is a lot of work, but the main question is whether we can assume > > that systemd is deployed enough to allow the switch. > > actually ELL provides its own D-Bus

Re: sd-bus

2019-01-03 Thread Marcel Holtmann
Hi Giacinto, > would it be interesting to port ofono from GDBus, which comes with the > huge GLib dependency, to sd-bus? > It is a lot of work, but the main question is whether we can assume > that systemd is deployed enough to allow the switch. actually ELL provides its own D-Bus support. So

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Marcel Holtmann
Hi Clement, >>> --- >>> plugins/sim900.c | 91 >>> ++-- >>> 1 file changed, 82 insertions(+), 9 deletions(-) >>> >>> diff --git a/plugins/sim900.c b/plugins/sim900.c >>> index a7728cd..bf7b9ec 100644 >>> --- a/plugins/sim900.c >>> +++

Re: [RFC PATCH] new gemalto plugin

2018-10-31 Thread Marcel Holtmann
Hi Giacinto, So you might need to expand on this some more. What is QMI+AT or MBIM+AT actually doing? Is there a single AT port? Multiple? What is the AT port being used for, just vendor specific APIs or something more? >>> >>> MBIM and QMI are actually used only for the

Re: [RFC PATCH] new gemalto plugin

2018-10-31 Thread Marcel Holtmann
Hi Denis, >>> So you might need to expand on this some more. What is QMI+AT or >>> MBIM+AT actually doing? Is there a single AT port? Multiple? What is >>> the AT port being used for, just vendor specific APIs or something more? >> MBIM and QMI are actually used only for the gprs-context atom.

Re: [PATCH 1/1] Remove superfluous definitions of _GNU_SOURCE

2018-10-17 Thread Marcel Holtmann
Hi Jonas, >>> There are a large number of files in the tree that define _GNU_SOURCE >>> despite not actually using features hidden behind this flag. This patch >>> removes all these definitions in one fell swoop... >>> --- >>> >>> I realize that it's not quite kosher in ofono to send pathes

Re: commit d37c22be20c83cf370638a9bad243bc5219c5509

2018-09-24 Thread Marcel Holtmann
Hi Giacinto, > > was it necessary to remove entirely the NEED_THREADS flag? > > > > I was going to use it in the Gemalto driver, to speed up the device > > recognition, because for some modules it is hit and miss. > > But only as an optional feature, because in some systems it might be > >

Re: commit d37c22be20c83cf370638a9bad243bc5219c5509

2018-09-23 Thread Marcel Holtmann
Hi Giacinto, > was it necessary to remove entirely the NEED_THREADS flag? > > I was going to use it in the Gemalto driver, to speed up the device > recognition, because for some modules it is hit and miss. > But only as an optional feature, because in some systems it might be missing. > >

Re: Voice calls over qmi was Re: Incoming sms problem on Motorola Droid 4

2018-05-13 Thread Marcel Holtmann
Hi Joey, > nice to hear, somebody else is using it. > > The voicecall driver needs to be refactored as Denis already pointed > out on the mailinglist before it can go upstream. > > The original idea of the voice_generated.c/h files was to create a > prototype how qmi generated files should look

Re: Incoming sms problem on Motorola Droid 4

2018-05-10 Thread Marcel Holtmann
Hi Pavel, If I attempt to do AT+CNMA=1, AT+CNMA=0 or just plain At=CNMA, it does not like that, either, but with +CMS ERROR: 500. >>> >>> CNMA=1 is required to work in PDU mode according to 27.005 btw. How >>> about: >>> >>> window.open(); >>>

Re: Incoming sms problem on Motorola Droid 4

2018-05-10 Thread Marcel Holtmann
Hi Pavel, >> If I attempt to do AT+CNMA=1, AT+CNMA=0 or just plain At=CNMA, it does >> not like that, either, but with +CMS ERROR: 500. > > CNMA=1 is required to work in PDU mode according to 27.005 btw. How > about: > > window.open(); > window.throw(modem);

Re: Incoming sms problem on Motorola Droid 4

2018-05-08 Thread Marcel Holtmann
Hi Pavel, >> I have problems with incoming SMS. ofono tries to use +CNMI=1,2,2,1,0 >>> AT+CNMI=? >> < +CNMI: (0,1,2),(0,1,2,3),(0,2),(0,1,2),(0,1) >> < OK >> ofonod[3070]: drivers/atmodem/sms.c:build_cnmi_string() >> ofonod[3070]: drivers/atmodem/sms.c:construct_ack_pdu() >>> AT+CNMI=1,2,2,1,0 >>

Re: [PATCH 0/2] gobi: support SMD devices (smartphone SoC)

2018-04-16 Thread Marcel Holtmann
Hi Joey, >> I would still fix this upstream and only workaround devices blacklisted with >> a quirk. > > I don't see how this would be possible. The issue with poll() lies in the > kernel, not the device. I guess a patched kernel could somehow indicate that > it supports poll() for writing,

Re: [PATCH 0/2] gobi: support SMD devices (smartphone SoC)

2018-04-15 Thread Marcel Holtmann
Hi Joey, > These add support for Qualcomm-based smartphone modems. > > The first is fairly straightforward: searching for "rpmsg"-subsystem devices > and supporting them in gobi as a serial device. A friend has tested it on the > mainline kernel, with the help of something like `rpmsgexport >

Re: [PATCH 1/1] doc: Fix documentation for HFP memory dialling

2018-03-07 Thread Marcel Holtmann
Hi Philippe, > Signed-off-by: Philippe De Swert No signed-off-by please. > --- > doc/voicecallmanager-api.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt > index

Re: IPV6 question

2016-09-29 Thread Marcel Holtmann
Hi Harald, > This might be off topic, but AFAIR there are PPP type PDP contexts where not > raw IP, but actual PPP frames are transmitted over GPRS inside SNDCP/LLC. Not > sure if any operators use that, but its perfectly valid. > > In this case PPP doesn't terminate in the modem, so

Re: [PATCH 2/2] don't redefine GNU_SOURCE

2015-11-06 Thread Marcel Holtmann
Hi Petr, > Signed-off-by: Petr Vorel > --- > drivers/atmodem/call-barring.c | 2 ++ > drivers/atmodem/call-forwarding.c | 2 ++ > drivers/atmodem/call-meter.c| 2 ++ > drivers/atmodem/call-settings.c | 2 ++ > drivers/atmodem/call-volume.c

Re: Problems provisioning APN from SIMs

2015-06-04 Thread Marcel Holtmann
Hi Alex, Ordering should have nothing to do with it. Yes, the ordering is relevant. We (like other ofono users I suspect) have to allow multiple APNs or the automatic provisioning process fails. Then, the first context found in serviceproviders.xml is what is used by default for the

Re: Problems provisioning APN from SIMs

2015-06-04 Thread Marcel Holtmann
Hi Alex, Ordering should have nothing to do with it. Yes, the ordering is relevant. We (like other ofono users I suspect) have to allow multiple APNs or the automatic provisioning process fails. Then, the first context found in serviceproviders.xml is what is used by default for the

Re: [PATCH] gprs: Setup route for mmsc if there's no mms proxy

2015-01-06 Thread Marcel Holtmann
Hi Slava, And don't setup mms route at all if mmsc/proxy host name is not in dotted IPv4 format. --- src/gprs.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 05ab499..9c643b9 100644 --- a/src/gprs.c +++

Re: [PATCH 1/2] Allow users to specify dbus name replacement behaviour.

2014-04-02 Thread Marcel Holtmann
Hi Jussi, In testing it is sometimes useful to be able to replace the system ofono daemon instance with our own. This patch makes this possible using dbus' name replacement feature. This patch has the plumbing changes to make it possible to set the name replacement settings. The next

Re: RFC: Ubuntu Touch, MMS, and Provisioning

2014-03-05 Thread Marcel Holtmann
Hi Tony, We've been working on MMS support for Ubuntu Touch recently and have run into a couple of stumbling blocks, so I have a few questions about the current MMS logic in oFono ( we're still 1.12 based ), and in particular the provisioning/management of gprs-contexts. As part of this

Re: RFC: Ubuntu Touch, MMS, and Provisioning

2014-03-05 Thread Marcel Holtmann
Hi Slava, What do you think about extending org.ofono.ConnectionContext API with Add/RemoveProperty calls and PropertyAdded/Removed signals to allow platform/application specific properties of type string? Use cases include marking connections as preferred/default or assigning priorities to

Re: RFC: Ubuntu Touch, MMS, and Provisioning

2014-03-05 Thread Marcel Holtmann
Hi Tony, We've been working on MMS support for Ubuntu Touch recently and have run into a couple of stumbling blocks, so I have a few questions about the current MMS logic in oFono ( we're still 1.12 based ), and in particular the provisioning/management of gprs-contexts. As part of this

Re: RFC: Ubuntu Touch, MMS, and Provisioning

2014-03-05 Thread Marcel Holtmann
Hi Tony, What do you think about extending org.ofono.ConnectionContext API with Add/RemoveProperty calls and PropertyAdded/Removed signals to allow platform/application specific properties of type string? Use cases include marking connections as preferred/default or assigning priorities to

Re: [PATCH] features: Describe Siri feature

2013-12-21 Thread Marcel Holtmann
Hi, --- doc/features.txt | 8 1 file changed, 8 insertions(+) mode change 100644 = 100755 doc/features.txt Patch has been applied, thanks. can someone please STOP changing the mode on all files they touch. Seriously, this is so not cool. Regards Marcel

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-23 Thread Marcel Holtmann
Hi Johan, Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the device is paired, we receive the Paired

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-23 Thread Marcel Holtmann
Hi Johan, Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the device is paired, we receive the Paired

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Marcel Holtmann
Hi Denis, This patch adds a new function to read the local supported Handsfree Profile version. --- include/handsfree-audio.h | 1 + src/handsfree-audio.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/handsfree-audio.h b/include/handsfree-audio.h index

Re: [PATCH v0 5/9] bluez5: Add bt_getsockpeers()

2013-01-28 Thread Marcel Holtmann
Hi Claudio, This patch adds a generic Bluetooth helper function to allow getting the adapter and device Bluetooth Address from Bluetooth sockets. --- plugins/bluez5.c | 22 ++ plugins/bluez5.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/plugins/bluez5.c

Re: [PATCH v0 3/9] hfp_hf_bluez5: Add SCO listen socket

2013-01-28 Thread Marcel Holtmann
Hi Claudio, This patch adds the initial SCO server socket handling. BtIO and BlueZ functions should not be used, with the new Profile API the objetive is to get rid of these dependencies. --- plugins/hfp_hf_bluez5.c | 93 + 1 file changed,

Re: [PATCH v0 8/9] hfp_hf_bluez5: Reject SCO if source doesn't match

2013-01-28 Thread Marcel Holtmann
Hi Claudio, This patch implements additional verification checking the Bluetooth source address instead of the remote address only. --- plugins/hfp_hf_bluez5.c | 64 ++--- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git

Re: [PATCH 3/3] storage: Include sys/types.h for ssize_t

2013-01-16 Thread Marcel Holtmann
Hi Lucas, src/storage.h:32:1: error: unknown type name 'ssize_t' src/storage.h:36:1: error: unknown type name 'ssize_t' --- src/storage.h | 1 + 1 file changed, 1 insertion(+) patch has been applied. Regards Marcel ___ ofono mailing list

Re: [PATCH 1/3] build: Do not use deprecated AM_CONFIG_HEADER

2013-01-16 Thread Marcel Holtmann
Hi Lucas, The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied. Regards Marcel ___ ofono mailing

Re: [PATCH 2/3] build: Use AM_CPPFLAGS instead of INCLUDES

2013-01-16 Thread Marcel Holtmann
Hi Lucas, Makefile.am:518: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied. Regards Marcel ___ ofono mailing list

Re: [PATCH v1 1/6] Makefile: Add configure option for BlueZ 4 and 5

2013-01-15 Thread Marcel Holtmann
Hi Claudio, BlueZ 5 is the default option. If --enable-bluez4 is provided, oFono plugins based on BlueZ 4 are enabled prior to BlueZ 5. --disable-bluetooth configure option disables BlueZ 5 and BlueZ 4 plugins. --- Makefile.am | 4 +++- configure.ac | 24 2

Re: [PATCH 2/2] atmodem: Probe device for previous APN.

2012-12-06 Thread Marcel Holtmann
Hi Denis, If the device has retained parameters for a previously defined IP context, is is probed via AT+CGDCONT?. this is really not a good idea. The AT+CGDCONT? settings are on a per device basis. That is not how oFono actually works. It operates on a per SIM card basis. And since

Re: tun interface name conflicts with ppp driver

2012-12-06 Thread Marcel Holtmann
Hi Cedric, when a context is active, the interface name is typically ppp0. If you try to run pppd for some other device/interface, the kernel ppp driver prints an error because it can't register ppp0. It looks like it's assumed that ppp* interface names are reserved for the ppp_driver. Can

Re: tun interface name conflicts with ppp driver

2012-12-06 Thread Marcel Holtmann
Hi Cedric, actually we are using ppp%d syntax to assign the network interfaces. So the kernel does the numbering. This is a bug in pppd and not ours. Looking at the pppd code, it seems to hardcodes ppp0. So please complain to them for assuming that a certain device name is owned by

Re: [PATCH 2/2] atmodem: Probe device for previous APN.

2012-12-05 Thread Marcel Holtmann
Hi Forest, If the device has retained parameters for a previously defined IP context, is is probed via AT+CGDCONT?. this is really not a good idea. The AT+CGDCONT? settings are on a per device basis. That is not how oFono actually works. It operates on a per SIM card basis. And since you do

Re: [PATCH 1/1] telit: stay 'online' until POST_SIM state reached

2012-12-04 Thread Marcel Holtmann
Hi Jonas, In offline state where CFUN=4, the Telit HE910 also powers down the SIM card so AT commands that query the SIM will fail. These failures result in ofono not getting to POST_SIM state where it will export the GPRS feature. This patch changes the Telit driver so it will not go

Re: Ofono Modem Service acces

2012-11-30 Thread Marcel Holtmann
Hi Rohit, How ofono access multiple service of the modems. Is ofono work with modem only on AT commands or access the service of modem through AT commands? it can use 3GPP 27.007, 27.010 or vendor protocols like Phonet/ISI, Qualcomm QMI or others. What is this qmi interface. Please

Re: qmi on huawei

2012-11-26 Thread Marcel Holtmann
Hi Cedric, I have a Huawei E398 dongle with a qmi interface, and i'm trying to make ofono use the qmi interface for the gprs-context atom. I have this working, but depending on how i unref the qmi_device in huawei_disable, ofono crashes or there's have a memory leak. The first approach

Re: qmi on huawei

2012-11-26 Thread Marcel Holtmann
Hi Cedric, The ofono.git HEAD already sets the driver, but the qmi and net detection is not always correct. So just overwrite the values for the device nodes and see if that works for you. Thanks for the suggestion, i started on this before this change was commited. I also had the

Re: [PATCH] systemd: prevent duplicate logging messages in journal

2012-10-25 Thread Marcel Holtmann
Hi Marti, By default, both stderr and syslog messages go to the systemd journal, which results in duplicate messages being logged. Thanks to Vinicius Costa Gomes for pointing out this problem. --- dundee/dundee.service.in | 1 + src/ofono.service.in | 1 + 2 files changed, 2

Re: [RFC] Multi-recipient SMS implementation proposals

2012-08-24 Thread Marcel Holtmann
Hi Guillaume, snip 2-Modify existing SendMessage API in adding a new mms argument: GDBUS_ASYNC_METHOD(SendMessage, GDBUS_ARGS({ to, s }, { text, s }, { mms, i }), GDBUS_ARGS({ path, o }), sms_send_message) oFono 1.x has a stable API. Why are you proposing to

Re: [RFC] gatchat: Print error message if opening tun failes

2012-08-21 Thread Marcel Holtmann
Hi Daniel, This is a very common misstake. Let's help the users to configure their system correctly. --- gatchat/ppp_net.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gatchat/ppp_net.c b/gatchat/ppp_net.c index 1609b99..7082de7 100644 --- a/gatchat/ppp_net.c

Re: [PATCH] doc: Trivial whitespace fixes

2012-08-13 Thread Marcel Holtmann
Hi Mikel, Always use tabs instead of spaces for indentation in documentation files. --- doc/location-reporting-api.txt |2 +- doc/voicecallmanager-api.txt | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) patch has been applied. Regards Marcel

Re: [PATCH_v4] test: Add hangup-call script for GCF testing

2012-08-06 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 28 2 files changed, 30 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call diff --git a/Makefile.am b/Makefile.am index 7e8f12c..8cf6920 100644 --- a/Makefile.am +++

Re: [PATCH_v5] test: Add hangup-call script for GCF testing

2012-08-06 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 14 ++ 2 files changed, 16 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call Applying: test: Add hangup-call script for GCF testing error: patch failed: Makefile.am:625 error: Makefile.am: patch

Re: [PATCH_v6] test: Add hangup-call script for GCF testing

2012-08-06 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 14 ++ 2 files changed, 16 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call patch has been applied. Regards Marcel ___ ofono mailing list

Re: [PATCH_v3 3/3] test: Add hangup-call script for GCF testing

2012-08-03 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 39 +++ 2 files changed, 41 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call diff --git a/Makefile.am b/Makefile.am index a689483..534245e 100644 ---

Re: [PATCH_v3 1/2] test: Add hangup-multiparty script for GCF testing

2012-08-03 Thread Marcel Holtmann
Hi Guillaume, Makefile.am|3 ++- test/hangup-multiparty | 20 2 files changed, 22 insertions(+), 1 deletions(-) create mode 100755 test/hangup-multiparty patch has been applied. Regards Marcel ___ ofono

Re: [PATCH_v3 2/2] test: Add hangup-call script for GCF testing

2012-08-03 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 36 2 files changed, 38 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call diff --git a/Makefile.am b/Makefile.am index 7e8f12c..8cf6920 100644 --- a/Makefile.am +++

Re: [PATCH_v3 3/3] test: Add hangup-call script for GCF testing

2012-08-02 Thread Marcel Holtmann
Hi Guillaume, Makefile.am |3 ++- test/hangup-call | 39 +++ 2 files changed, 41 insertions(+), 1 deletions(-) create mode 100755 test/hangup-call diff --git a/Makefile.am b/Makefile.am index a689483..534245e 100644 --- a/Makefile.am +++

Re: [PATCH 1/2] test: Rename script hangup-active to hangup

2012-07-30 Thread Marcel Holtmann
Hi Guillaume, Makefile.am|2 +- test/hangup| 29 + test/hangup-active | 29 - 3 files changed, 30 insertions(+), 30 deletions(-) create mode 100755 test/hangup delete mode 100755 test/hangup-active and why

Re: [PATCH 2/2] test: Tweak hangup script to clear waiting active and held calls

2012-07-30 Thread Marcel Holtmann
Hi Guillaume, test/hangup | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) this is a case where you should have done a summary email to describe why are you doing things. diff --git a/test/hangup b/test/hangup index 6444b23..60858a8 100755 --- a/test/hangup +++

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-18 Thread Marcel Holtmann
Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National Language + * Locking Shift Table should

Re: SIM Insertion Notification

2012-07-15 Thread Marcel Holtmann
Hi Brian, I'm running ofono 1.7, with a Cinterion PH8-P plugin I wrote and will submit once I've fully tested it. One problem I have is I never receive notification of SIM insertion, i.e. the Present propertyChanged. Looking at the code it seems pretty obvious why, unless I'm

Re: [PATCH 1/2] test-ussd becomes send-ussd

2012-07-09 Thread Marcel Holtmann
Hi Denis, --- test/send-ussd | 75 test/test-ussd | 75 2 files changed, 75 insertions(+), 75 deletions(-) create mode 100755 test/send-ussd delete mode

Re: New test scripts ...

2012-06-26 Thread Marcel Holtmann
Hi Jens, for personal requirements (debugging) I added 3 simple scripts (attached) to dump the properties of specific modem interfaces. Shall I send patches for them or are they useless for the project? (For the records: I don't mind either) sending patches would be better. Especially

Re: [PATCHv2 0/2] mmsd: new tasks definition

2012-06-25 Thread Marcel Holtmann
Hi Ronald, These patches concern mmsd and update documentation to describe new functionalities to add to mmsd. Ronald Tessier (2): doc: Describe delivered group in storage doc doc: Add new D-Bus methods to service interface both patches have been applied. Regards Marcel

Re: [PATCH 2/6] doc: Modify SendMessage D-Bus API

2012-06-25 Thread Marcel Holtmann
Hi Ronald, doc/service-api.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 36e1161..57e8942 100644 --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -36,7 +36,8 @@ Methods array{object,dict}

Re: [PATCH 4/6] mmsutil: Encode delivery-report in send_req msg

2012-06-25 Thread Marcel Holtmann
Hi Ronald, src/mmsutil.c |9 - src/mmsutil.h |5 + 2 files changed, 13 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 5/6] unit: Add delivery_report to send_req testing

2012-06-25 Thread Marcel Holtmann
Hi Ronald, unit/test-mmsutil.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/3] doc: Add new D-Bus methods to service interface

2012-06-06 Thread Marcel Holtmann
Hi Ronald, doc/service-api.txt | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 36e1161..5c18cad 100644 --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -63,6 +63,26 @@ Methods

Re: [PATCH 1/3] TODO: Add new tasks

2012-06-06 Thread Marcel Holtmann
Hi Ronald, TODO | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/3] doc: Describe delivered group in storage doc

2012-06-06 Thread Marcel Holtmann
Hi Ronald, doc/storage.txt | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/doc/storage.txt b/doc/storage.txt index 8e76382..0aa6d9d 100644 --- a/doc/storage.txt +++ b/doc/storage.txt @@ -18,6 +18,7 @@ Meta file Example [info]

Re: [PATCH 01/12] Constify GDBus method tables

2012-05-20 Thread Marcel Holtmann
Hi Lucas, Constify method tables with the following command: find . -name '*.[ch]' -exec \ sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \; --- plugins/hfp_hf.c|2 +- plugins/push-notification.c |2 +- plugins/smart-messaging.c |2 +-

Re: mms: next steps

2012-05-10 Thread Marcel Holtmann
Hi Ronald, Now that mms' TODO is almost empty (I've sent a set of patches yesterday that implement the last entry of the TODO). What should we add to release a first version of MMS ? What's already in place : - MMS submission, - MMS reception (automatic retrieval support), - MMS storage

Re: [PATCH 0/2] mmsd: GetConversation

2012-05-10 Thread Marcel Holtmann
Hi Ronald, These patches concern mmsd and are related to lastest patches applied. Ronald Tessier (2): test: Add python get-conversation test TODO: Update TODO to remove GetConversation entry Makefile.am |3 ++- TODO | 10 --

Re: [PATCHv2 0/4] mmsd: GetConversation support

2012-05-09 Thread Marcel Holtmann
Hi Ronald, These patches concern mmsd and implement GetConversation D-Bus API. Ronald Tessier (4): service: Retrieve get_conversation() args service: Fill conversation list with messages service: Sort conversation list by message date doc: Update service-api.txt

Re: [PATCH 1/1] TODO: task complete

2012-05-02 Thread Marcel Holtmann
Hi Sebastien, --- TODO | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 0/2] mmsd: error management

2012-04-29 Thread Marcel Holtmann
Hi Sebastien, The first patch removes the MMS reception part from TODO file which has been done some times ago. This model of error management applies also for MMS emission, except that it shouldn't be silent because initiated by the user. Sébastien Bianti (2): TODO: MMS reception error

Re: [PATCHv1 5/5] doc: Update service-api.txt

2012-04-27 Thread Marcel Holtmann
Hi Ronald, doc/service-api.txt |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 46989f4..99e80be 100644 --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -24,11 +24,18 @@ Methods

Re: [PATCHv1 4/5] service: Sort conversation list by message date

2012-04-27 Thread Marcel Holtmann
Hi Ronald, src/service.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 2787c3a..1bd4671 100644 --- a/src/service.c +++ b/src/service.c @@ -719,6 +719,31 @@ static gboolean

Re: [PATCHv1 3/5] service: Fill conversation list with messages

2012-04-27 Thread Marcel Holtmann
Hi Ronald, --- src/service.c | 88 - 1 files changed, 87 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 18c11f4..2787c3a 100644 --- a/src/service.c +++ b/src/service.c @@ -719,13 +719,85 @@

Re: [PATCHv1 1/5] service: Add GetConversation method

2012-04-27 Thread Marcel Holtmann
Hi Ronald, src/service.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v3 0/2] mmsd: bug fix

2012-04-23 Thread Marcel Holtmann
Hi Sebastien, mmsutil: add mms_message_status_get_string API service: use proper status value string src/mmsutil.c | 18 ++ src/mmsutil.h |1 + src/service.c |2 +- 3 files changed, 20 insertions(+), 1 deletions(-) both patches have been applied. Regards

Re: [PATCH 1/3] mmsutil: add mms_message_status_get_string API

2012-04-20 Thread Marcel Holtmann
Hi Sebastien, src/mmsutil.c | 25 + src/mmsutil.h |1 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/mmsutil.c b/src/mmsutil.c index c507d6f..725849b 100644 --- a/src/mmsutil.c +++ b/src/mmsutil.c @@ -1661,3 +1661,28 @@ gboolean

Re: [PATCH 3/3] service: fix for message_delete bug

2012-04-20 Thread Marcel Holtmann
Hi Sebastien, mms_message_unregister destroyes the message --- src/service.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH_v2] atmodem: Poll SIM state after having entered PIN

2012-04-17 Thread Marcel Holtmann
Hi Guillaume, Some modems use SIM notification to check SIM state. If not do some poll using atutil helper. --- drivers/atmodem/sim.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index

Re: [PATCH 2/3] Speedup: Use speedup specific driver for ussd

2012-04-16 Thread Marcel Holtmann
Hi Nicolas, plugins/speedup.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/speedup.c b/plugins/speedup.c index ca6ed13..8b95286 100644 --- a/plugins/speedup.c +++ b/plugins/speedup.c @@ -2,7 +2,7 @@ * * oFono - Open Source Telephony * -

Re: [PATCH v1 1/2] service: remove files when unable to decode received msg

2012-04-11 Thread Marcel Holtmann
Hi Ronald, src/service.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index f148252..851db34 100644 --- a/src/service.c +++ b/src/service.c @@ -984,7 +984,12 @@ static gboolean load_message_from_store(const char

Re: [PATCH v1 2/2] service: handle error while receiving messages

2012-04-11 Thread Marcel Holtmann
Hi Ronald, src/service.c | 94 1 files changed, 74 insertions(+), 20 deletions(-) diff --git a/src/service.c b/src/service.c index 851db34..c3fc0c6 100644 --- a/src/service.c +++ b/src/service.c @@ -55,6 +55,7 @@ #define

Re: [PATCH 0/2] complete storage task

2012-03-30 Thread Marcel Holtmann
Hi Sebastien, These patches concern mmsd for ofono mailing list. Sébastien Bianti (2): service: transaction id should'nt be NULL TODO: storage task complete both patches have been applied. Regards Marcel ___ ofono mailing list

Re: [PATCH v3 0/3] bug fixing in send message recovery

2012-03-30 Thread Marcel Holtmann
Hi Sebastien, Patch 1 to 3 fix some leaks when a problem arises when a send request is created. Sébastien Bianti (3): service: factorize error code service: NULL uuid here is an error service: remove orphan file all three patches have been applied. Regards Marcel

Re: Configuring a TCP-connected Modem

2012-03-27 Thread Marcel Holtmann
Hi Aaron, I have a sort of strange question. I'd like to be able to configure an Inmarsat BGAN modem with ofono using a TCP connection to a port on the modem. The modem is connected via Ethernet. Has this sort of thing been done? Any ideas on what it would take to get this working? we

Re: [PATCH v3] huawei: fix AT^DDSETEX=2 timing

2012-03-24 Thread Marcel Holtmann
Hi Jarkko, Voice output serial port is enabled on some Huawei models (e.g. E169) without problems, but for example on E173u-2 it is never enabled during an incoming call. There might also be other Huawei models having the same issue. I traced the issue down to ^DDSETEX AT command, which is

Re: [PATCH v2 1/6] service: remove dead file

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, --- src/service.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index ef6b544..3fdf4e0 100644 --- a/src/service.c +++ b/src/service.c @@ -755,6 +755,7 @@ static DBusMessage *send_message(DBusConnection *conn,

Re: [PATCH v2 2/6] service: fixed possible meta with NULL uuid

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, If mms_store_file fails. --- src/service.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 3fdf4e0..0161ec0 100644 --- a/src/service.c +++ b/src/service.c @@ -767,6 +767,15 @@ static DBusMessage

Re: [PATCH v2 3/6] service: remove pdu without meta

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, src/service.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/service.c b/src/service.c index 0161ec0..8dbee12 100644 --- a/src/service.c +++ b/src/service.c @@ -777,11 +777,17 @@ static DBusMessage *send_message(DBusConnection *conn,

Re: [PATCH v2 4/6] service: request_post_file opens the pdu itself

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, src/service.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2 5/6] service: fix some leaks

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, src/service.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

  1   2   3   4   5   6   7   8   9   10   >