Re: [PATCH] Fix: transaction id usage in gisi/server.c

2010/4/23 Denis Kenzior denk...@gmail.com: +                        (void *)spn, (sizeof spn)) != (sizeof req)) { Casting to or from void is not necessary. Oh, it is. If a struct sockaddr_pn structure is casted directly to struct sockaddr, gcc will issue alignment warning on ARM. --

Re: [PATCH] Fix: transaction id usage in gisi/server.c

On Fri, 23 Apr 2010 16:07:11 +0300, Pekka Pessi ppe...@gmail.com wrote: 2010/4/23 Denis Kenzior denk...@gmail.com: +                        (void *)spn, (sizeof spn)) != (sizeof req)) { Casting to or from void is not necessary. Oh, it is. If a struct sockaddr_pn structure is casted

Re: [PATCH] Fix: transaction id usage in gisi/server.c

Hi Remi, Casting to or from void is not necessary. Oh, it is. If a struct sockaddr_pn structure is casted directly to struct sockaddr, gcc will issue alignment warning on ARM. The cast-align warning is a can of false positives. First that warning should probably not be enabled. It

Re: [PATCH] Fix: transaction id usage in gisi/server.c

2010/4/23 Rémi Denis-Courmont r...@remlab.net: On Fri, 23 Apr 2010 16:07:11 +0300, Pekka Pessi ppe...@gmail.com wrote: 2010/4/23 Denis Kenzior denk...@gmail.com: +                        (void *)spn, (sizeof spn)) != (sizeof req)) { Casting to or from void is not necessary. Oh, it is. If a

Re: [PATCH] Fix: transaction id usage in gisi/server.c

On Fri, 23 Apr 2010 16:34:44 +0200, Marcel Holtmann mar...@holtmann.org wrote: The cast-align warning is a can of false positives. First that warning should probably not be enabled. It does nothing on x86, and it's a waste of time with ARM and other pointer-picky platforms. I don't have an

[PATCH] Fix: transaction id usage in gisi/server.c

--- gisi/server.c | 111 +++- 1 files changed, 54 insertions(+), 57 deletions(-) diff --git a/gisi/server.c b/gisi/server.c index ef2d5dd..26386c1 100644 --- a/gisi/server.c +++ b/gisi/server.c @@ -44,7 +44,7 @@ struct _GIsiIncoming {

Re: [PATCH] Fix: transaction id usage in gisi/server.c

On Fri, 23 Apr 2010 18:17:16 +0300, Pekka Pessi pekka.pe...@nokia.com wrote: @@ -174,9 +172,11 @@ g_isi_server_add_name(GIsiServer *self) 0, 0, }; - if (sendto(self-fd, req, sizeof(req), 0, (void *)spn, -

Re: [PATCH] Fix: transaction id usage in gisi/server.c

Hi Pekka, --- gisi/server.c | 111 +++- 1 files changed, 54 insertions(+), 57 deletions(-) WARNING: space prohibited between function name and open parenthesis '(' #95: FILE: gisi/server.c:88: + memset (self, 0, sizeof(*self)); I

[PATCH] Fix: transaction id usage in gisi/server.c

--- gisi/server.c | 90 +--- 1 files changed, 40 insertions(+), 50 deletions(-) diff --git a/gisi/server.c b/gisi/server.c index ef2d5dd..8eb28a7 100644 --- a/gisi/server.c +++ b/gisi/server.c @@ -44,7 +44,7 @@ struct _GIsiIncoming {

Re: [PATCH] Fix: transaction id usage in gisi/server.c

So first off, please refer to the Linux Coding Style document. 'sizeof foo' is not a proper construct according to our style guidelines. It is sizeof(foo). Linux Kernel CodingStyle document that is. Regards, -Denis ___ ofono mailing list