Hi Inaky,
Maybe we're not talking about the same thing. My workflow is
git commit / git am
git fetch
git rebase
git push
gee, didn't see this -- well, if the rebase is changing the commit IDs,
which it probably does, then you are breaking the commit history. Would
depend on the
On Thu, 2010-07-08 at 17:22 -0700, Denis Kenzior wrote:
Inaky,
No worries, take your time. Just as a heads up, I pushed some changes
to src/sms.c today.
Grrr -- found the bug and deal with it. However, when I tried to pull
your tree to rebase on top, I got weird conflicts
Hi Inaky,
On 07/08/2010 06:28 PM, Inaky Perez-Gonzalez wrote:
On Wed, 2010-07-07 at 16:39 -0700, Denis Kenzior wrote:
...
Good, can you resubmit this one separately soonish? I'm touching this
area of the code because of Andrew's changes for STK Send SMS command
handling.
I'll resubmit
Hi Inaky,
On 07/07/2010 06:24 PM, Inaky Perez-Gonzalez wrote:
On Wed, 2010-07-07 at 16:04 -0700, Denis Kenzior wrote:
Hi Inaky,
snip
if (sms-txq) {
- g_queue_foreach(sms-txq, (GFunc)g_free, NULL);
+ g_queue_foreach(sms-txq, tx_queue_entry_destroy_free,
Hi Inaky,
On 07/07/2010 06:31 PM, Inaky Perez-Gonzalez wrote:
On Wed, 2010-07-07 at 16:32 -0700, Denis Kenzior wrote:
Hi Inaky,
settles that last one. Will do the _create() rename too.
Good, can you resubmit this one separately soonish? I'm touching this
area of the code because
From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com
Add a name field that will be used to contain a permanent name for
each SMS message in-transit, to be used for persistent storage and for
D-Bus object naming.
The persist name will be used to denote if persistence has to be
implemented in