[okular] [Bug 403524] in "save as" the drop down list of recent places doesn't contain recent places

https://bugs.kde.org/show_bug.cgi?id=403524 Nate Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

[okular] [Bug 403486] Remember collapsed/expanded state of navigation bar

https://bugs.kde.org/show_bug.cgi?id=403486 Nate Graham changed: What|Removed |Added Summary|Folded navigation bar |Remember collapsed/expanded |

[okular] [Bug 403486] Folded navigation bar

https://bugs.kde.org/show_bug.cgi?id=403486 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

[okular] [Bug 402984] Okular never prints

https://bugs.kde.org/show_bug.cgi?id=402984 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

D18744: Select entire page on mouse double click event

shubham added a comment. In D18744#406150 , @aacidTriple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there? > > AFAICS triple-click is usually "select line" not "select all

D18744: Select entire page on mouse double click event

ngraham added a comment. Yeah, that would be nice. Maybe select the entire page on quadruple-click? I agree that double-click is not ideal. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde,

D18744: Select entire page on mouse double click event

aacid added a comment. In D18744#406128 , @davidhurka wrote: > In D18744#405851 , @ngraham wrote: > > > However I wonder if maybe triple-click might be better though? Triple-click is used for

[okular] [Bug 403943] Entries in table of contents should be normalized (whitespace stripped)

https://bugs.kde.org/show_bug.cgi?id=403943 --- Comment #2 from David Hurka --- I see that this makes it easier to read a document (sometimes). It makes sense to preserve the true contents of a document (e. g. to test some LaTeX output), but it would be nice to have this as option, similar to

[okular] [Bug 403975] New: Background color for text selection in the document should be configurabe, instead of relying on system color scheme

https://bugs.kde.org/show_bug.cgi?id=403975 Bug ID: 403975 Summary: Background color for text selection in the document should be configurabe, instead of relying on system color scheme Product: okular Version:

D18744: Select entire page on mouse double click event

davidhurka added a comment. In D18744#405851 , @ngraham wrote: > However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

https://bugs.kde.org/show_bug.cgi?id=403848 Nate Graham changed: What|Removed |Added CC||n...@kde.org Resolution|---

D18744: Select entire page on mouse double click event

aacid added a comment. Honestly i think this is weird UI, no other single project out there does this (that i know) Personally I would prefer if we didn't do it either. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts,

[okular] [Bug 403943] Entries in table of contents should be normalized (whitespace stripped)

https://bugs.kde.org/show_bug.cgi?id=403943 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #15 from Albert Astals Cid --- (In reply to David Hurka from comment #14) > No my problem with Okular is different to yours. Text selection (using Text > Selection mode) makes text invisible, because PDFs use black text. I need to > change

D18744: Select entire page on mouse double click event

shubham added a comment. Caution: I did not do my video editing magic : ) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham added a comment. @ngraham @loh.tar I don't think it is that big of a feature to be shown in the view menu. It is something which is natural, same as when you select a word(which also don't have any action defined). i'm okay anyways. REPOSITORY R223 Okular REVISION DETAIL

D18744: Select entire page on mouse double click event

abetts added a comment. This idea is super interesting. Can you please make a gif or short video showing the new feature? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella,

D18744: Select entire page on mouse double click event

ngraham added a comment. In D18744#405859 , @loh.tar wrote: > I suggest: > > - Add a new action "Select Page" similar to "Select All" > - Call first that new action/function, then the copy function, instead of coding explicit in mouse

D18761: Add icon name to service providers in .desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8657a239a28d: Add icon name to service providers in .desktop file (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18761?vs=50953=50969 REVISION

D18761: Add icon name to service providers in .desktop file

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH icon REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

D18744: Select entire page on mouse double click event

loh.tar added a comment. I suggest: - Add a new action "Select Page" similar to "Select All" - Call first that new action/function, then the copy function, instead of coding explicit in mouse event - Shorten your comments, don't say what is obviously, explain things which may

D18744: Select entire page on mouse double click event

alexde added subscribers: ngraham, alexde. alexde added a comment. In D18744#405851 , @ngraham wrote: > Seems sane enough to me. However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word

D18744: Select entire page on mouse double click event

ngraham edited reviewers, added: VDG; removed: ngraham. ngraham added a comment. Interesting feature. Can confirm that it works for me; tested with a bunch of PDFs and ePubs with selectable text. No effect with documents that don't have selectable text. No crashes. Seems sane enough to

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #14 from David Hurka --- (In reply to Albert Astals Cid from comment #1) > No, that solution doesn't work, because people that use dark themes (where > selection is usually a white-ish color) would not see the selection when > reading PDFs

[okular] [Bug 358868] copy entire page to clipboard

https://bugs.kde.org/show_bug.cgi?id=358868 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail

D18744: Select entire page on mouse double click event

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham retitled this revision from "[WIP]Select entire page on mouse double click event" to "Select entire page on mouse double click event". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen,

D18744: [WIP]Select entire page on mouse double click event

shubham updated this revision to Diff 50959. shubham added a comment. Remove unncessary include REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=50958=50959 BRANCH clipboard REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES

D18744: [WIP]Select entire page with double click

shubham marked 2 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18744: [WIP]Select entire page on mouse double click event

shubham retitled this revision from "[WIP]Select entire page with double click" to "[WIP]Select entire page on mouse double click event". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen,

D18744: [WIP]Select entire page with double click

shubham updated this revision to Diff 50958. shubham added a comment. Fix segmentation fault error. Now mouse double click event on empty portion of the document selects the entire page REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=50907=50958

D18761: Add icon name to service providers in .desktop file

shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty,

D18761: Add icon name to service providers in .desktop file

shubham added a comment. In the rest of service providers, very few have any icon specified, and most don't have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

D18730: Use breeze icons for search providers

shubham abandoned this revision. shubham added a comment. Abandoned in favour of D18761 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel,

D18761: Add icon name to service providers in .desktop file

shubham added reviewers: VDG, Okular. shubham added projects: Okular, VDG. shubham added a subscriber: Okular. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

D18730: Use breeze icons for search providers

broulik added a comment. Check out D18730 Then you can put `Icon=foo` in the respective search provider desktop file REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc:

D18730: Use breeze icons for search providers

shubham added a comment. @broulik Adding icons to the .desktop files does not work, I tried. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes,

D18730: Use breeze icons for search providers

broulik added a comment. Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a proper icon. https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps needs to have icons added REPOSITORY R223 Okular REVISION DETAIL