D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. Yes, doesn't that work for you? The complete logic is in the method

[okular] [Bug 403835] Print print empty pages

https://bugs.kde.org/show_bug.cgi?id=403835 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[okular] [Bug 404506] Typewriter annotation tool font colour lost on resize

https://bugs.kde.org/show_bug.cgi?id=404506 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[okular] [Bug 404936] A4 double sided printing of a .pdf doc produces wrong size "images" on even/odd paper.

https://bugs.kde.org/show_bug.cgi?id=404936 --- Comment #11 from Piet de Weerdt --- Good morning again, If you need more information: I am in South Africa, the current time is 04:40. I am normally available 6 days a week from 04:00 until 18:00 Kind regards, Piet de Weerdt On Wed, Mar 6, 2019

[okular] [Bug 404936] A4 double sided printing of a .pdf doc produces wrong size "images" on even/odd paper.

https://bugs.kde.org/show_bug.cgi?id=404936 --- Comment #10 from Piet de Weerdt --- Created attachment 118589 --> https://bugs.kde.org/attachment.cgi?id=118589=edit IMG_1864.jpg -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 404936] A4 double sided printing of a .pdf doc produces wrong size "images" on even/odd paper.

https://bugs.kde.org/show_bug.cgi?id=404936 --- Comment #9 from Piet de Weerdt --- Good morning gentlemen, I have attached two images. The one from yesterday showing that the headers and footers do not align on odd/even pages. That would be IMG_1864.jpg I quickly printed the same using evince.

D18658: Modify search bar in the contextDrawer

aacid added inline comments. INLINE COMMENTS > CMakeLists.txt:13 > +option(BUILD_OKULARKIRIGAMI "Builds the touch-friendly frontend" ON) > +if (BUILD_OKULARKIRIGAMI) > +set(KF5_REQUIRED_VERSION "5.56.0") I would prefer if you left the required version to be 5.44.0 for everything and then

D19542: [WIP] Make pop-up note text visible whatever background color is

aacid added a comment. You don't need to change the color though settings, just right click on the annotation and change it's color. I don't understand your "I could not find the right place for the color change yet", aren't you changing the color in there? If we're going to go

[okular] [Bug 404936] A4 double sided printing of a .pdf doc produces wrong size "images" on even/odd paper.

https://bugs.kde.org/show_bug.cgi?id=404936 --- Comment #8 from Albert Astals Cid --- I don't really see any problem in the printed pages. Can you elaborate what's wrong? -- You are receiving this mail because: You are the assignee for the bug.

D19183: Use logically correct icon for direction arrows

aacid added a comment. I already said that i personally don't like it. Nathan, Andy and David seem to like it (even though none answered about how this works visually when on N columns mode where it doesn't actually move the focused page up/down but left/right) You can either trust

D18744: Add action in Edit menu to select the text on current page

aacid added inline comments. INLINE COMMENTS > index.docbook:1297 > + Selects > all the text (if the document provides it) of the current page. This works > only in > + Text > Selection mode. > +

Re: D18118: Presentation mode: go to previous page when left-clicking on left half of the page

What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. I'm asking this because there are programmable pedals for turning pages as well. I believe they are related to

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a subscriber: sander. gbodley added a comment. What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. I'm asking this because there are

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. In D18118#425420 , @sander wrote: > That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days. Exactly! REPOSITORY R223

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53239. ognarb added a comment. Use a cmake option to build okular with kde framework 5.56 and okular mobile or wit 5.44 and not okular mobile REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53233=53239 BRANCH

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > That's the current behavior, ... Meaning: That is the current behavior *of the patch*, ... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel,

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53233. ognarb added a comment. Use text.length > 0 insteaf of text != "" REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=52415=53233 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D18658

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Oh, I think I see what you mean now. How about this, then? Touch navigation: ( ) Tap left/right sides to go back/forward (0) Tap anywhere to go forward ( ) Disabled REPOSITORY R223 Okular REVISION DETAIL

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. If I understand Albert correctly he wants to have the current behavior as an option. Your proposal does not offer that, does it? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Nothing happens. I'm kind of wondering why we need to enable them separately in the first place though. Couldn't we just have a single checkbox that enables and disables both? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To:

D19539: Replace some iterator loops by range-based for

sander added a comment. Fine with me, too. If somebody is in favour of `auto`, please say so now. Otherwise I will remove the `auto`s from the patch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: aacid, davidhurka, okular-devel,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Not sure I fully understand your proposal. What happens if I uncheck the first option, check the second one, and then tap on the left half of the screen? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc:

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. UI-wise, here's what I might recommend: Touchscreen: [ ] Tap left side to go to previous page [ ] Tap right side to go to next page That way we have all the same functionality, but the labels explain how to use the feature, too.

D19539: Replace some iterator loops by range-based for

aacid added a comment. auto makes the code much more unreadable for me, i don't want to have to go to the header to figure out which type the variable is INLINE COMMENTS > presentationwidget.cpp:313 > // delete frames > -QVector< PresentationFrame * >::iterator fIt =

D19542: [WIP] Make pop-up note text visible whatever background color is

yurchor created this revision. yurchor added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. yurchor requested review of this revision. REVISION SUMMARY The user can choose the blue or some dark color for annotation background and the black text is

D19539: Replace some iterator loops by range-based for

sander added a comment. You may want to read up on range-based for; it is very helpful. In such a for-loop, `auto` always means "the type of a container entry". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: davidhurka, okular-devel,

D19539: Replace some iterator loops by range-based for

davidhurka added a comment. Isn’t `auto` a bit confusing as item type? A beginner like me wouldn’t understand that. Example (pageview.cpp:1194): `page` is an item of `pageSet`, which is `QVector< Okular::Page * >`. If I don’t know that: `PageViewItem * item = new PageViewItem( page

[okular] [Bug 396879] Full screen mode doesn't work in wayland

https://bugs.kde.org/show_bug.cgi?id=396879 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53196. sander edited the summary of this revision. sander edited the test plan for this revision. sander added a comment. Make the new touch screen behavior optional. There are three choices now in 'preferences->presentation': - Forward/Backward:

D19539: Replace some iterator loops by range-based for

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY As the title says. In my humble opinion this makes the code *much* easier to read. TEST PLAN No

[okular] [Bug 405105] Instered text annotation tooltip text barely readable

https://bugs.kde.org/show_bug.cgi?id=405105 Yuri Chornoivan changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Severity|normal

[okular] [Bug 405105] Instered text annotation tooltip text barely readable

https://bugs.kde.org/show_bug.cgi?id=405105 --- Comment #2 from smihael --- Thanks, but this doesn't solve the problem with annotations that are already in the pdf (i.e. someone wnot using Okular sends me annotated pdf with reviews). A possible solution (which is used in many other pdf viewers)

[okular] [Bug 405105] Instered text annotation tooltip text barely readable

https://bugs.kde.org/show_bug.cgi?id=405105 Yuri Chornoivan changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 405105] New: Instered text annotation tooltip text barely readable

https://bugs.kde.org/show_bug.cgi?id=405105 Bug ID: 405105 Summary: Instered text annotation tooltip text barely readable Product: okular Version: 1.6.2 Platform: Neon Packages OS: Linux Status: REPORTED