[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

https://bugs.kde.org/show_bug.cgi?id=403848 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

D18358: [WIP] Add buttons to collapse and expand all elements

ngraham added a comment. Also please remove the `[WIP]` from the title since there's nothing here that's really WIP as far as I can tell; just a string change and waiting for icons. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg,

D18358: [WIP] Add buttons to collapse and expand all elements

joaonetto added a comment. In D18358#426098 , @ngraham wrote: > We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact. That's some great news. I'll be waiting on it REPOSITORY R223 Okular

D18358: [WIP] Add buttons to collapse and expand all elements

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact. INLINE COMMENTS > aacid wrote in side_reviews.cpp:155 > This should probably be

D18658: Modify search bar in the contextDrawer

aacid added inline comments. INLINE COMMENTS > CMakeLists.txt:129 > if (BUILD_OKULARKIRIGAMI) > -add_subdirectory( mobile ) > +if (${KF5_VERSION} VERSION_GREATER 5.56) > +add_subdirectory( mobile ) Shouldn't this be 5.55? REPOSITORY R223 Okular REVISION DETAIL

D18358: [WIP] Add buttons to collapse and expand all elements

aacid added a comment. Are we waiting for the new icons here? Any idea if they will be ever done or should we just go with something else? INLINE COMMENTS > side_reviews.cpp:155 > +connect(expandAll, ::triggered, this, ::slotExpandAll); > +QAction * collapseAll = toolBar->addAction(

[okular] [Bug 402033] Okular "typewriter" annotation tool - can't change text font or colour

https://bugs.kde.org/show_bug.cgi?id=402033 --- Comment #12 from Albert Astals Cid --- The snap version is probably using an ancient poppler. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 404506] Typewriter annotation tool font colour lost on resize

https://bugs.kde.org/show_bug.cgi?id=404506 --- Comment #6 from Albert Astals Cid --- I can reproduce (poppler 0.74 and okular 1.6.2) a similar but actually inverse issue. If i set a typewritter annotation to be red, it'll show up as black the first time and only render as red on the next

D19539: Replace some iterator loops by range-based for

aacid added inline comments. INLINE COMMENTS > pageview.cpp:941 > { > -QVector< PageViewItem * >::const_iterator it = d->items.constBegin(), > itEnd = d->items.constEnd(); > -for ( ; it < itEnd; ++it ) > +for ( PageViewItem * item : d->items ) > { This code is suddenly less

[okular] [Bug 405105] Instered text annotation tooltip text barely readable

https://bugs.kde.org/show_bug.cgi?id=405105 --- Comment #4 from Yuri Chornoivan --- It looks like this is Qt problem and there is nothing to do on Okular side. See [1] for the details and screenshots. [1] https://phabricator.kde.org/D19542 -- You are receiving this mail because: You are the

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham accepted this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53295. sander added a comment. UI reworded following Nate's suggestions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18118?vs=53196=53295 REVISION DETAIL https://phabricator.kde.org/D18118 AFFECTED FILES

D19539: Replace some iterator loops by range-based for

sander updated this revision to Diff 53294. sander added a comment. - Do not use `auto` in range-based for - Use `qDeleteAll` where appropriate REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19539?vs=53191=53294 REVISION DETAIL

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. After reading some Wikipedia, I can say: - Checkmarks use luma (NTSC) - Your approach uses luma (sRGB) - QColor::lightness() uses lightness (HSL-bi-hexcone) QColor::lightness() would not solve the problem, it would put white #ff text on yellow

D19542: [WIP] Make pop-up note text visible whatever background color is

yurchor abandoned this revision. yurchor added a comment. Looks like this is expected Qt behavior. Nothing to tweak here. Should be corrected in Qt somehow (corner cases of the correct luminance determination). Thanks to @davidhurka for testing. REPOSITORY R223 Okular REVISION DETAIL

[okular] [Bug 404506] Typewriter annotation tool font colour lost on resize

https://bugs.kde.org/show_bug.cgi?id=404506 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #5 from Yuri

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. In D19542#425756 , @yurchor wrote: > Do you mean that the attached test case (text.pdf) works for you (the text in annotation window for the right blue pop-up note is visible)? No, but the functionality is

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53268. ognarb marked 2 inline comments as done. ognarb added a comment. Change cmake REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53239=53268 BRANCH arcpatch-D18658 REVISION DETAIL

D19542: [WIP] Make pop-up note text visible whatever background color is

yurchor added a comment. In D19542#425698 , @davidhurka wrote: > Erm, my Okular 1.6.2 already does this, just with another threshold. Below value() = 129, the text (and the header) become white, above value() = 128, they become black. > >

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. Erm, my Okular 1.6.2 already does this, just with another threshold. Below value() = 129, the text (and the header) become white, above value() = 128, they become black. While searching for the code, I just found ui/drawingtoolactions.cpp:48, which does

Re: GSoC

Hi Aryan, great to hear you are interested in contributing to Okular. How much programming experience do you have? Have you already downloaded and build the Okular source code? As this years projects mainly deal with annotations in pdf files I suggest you also build a local version of the

D19542: [WIP] Make pop-up note text visible whatever background color is

yurchor added a comment. In D19542#425607 , @aacid wrote: > You don't need to change the color though settings, just right click on the annotation and change it's color. Oops... Thanks for the notice. :) > I don't understand your "I

[okular] [Bug 404506] Typewriter annotation tool font colour lost on resize

https://bugs.kde.org/show_bug.cgi?id=404506 Rajeesh K V changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO