[okular] [Bug 406237] PDFs get an added margin when printing

2019-05-07 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |REPORTED Ever confirmed|1

[okular] [Bug 406237] PDFs get an added margin when printing

2019-05-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=406237 --- Comment #8 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D20437: Make selection scrolling go at 60 fps

2019-05-07 Thread Nathaniel Graham
ngraham added a comment. Thanks, I've added your preferences there. @aacid, can we proceed now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander, ngraham Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik,

D20437: Make selection scrolling go at 60 fps

2019-05-07 Thread kezi
kezik added a comment. @aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted https://phabricator.kde.org/D21070 I'm not sure if I fscked up something in creating that revision, so tell me what to fix, in case. Thanks

D20760: Okular Annotation: add support for line ending style for Straight Line tool

2019-05-07 Thread Rajeesh K Nambiar
knambiar added a comment. In D20760#462025 , @sander wrote: > I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch. > > Rajeesh,

D21069: [RFC] Improve documentation of Document::setPageTextSelection()

2019-05-07 Thread David Hurka
davidhurka added a comment. I suggested this in D18744#441906 . It would be more natural not to delete `rect`, because that causes a dangling pointer, and makes the calling code look memory leaking. I’m new with submitting patches, so feel

[okular] [Bug 407286] Focus stealing prevention prevents Okular from focusing Kate using synctex when Kate is not minimized

2019-05-07 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=407286 Vlad Zagorodniy changed: What|Removed |Added Version|5.15.4 |unspecified

D21069: [RFC] Improve documentation of Document::setPageTextSelection()

2019-05-07 Thread David Hurka
davidhurka created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. davidhurka requested review of this revision. REVISION SUMMARY Improve the documentation of Document::setPageTextSelection() and PagePrivate::setTextSelections(). Also mention which

D20760: Okular Annotation: add support for line ending style for Straight Line tool

2019-05-07 Thread Oliver Sander
This revision was automatically updated to reflect the committed changes. Closed by commit R223:db2dcdade399: Okular Annotation: add support for line ending style for Straight Line tool (authored by knambiar, committed by sander). CHANGED PRIOR TO COMMIT

D20760: Okular Annotation: add support for line ending style for Straight Line tool

2019-05-07 Thread Oliver Sander
sander added a comment. I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch. Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future. REPOSITORY

[okular] [Bug 237014] Find tool when text has been highlighted

2019-05-07 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=237014 --- Comment #9 from Luigi Toscano --- *** Bug 407256 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 407256] Please change search result display color

2019-05-07 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=407256 Luigi Toscano changed: What|Removed |Added Status|REOPENED|RESOLVED CC|