D21332: Okular Annotation: add line start/end style config only for Straight Line tool

knambiar added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in annotationwidgets.cpp:499 > Checking a polygons Inner color checkbox now causes segfault. It's because > `LineAnnotationWidget::applyChanges` accesses `m_startStyleCombo` and > `m_endStyleCombo` unconditionally. But in

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

knambiar updated this revision to Diff 58571. knambiar marked 3 inline comments as done. knambiar edited the summary of this revision. knambiar added a comment. Fix crash, `m_{start,end}StyleCombo` are guarded by `m_lineType == 0` check for Straight Line tool. REPOSITORY R223 Okular

[okular] [Bug 407369] Okular crashes when opening a digitally signed pdf file.

https://bugs.kde.org/show_bug.cgi?id=407369 --- Comment #2 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[okular] [Bug 407884] New: Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu

https://bugs.kde.org/show_bug.cgi?id=407884 Bug ID: 407884 Summary: Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu Product: okular Version: 1.7.1 Platform: Other

D21376: RFC: In annotations list show highlighted text

jangmarker added inline comments. INLINE COMMENTS > guiutils.cpp:77 > +// TODO this does not seem to be very accurate :-( > +text += page->text(page->textArea(), > Okular::TextPage::CentralPixelTextAreaInclusionBehaviour); > +} I'd be grateful for

D21376: RFC: In annotations list show highlighted text

jangmarker created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. jangmarker requested review of this revision. REVISION SUMMARY unfortunately the text detection is not 100 % accurate REPOSITORY R223 Okular BRANCH

D21376: RFC: In annotations list show highlighted text

jangmarker added reviewers: Okular, davidhurka. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21376 To: jangmarker, #okular, davidhurka Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 407883] New: Previous/Next Bookmark actions not enabled/disabled correctly / do not cycle though bookmarks

https://bugs.kde.org/show_bug.cgi?id=407883 Bug ID: 407883 Summary: Previous/Next Bookmark actions not enabled/disabled correctly / do not cycle though bookmarks Product: okular Version: 1.7.1 Platform: Neon Packages

D21364: Indicate annotation color in annotation list

jangmarker added a comment. Now it looks like this: F6844521: image.png A stamp looks like this: F6844523: image.png I changed the color of this stamp to something blue, but the algorithm that's

D21364: Indicate annotation color in annotation list

jangmarker updated this revision to Diff 58563. jangmarker added a comment. Instead of showing colorful rectangles, use same icons as for annotation tool REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21364?vs=58542=58563 BRANCH indicate-annotation-color

D21364: Indicate annotation color in annotation list

jangmarker added a comment. In D21364#469215 , @davidhurka wrote: > In D21364#469159 , @jangmarker wrote: > > > I think `captionForAnnotation()` does not include the comment's text currently, so

D21364: Indicate annotation color in annotation list

davidhurka added a comment. In D21364#469159 , @jangmarker wrote: > I think `captionForAnnotation()` does not include the comment's text currently, so this change should probably be done in another commit. > It would make sense to

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

tobiasdeiminger added inline comments. INLINE COMMENTS > annotationwidgets.cpp:499 > { > m_useColor = new QCheckBox( i18n( "Inner color:" ), gb2 ); > gridlay2->addWidget( m_useColor, 1, 0 ); Checking a polygons Inner color checkbox now causes segfault. It's because

D21364: Indicate annotation color in annotation list

jangmarker added a comment. In D21364#469111 , @davidhurka wrote: > Nice, makes the list more intuitive. :) (Didn’t test this) Thank you :-) Currently it looks like this: F6844393: image.png

[okular] [Bug 155490] some thoughts about icons and menu

https://bugs.kde.org/show_bug.cgi?id=155490 --- Comment #7 from David Hurka --- I think at least in the left sidebar, the icons could be improved. 1. Use the icon currently used by Layers for Contents, because Contents currently looks like linear text, not like a list. 2. Use a layer icon for

[okular] [Bug 180443] Provide icons for entries in the View menu

https://bugs.kde.org/show_bug.cgi?id=180443 --- Comment #2 from David Hurka --- Update: Trim Margins got an icon, and a new icon was created for Trim to Selection. Close this bug? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 407865] If rotating the view the annotations are not rotated

https://bugs.kde.org/show_bug.cgi?id=407865 --- Comment #3 from David Hurka --- (In reply to Luca Tagliacozzo from comment #2) > Not sure what squiggle and strike-out are maybe I do not have them > in my version of Okular AFAIK they are not configured by default. If you right-click one of the

D21364: Indicate annotation color in annotation list

davidhurka added a comment. Nice, makes the list more intuitive. :) (Didn’t test this) Three questions/suggestions: - Assuming that captionForAnnotation() returns something more useful than “ with Comment” (like “: ”), should data() return an "okular" icon by default? If there is

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added Summary|Markdown preview disables |Okular KParts plugin steals

[okular] [Bug 407869] Markdown preview disables adding spaces

https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added Ever confirmed|0 |1 Component|plugin-preview

[okular] [Bug 407865] If rotating the view the annotations are not rotated

https://bugs.kde.org/show_bug.cgi?id=407865 --- Comment #2 from Luca Tagliacozzo --- (In reply to David Hurka from comment #1) > If you use the highlighter tool, do you get a “lens-shaped yellow object > arbitrary on the page”, like in Bug 334297? > If it is rotated clockwise 90 degree yes it

[okular] [Bug 334297] Highlighter of the review tool does not work correct in rotated views of the pdf document

https://bugs.kde.org/show_bug.cgi?id=334297 --- Comment #3 from David Hurka --- Created attachment 120266 --> https://bugs.kde.org/attachment.cgi?id=120266=edit Where the highlighting goes if the view is rotated Explaining the issue with a screenshot. Seems like Okular passes the wrong

D21364: Indicate annotation color in annotation list

jangmarker added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21364 To: jangmarker, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21364: Indicate annotation color in annotation list

jangmarker created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. jangmarker requested review of this revision. REPOSITORY R223 Okular BRANCH indicate-annotation-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D21364

[okular] [Bug 407865] If rotating the view the annotations are not rotated

https://bugs.kde.org/show_bug.cgi?id=407865 --- Comment #1 from David Hurka --- If you use the highlighter tool, do you get a “lens-shaped yellow object arbitrary on the page”, like in Bug 334297? It’s not really arbitrary, but positioned like you described it. The lens just looks pretty

[okular] [Bug 404506] Typewriter annotation tool font colour lost on resize

https://bugs.kde.org/show_bug.cgi?id=404506 --- Comment #8 from Rajeesh K V --- With poppler 0.73 and current Okular master (1.7.70), the colour of typewriter annotation is retained even after resizing. -- You are receiving this mail because: You are the assignee for the bug.

D21363: Fix build with poppler < 0.51

volkov added reviewers: Okular, sander. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21363 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

volkov added a comment. Sorry. I didn't add #include to formfields.h. Correct fix: D21363 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: aacid, joaonetto, okular-devel, tfella, ngraham,

D21363: Fix build with poppler < 0.51

volkov created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. volkov requested review of this revision. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21363 AFFECTED FILES

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #9 from Yuri

[okular] [Bug 407865] New: If rotating the view the annotations are not rotated

https://bugs.kde.org/show_bug.cgi?id=407865 Bug ID: 407865 Summary: If rotating the view the annotations are not rotated Product: okular Version: 1.3.3 Platform: Other OS: Linux Status: REPORTED Severity:

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 --- Comment #8 from mauro.miate...@virgilio.it --- libpoppler-qt5-1:amd64 0.62.0-2ubuntu2.8 is the last version in kde neon, there is newer version? :O -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 252596] okular printing options not working when printing to file (pdf/ps)

https://bugs.kde.org/show_bug.cgi?id=252596 azr...@googlemail.com changed: What|Removed |Added CC||azr...@googlemail.com -- You are

[okular] [Bug 401067] Fillable form fields in Okular may show up as "undefined"

https://bugs.kde.org/show_bug.cgi?id=401067 Alexandr Zamaraev (aka Tonal) changed: What|Removed |Added CC||tonal.proms...@gmail.com ---

[okular] [Bug 403632] Cannot handle some fields in PDF forms.

https://bugs.kde.org/show_bug.cgi?id=403632 Alexandr Zamaraev (aka Tonal) changed: What|Removed |Added CC||tonal.proms...@gmail.com ---

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

knambiar added a comment. In D21332#468893 , @tobiasdeiminger wrote: > Btw., can we do polylines yet? The only way I found was to tweak engine points attribute for tool type straight-line in `~/.config/okularpartrc`. Thanks for the PDF

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

knambiar updated this revision to Diff 58531. knambiar added a comment. Rebase against current master REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21332?vs=58459=58531 REVISION DETAIL https://phabricator.kde.org/D21332 AFFECTED FILES

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

tobiasdeiminger added a comment. `arc patch` fails, could you please rebase on current master? You may also want to add CCBUG : 381629 to the description. Besides that your changes look