[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 --- Comment #10 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

simgunz added a comment. To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary): d->aMouseModeMenu = new ToggleActionMenu( this ); d->aMouseModeMenu->addAction(

D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

simgunz added a comment. I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and

D15580: New annotation toolbar

simgunz updated this revision to Diff 60168. simgunz added a comment. - Remove unuseful annotation separators - Correctly set favorites action enabled - Properly trigger favorite action - Allow unchecking annotation actions - Minor refactor - Save state of continuous mode REPOSITORY

[okular] [Bug 408918] Scroll speed wont scale with zoom

https://bugs.kde.org/show_bug.cgi?id=408918 --- Comment #3 from David Hurka --- I still don’t understand what exactly should be different. But could you describe a situation in which scaling scrolling is helpful, and what is making problems while the user tries to complete a task? E. g. is

Moved to invent

https://invent.kde.org/kde/okular If you're interested press the Bell and change the setting to "Watch" Let's try to have all new MRs here instead of phabricator. Cheers, Albert

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander updated this revision to Diff 60149. sander marked an inline comment as done. sander added a comment. - Use `localPos` instead of `screenPos` - Factor out intermediate Pixmap size computations - Use `QPainterPath` for smoother paths REPOSITORY R223 Okular CHANGES SINCE LAST

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander marked an inline comment as done. sander added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in presentationwidget.cpp:900 > Maybe use a scoped > > const QSizeF pmSize { geom.width() * dpr, geom.height() * dpr }; > > instead of repeatedly recalculating width and height?

D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka marked 4 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755 To: davidhurka, #okular Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka updated this revision to Diff 60144. davidhurka added a comment. - Set popup mode of Color Mode menu, because ToggleActionMenu respects it now. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21195?vs=60109=60144 BRANCH

D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka retitled this revision from "[WIP] Replace ToolAction by a more universal “ToggleActionMenu”" to "[RFC] Replace ToolAction by a more universal “ToggleActionMenu”". davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka updated this revision to Diff 60141. davidhurka added a comment. - Select correct default action at startup - Describe name ToggleActionMenu - Let the toolbar buttons respect menu properties like enabled state, and add the menu to updateActionStates(). - Make popup mode

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

ngraham added a comment. I don't have one, sorry. LGTM as-is though. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka edited the summary of this revision. davidhurka added a dependency: D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham,

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka added a dependent revision: D21195: [RFC] Create a Change Colors menu (with toolbar button). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755 To: davidhurka, #okular Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham,

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka edited the summary of this revision. davidhurka edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham, okular-devel, fbampaloukas, joaonetto, tfella,

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka marked an inline comment as done. davidhurka added a comment. In D21195#477747 , @ngraham wrote: > I would recommend making the toolbar button show the text of the actual color change mode that's currently active, much like how the

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka updated this revision to Diff 60109. davidhurka added a comment. - Fix rebase on D21755 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21195?vs=60108=60109 BRANCH create-change-colors-menu REVISION DETAIL

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka updated this revision to Diff 60108. davidhurka added a comment. - Rebase on D21755 , to use ToggleActionMenu. - Show the last used color mode on the toolbar button of the Color Mode menu. (Normal Colors is a radio option now, like the other

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755 To: davidhurka, #okular Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

tobiasdeiminger added a comment. In D21836#482214 , @sander wrote: > Ping? Nice patch. Maybe someone with a real HiDPI setup (I can only fake it) should have a look at it too. REPOSITORY R223 Okular REVISION DETAIL

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

tobiasdeiminger added inline comments. INLINE COMMENTS > presentationwidget.cpp:900 > > -QPixmap pm( geom.size() ); > +QPixmap pm( QSize( geom.size().width() * dpr, geom.size().height() * > dpr ) ); > pm.fill( Qt::transparent ); Maybe use a scoped const QSizeF

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added a comment. Path quality gets even better (slightly) if I replace the sequence of lines drawn by `SmoothPathEngine` with a `QPainterPath`. Do you prefer this change right here or in a separate patch on top? REPOSITORY R223 Okular REVISION DETAIL

[okular] [Bug 377487] Find and highlight all instances of a searched word

https://bugs.kde.org/show_bug.cgi?id=377487 cappelloro...@riseup.net changed: What|Removed |Added CC||cappelloro...@riseup.net -- You are

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added reviewers: ngraham, tobiasdeiminger. sander added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D21910: Preferences dialog is resized from its default size, such that the complete content is visible.

ngraham added a comment. If KConfigDialog is calculating default window sizes incorrectly under certain circumstances, then it probably should be changed. :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21910 To: mayankchoudhary, ngraham, #okular Cc: ngraham,