D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

davidhurka added a comment. In D21755#483631 , @simgunz wrote: > What I am probably not understanding is. Is `ToggleActionMenu` meant to be a general component that you want to use in other parts of KDE? Or is it just meant for Okular?

D21971: [DEMO] Enhance ToggleActionMenu with ImplicitDefaultAction mode.

davidhurka added a comment. In D21971#503218 , @simgunz wrote: > Suggested changes: > > - Make `QToolButton::MenuButtonPopup`, and `ToggleActionMenu::ImplicitDefaultAction` the defaults in the constructor so we can call it as

[okular] [Bug 410320] New: Printing of range does not work

https://bugs.kde.org/show_bug.cgi?id=410320 Bug ID: 410320 Summary: Printing of range does not work Product: okular Version: 1.7.3 Platform: Other OS: Linux Status: REPORTED Severity: normal

D21971: [DEMO] Enhance ToggleActionMenu with ImplicitDefaultAction mode.

davidhurka added a comment. @simgunz Thanks for your feedback. I have just got some more private to-do, so if I do not look at your feedback later today, please wait at least until wednesday. :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka

[okular] [Bug 410315] New: reviews: show preview of review, outline selected review as Adobe Acrobat reader does

https://bugs.kde.org/show_bug.cgi?id=410315 Bug ID: 410315 Summary: reviews: show preview of review, outline selected review as Adobe Acrobat reader does Product: okular Version: 1.6.3 Platform: Other OS:

D15580: [WIP] New annotation toolbar

simgunz added a comment. With the latest push all the features of the toolbar are implemented. There are some horrible things in the code, but I will clean and refactor it. Now it is time for you to test the toolbar and provide me feedback on the UI / UX please. (No need to comment on

D15580: [WIP] New annotation toolbar

simgunz updated this revision to Diff 62679. simgunz added a comment. - Fix detach annotation when mouse mode unchecked REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=62678=62679 BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL

D15580: [WIP] New annotation toolbar

simgunz updated this revision to Diff 62678. simgunz added a comment. - Use ToggleActionMenu - Add stamp annotation - Fix swap straight line and arrow - Use Title style capitalization - Show real stamp symbols if squared - Better stamp icon REPOSITORY R223 Okular CHANGES SINCE

D21971: [DEMO] Enhance ToggleActionMenu with ImplicitDefaultAction mode.

simgunz added a comment. I did test this today and it seems to be working correctly, at least in the use cases of Okular, i.e. for select annotation tools and for the annotation toolbar. Actually I am currently using in D15580 now (will push soon), given