[okular] [Bug 411909] Unable remove the second bookmark on the single pdf page

https://bugs.kde.org/show_bug.cgi?id=411909 --- Comment #7 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D15580: New annotation toolbar

aacid added a comment. Doesn't need this a docbook update? REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid,

D15580: New annotation toolbar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm happy with the UI now. :) Subsequent improvements and polish can be delivered in follow-up patches. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu

D15580: New annotation toolbar

simgunz updated this revision to Diff 68843. simgunz added a comment. - Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=68813=68843 BRANCH

D15580: New annotation toolbar

yurchor added a comment. Can the patch be rebased against the current git/master for testing and preliminary documentation rewrite? Thanks in advance for your work. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: yurchor,

D15580: New annotation toolbar

ngraham added a comment. `window-close-symbolic` is black instead of red FWIW. Maybe we should just use that for now @trickyricky26 and #vdg , I do agree that our red close buttons draw too much attention to themselves for non-destructive close

D15580: New annotation toolbar

simgunz added a comment. > Semantically, the icon you used (something like `tab-close`) would be correct, but I think it looks too much like a destructive action, with it being red in a circle. Considering this only closes the toolbar, which you can open again at any time, I think this icon

D15580: New annotation toolbar

trickyricky26 added a comment. In D15580#554598 , @simgunz wrote: > Is the icon fine for the toolbar hide/close button? Do you have a better suggestion? > > F7674605: Screenshot_20191027_092856.png >

D15580: [WIP] New annotation toolbar

simgunz added a comment. In D15580#554104 , @davidhurka wrote: > In D15580#554079 , @simgunz wrote: > > > Should I configure the toolbar so that if the user changes to "text alongside icons" the

D15580: New annotation toolbar

simgunz retitled this revision from "[WIP] New annotation toolbar" to "New annotation toolbar". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham,

D15580: [WIP] New annotation toolbar

simgunz added a comment. Regarding unchecking the mouse mode actions when an annotation is selected. As for now I think this is extremely complex to implement. I suggest leaving it as is for now, and once Qt 5.14 is out we can use the new option that allows unchecking all actions in a

D15580: [WIP] New annotation toolbar

simgunz added a comment. Is the icon fine for the toolbar hide/close button? Do you have a better suggestion? F7674605: Screenshot_20191027_092856.png *Hide toolbar button* REPOSITORY R223 Okular REVISION DETAIL

D15580: [WIP] New annotation toolbar

simgunz updated this revision to Diff 68813. simgunz marked 4 inline comments as done. simgunz added a comment. - Add action to hide the annotation toolbar - Preserve user-defined annotation tools - Remove unsueful initialization REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D15580: [WIP] New annotation toolbar

simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in shell.cpp:370 > >> @simgunz just wrote: > > > > https://phabricator.kde.org/D15580#544534 > > That’s what I thought about. :) Initially I put that action in `part.rc`, while now I moved it to `shell.rc`. This makes more