This revision was automatically updated to reflect the committed changes.
Closed by commit R223:3e48663fb764: Use a target in FindDiscount (modern cmake)
rather than variables (authored by svuorela).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
svuorela added a comment.
1. The current code only works if discount is installed into existing
locations (discount_INCLUDE_DIR is never used), and as a user of the
FindPackage, you don't have to care about the include directory. It comes from
the target.
2. The whole thing with targets
svuorela added a comment.
It is not a quest to make qrc work. it is just a "don't crash if such a thing
is received". Will add some spaces.
REPOSITORY
R223 Okular
BRANCH
Applications/18.04
REVISION DETAIL
https://phabricator.kde.org/D12643
To: svuorela, aacid
Cc: #okular, ngraham,
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:13bdb97084d2: Dont crash if fopen fails (authored
by svuorela).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12643?vs=33444=33445
REVISION DETAIL
svuorela created this revision.
svuorela added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
svuorela requested review of this revision.
REVISION SUMMARY
If we have a qrc url, all checks so far fails, and this one returns
svuorela updated this revision to Diff 33436.
svuorela added a comment.
Fix review comments
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12643?vs=33426=33436
BRANCH
Applications/18.04
REVISION DETAIL
https://phabricator.kde.org/D12643
AFFECTED
svuorela updated this revision to Diff 33444.
svuorela added a comment.
Add spaces around if.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12643?vs=33436=33444
BRANCH
Applications/18.04
REVISION DETAIL
https://phabricator.kde.org/D12643
AFFECTED
svuorela created this revision.
svuorela added a reviewer: kde-buildsystem.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
svuorela requested review of this revision.
TEST PLAN
Things still builds
REPOSITORY
R223 Okular
BRANCH
https://bugs.kde.org/show_bug.cgi?id=474211
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #2 from Sune
https://bugs.kde.org/show_bug.cgi?id=476319
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Resolution
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #14 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #12)
> Created attachment 162025 [details]
> backend settings
>
> See the settings
Please file a bug report to whomever provides your poppler binari
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #16 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #15)
> (In reply to Sune Vuorela from comment #14)
> > (In reply to Philippe ROUBACH from comment #12)
> > > Created attachment 162025 [details]
>
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #9 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #6)
> It seems that kde policy is to use gpg store. Why not okular ?
This was released as part of okular 23.08 (requires a similar new-ish poppler
library, at least 23
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #11 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #10)
> okular 23.08.1
> poppler 23.09
>
> Issue still there :
> okular by default does not point to ~/.gnupg/ and when we customize the path
> to ~/.
https://bugs.kde.org/show_bug.cgi?id=439595
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #6 from Sune
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #19 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #17)
> Thanks
>
> If I understand well, we need:
> - okular default certificate folder is ~.gnupg
> - gpg 2.4.1 or later
> - we need poppler built
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #22 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #21)
> Why Okular does not use the same technology as kleopatra, kmail or
> LibreOffcie ?
The work I did in poppler uses the exact same technology as kleopatra and
https://bugs.kde.org/show_bug.cgi?id=474299
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #2 from Sune
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #25 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #24)
> Created attachment 162271 [details]
> no gpg certificate
>
> Hello
>
> OpenSUSE tumbleweed supplies :
> - gpg2 2.4.3
> - poppler
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #28 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #27)
> >> And you have your x509 certificates in your gpg store ?
>
> why you speak about x509 certificate ?
>
> I speak about gpg certificates.
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #29 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #26)
> :~> gpgsm --list-secret-keys
> /home/roubach/.gnupg/pubring.kbx
>
So okular's dialog matches what you have in the key
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #31 from Sune Vuorela ---
> It is too techie for me. What I understand is :
> - the pdf standard for digital signing is only using a x509 certificate.
> - in the standard, there is no way for digital signing with an OpenPGP
>
https://bugs.kde.org/show_bug.cgi?id=473560
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=473415
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #2 from Sune
https://bugs.kde.org/show_bug.cgi?id=459173
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #4 from Sune
https://bugs.kde.org/show_bug.cgi?id=459173
--- Comment #6 from Sune Vuorela ---
(In reply to Robert Riemann from comment #5)
> > What version of poppler (The underlying pdf library) are you using ?
> >
> > The double-pin should be fixed I think, by poppler 23.04, maybe 23.0
https://bugs.kde.org/show_bug.cgi?id=443403
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #23 from Sune
https://bugs.kde.org/show_bug.cgi?id=468630
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #5 from Sune
https://bugs.kde.org/show_bug.cgi?id=467144
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=470128
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=471792
--- Comment #4 from Sune Vuorela ---
(In reply to Joe Breuer from comment #3)
> (In reply to Sune Vuorela from comment #1)
> > Some versions did embed the same fonts multiple times, and your "big"
> > document contains
https://bugs.kde.org/show_bug.cgi?id=471792
--- Comment #6 from Sune Vuorela ---
(In reply to Joe Breuer from comment #2)
> Trying a 23.07 bump is not immediately accessible to me, since there's
> apparently no release or even git tag yet. Not sure that I want to run git
> master on a p
https://bugs.kde.org/show_bug.cgi?id=470446
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=462312
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |UPSTREAM
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=470751
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=469829
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #2 from Sune
https://bugs.kde.org/show_bug.cgi?id=469829
--- Comment #4 from Sune Vuorela ---
Poppler is the underlying library that Okular uses for rendering pdf's and for
writing annotations into pdf's.
What version of poppler are you using ?
The version `alstjr7375` is using has a bug that was fixed
https://bugs.kde.org/show_bug.cgi?id=470174
--- Comment #5 from Sune Vuorela ---
(In reply to der.wolfgang.amadeus.mozart from comment #4)
> Comment on attachment 159566 [details]
> Annotated File from March 2023 with "normal" storage consumption
>
> I found a file with a
https://bugs.kde.org/show_bug.cgi?id=470174
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #2 from Sune
https://bugs.kde.org/show_bug.cgi?id=462312
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #5 from Sune
https://bugs.kde.org/show_bug.cgi?id=469829
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |UPSTREAM
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=471259
--- Comment #5 from Sune Vuorela ---
(In reply to mabobakrelsedik86 from comment #2)
> (In reply to Sune Vuorela from comment #1)
> > Is it the same okular version?
> >
> > What version of the underlying "Poppler&q
https://bugs.kde.org/show_bug.cgi?id=471259
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=471173
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Resolution
https://bugs.kde.org/show_bug.cgi?id=471792
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=467144
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=470128
--- Comment #4 from Sune Vuorela ---
(In reply to dorla.hutch from comment #3)
> (In reply to dorla.hutch from comment #2)
> > From initially 23KiB, it went to 20MiB (at least
> > not 100MiB) …
>
> After adding the comment box
https://bugs.kde.org/show_bug.cgi?id=469664
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #3 from Sune
https://bugs.kde.org/show_bug.cgi?id=469664
--- Comment #4 from Sune Vuorela ---
Any chance you can compile a patched poppler ?
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1384
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=469664
--- Comment #6 from Sune Vuorela ---
(In reply to Gaël de Chalendar (aka Kleag) from comment #5)
> This has already been merged. Should I compile it and test it? If yes, how
> can I retrieve the correct version?
The correct version would be git
https://bugs.kde.org/show_bug.cgi?id=469664
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |UPSTREAM
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=469705
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #4 from Sune
https://bugs.kde.org/show_bug.cgi?id=469705
--- Comment #7 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #6)
> It seems that kde policy is to use gpg store. Why not okular ?
It's coming.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=469882
--- Comment #7 from Sune Vuorela ---
With a fixed poppler, it is also some degree of "cannot validate signature"
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=469882
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=469882
--- Comment #4 from Sune Vuorela ---
Thanks. Crash happens in poppler. Merge-request submitted.
Neither the current NSS backend nor the upcoming GPG backend supports GOST as a
hash algorithm though, so neither can validate the signature. I also don't
https://bugs.kde.org/show_bug.cgi?id=353300
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #6 from Sune
https://bugs.kde.org/show_bug.cgi?id=48
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=481262
--- Comment #4 from Sune Vuorela ---
(In reply to Albert Astals Cid from comment #3)
> (In reply to Ingo Klöcker from comment #2)
> > Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or
> that makes sense
https://bugs.kde.org/show_bug.cgi?id=481262
--- Comment #7 from Sune Vuorela ---
(In reply to Ingo Klöcker from comment #5)
> I think a good name for the NSS backend depends on how it behaves on
> different OSes, i.e. if it uses the Windows/macOS certificate store on
> Wind
https://bugs.kde.org/show_bug.cgi?id=481262
--- Comment #11 from Sune Vuorela ---
Git commit 3518099a08f0b129e6be8c8216ecb5fc0bf38273 by Sune Vuorela.
Committed on 20/02/2024 at 13:57.
Pushed by sune into branch 'release/24.02'.
Better user strings for signature settings
M +9-4
https://bugs.kde.org/show_bug.cgi?id=479141
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://bugs.kde.org/show_bug.cgi?id=479141
Sune Vuorela changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
https://bugs.kde.org/show_bug.cgi?id=481534
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Resolution
https://bugs.kde.org/show_bug.cgi?id=479141
Sune Vuorela changed:
What|Removed |Added
CC||m...@iyanmv.com
--- Comment #12 from Sune
https://bugs.kde.org/show_bug.cgi?id=481266
--- Comment #3 from Sune Vuorela ---
(In reply to Philippe ROUBACH from comment #2)
> In this case, it would be a good thing that Okular, at the first opening,
> creates automatically an S/MIME OpenPGP certificate with Kleopatra.
In general,
https://bugs.kde.org/show_bug.cgi?id=481262
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=481266
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=463647
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #4 from Sune
https://bugs.kde.org/show_bug.cgi?id=478729
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=478304
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #7 from Sune
https://bugs.kde.org/show_bug.cgi?id=478729
--- Comment #2 from Sune Vuorela ---
I did investigate the file a bit, and it is a quite bad file.
I don't know if it is so bad that we shouldn't be able to recover from it, but
it looks like we at least don't fully do it.
This is a bit pdf
https://bugs.kde.org/show_bug.cgi?id=479110
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|NEEDSINFO
Resolution
https://bugs.kde.org/show_bug.cgi?id=479108
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://bugs.kde.org/show_bug.cgi?id=479142
Sune Vuorela changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Latest Commit
https://bugs.kde.org/show_bug.cgi?id=479683
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Resolution
https://bugs.kde.org/show_bug.cgi?id=479110
Sune Vuorela changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=479942
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=479942
Sune Vuorela changed:
What|Removed |Added
Keywords|qt6 |
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=479942
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|CONFIRMED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=479942
Sune Vuorela changed:
What|Removed |Added
Keywords|qt6 |
--- Comment #3 from Sune Vuorela ---
not qt6
https://bugs.kde.org/show_bug.cgi?id=479777
Sune Vuorela changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=479122
--- Comment #4 from Sune Vuorela ---
Git commit 55901afcc3a0d42dbec216ec43426dd6c8e3a2fd by Sune Vuorela.
Committed on 09/01/2024 at 11:10.
Pushed by sune into branch 'master'.
Install parts into the right folder
M +1-2CMakeLists.txt
https
https://bugs.kde.org/show_bug.cgi?id=479122
Sune Vuorela changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=479122
--- Comment #6 from Sune Vuorela ---
Git commit 671107c0e53daf80065708daab7505d8f1a36371 by Sune Vuorela.
Committed on 09/01/2024 at 19:17.
Pushed by sune into branch 'master'.
KParts can extend their mimetypes with plugins
Certain KParts can extend
svuorela closed subtask T11539: Port Okular away from KHTML as
Resolved.
TASK DETAIL
https://phabricator.kde.org/T11542
To: svuorela
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications,
#frameworks, knauss, cpmontanari, ghost62, hannahk, davidre, GB_2, ahmadsamir,
https://bugs.kde.org/show_bug.cgi?id=480485
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=480485
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=477108
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=477108
--- Comment #3 from Sune Vuorela ---
(In reply to igor.mach...@gmail.com from comment #2)
> Ok Sune, thanks for the feedback. I opened this issue because I couldn't
> find any other one, but I was imagining that others would exist somewhere
https://bugs.kde.org/show_bug.cgi?id=477108
--- Comment #4 from Sune Vuorela ---
(In reply to igor.mach...@gmail.com from comment #2)
> Regarding flatpak, that's strange indeed, and perhaps it's not related to
> okular itself... For me, on Ubuntu 22.04, I'm forced to use flatpak to have
&g
https://bugs.kde.org/show_bug.cgi?id=477136
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|RESOLVED
CC
https://bugs.kde.org/show_bug.cgi?id=402017
Sune Vuorela changed:
What|Removed |Added
CC||chronoan...@web.de
--- Comment #78 from Sune
https://bugs.kde.org/show_bug.cgi?id=485747
Sune Vuorela changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=484938
Sune Vuorela changed:
What|Removed |Added
CC||follow...@163.com
--- Comment #4 from Sune
https://bugs.kde.org/show_bug.cgi?id=486186
Sune Vuorela changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=486680
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #1 from Sune
https://bugs.kde.org/show_bug.cgi?id=482682
--- Comment #7 from Sune Vuorela ---
(Note to the other okular people; This is most probably an issue in poppler,
and I'm looking at that. While it would be most correct to close the bug here
and reopen it in poppler ( https://gitlab.freedesktop.org
https://bugs.kde.org/show_bug.cgi?id=483678
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
--- Comment #9 from Sune
https://bugs.kde.org/show_bug.cgi?id=483968
Sune Vuorela changed:
What|Removed |Added
CC||k...@pusling.com
Status|REPORTED
1 - 100 of 112 matches
Mail list logo
