[OPEN-ILS-DEV] PATCH: osrf_stack.c (miscellaneous)

2008-12-05 Thread Scott McKellar
This patch started out mostly as a refactoring, but it turned into a bug fix. 1. In osrf_stack_transport_handler(): removed the memset() as pointless. 2. Also in osrf_stack_transport_handler(), in the loop traversing arr[]: changed the loop condition from i != num_msgs to i num_msgs,

[OPEN-ILS-DEV] PATCH: clark-kent.pl

2008-12-05 Thread Brandon W. Uhlman
This very trivial patch to clark-kent.pl fixes an zero-indexing vs. one-indexing error when substringing the name of a report to generate the name of an Excel worksheet when producing the Excel version of a report. It's simple enough that I don't think it requires a DCO. While checking the

Re: [OPEN-ILS-DEV] PATCH: utils.[ch] (miscellaneous)

2008-12-05 Thread Mike Rylander
On Tue, Dec 2, 2008 at 11:24 AM, Scott McKellar [EMAIL PROTECTED] wrote: These patches do several little things: -- Adds a new macro buffer_length to return the n_used member of a growing buffer. -- Changed buffer_chomp() to return the character removed instead of the new string length.

Re: [OPEN-ILS-DEV] PATCH: srfsh.c (camel case)

2008-12-05 Thread Mike Rylander
On Wed, Dec 3, 2008 at 10:51 AM, Scott McKellar [EMAIL PROTECTED] wrote: I stumbled across another redundant and deprecated identifier. This patch replaces osrf_app_session_connect with osrfAppSessionConnect. And ... applied. Scott McKellar Developer's Certificate of Origin 1.1 By making

[OPEN-ILS-DEV] problem importing

2008-12-05 Thread Grant Johnson
Hey all, I can't import a set of records in EG 1.2.2.0. Works fine in 1.2.2.3 VM. # perl marc2bre.pl seems to generate the .bre sucessfully ... but I get the following when I run # perl direct_ingest.pl Any solutions? Couldn't process record: Undefined namespace prefix

Re: [OPEN-ILS-DEV] PATCH: osrf_app_session.[ch] (miscellaneous)

2008-12-05 Thread Mike Rylander
On Wed, Dec 3, 2008 at 7:22 PM, Scott McKellar [EMAIL PROTECTED] wrote: These patches do various things: Applied to trunk, but see below for a question. 1. Move the declaration of osrf_app_request_struct, and its typedef as osrfAppRequest, out of the header and into osrf_app_session.c. 2.

Re: [OPEN-ILS-DEV] problem importing

2008-12-05 Thread Dan Scott
Hi Grant: What version of XML::LibXML and XML::LibXSLT are reported by settings-tester.pl? There were known problems with XML::LibXML 1.66, 1.69 (the most up to date version from CPAN) is recommended. And geez, what are you doing importing into 1.2.2.0? Dan 2008/12/5 Grant Johnson [EMAIL

Re: [OPEN-ILS-DEV] problem importing

2008-12-05 Thread Grant Johnson
Sorry... 1.2.2.3 in a 1.2.2.0 Open-ILS folder... I think... :-) XML::LibXML version 1.66 XML::LibXML::XPathContext version 1.66 XML::LibXSLT version 1.59 -- F. Grant Johnson Systems Coordinator Robertson Library - UPEI 566-0630 (w), 393-4920 (c) On 12/5/2008 at 4:03 PM, in message

Re: [OPEN-ILS-DEV] problem importing

2008-12-05 Thread Dan Scott
2008/12/5 Grant Johnson [EMAIL PROTECTED]: Sorry... 1.2.2.3 in a 1.2.2.0 Open-ILS folder... I think... :-) XML::LibXML version 1.66 XML::LibXML::XPathContext version 1.66 XML::LibXSLT version 1.59 Yup, install the updated versions from CPAN and you should be a lot happier. As root: cpan

Re: [OPEN-ILS-DEV] PATCH: clark-kent.pl

2008-12-05 Thread Mike Rylander
On Fri, Dec 5, 2008 at 2:06 PM, Brandon W. Uhlman [EMAIL PROTECTED] wrote: This very trivial patch to clark-kent.pl fixes an zero-indexing vs. one-indexing error when substringing the name of a report to generate the name of an Excel worksheet when producing the Excel version of a report. It's

[OPEN-ILS-DEV] AUTO: Elaine Ross is out of the office (returning 12/15/2008)

2008-12-05 Thread Elaine Ross/mlc
I am out of the office until 12/15/2008. Please contact Evette Atkin or Ruth Dukelow in my absence. Evette - [EMAIL PROTECTED] 800-530-9019 ext. 152 Ruth - [EMAIL PROTECTED] 800-530-9019 ext.121 Note: This is an automated response to your message Re: [OPEN-ILS-DEV] problem importing sent

[OPEN-ILS-DEV] PATCH: string_array.[ch] (camel case)

2008-12-05 Thread Scott McKellar
These patches eliminate the following deprecated identifiers: string_array init_string_array string_array_add string_array_get_string string_array_destroy These identifiers have already been eliminated from all other source files. Scott McKellar

Re: [OPEN-ILS-DEV] PATCH: osrf_message.h (camel case)

2008-12-05 Thread Mike Rylander
On Fri, Nov 28, 2008 at 10:04 AM, Scott McKellar [EMAIL PROTECTED] wrote: This patch eliminates the deprecated typedef osrf_message, replacing it with the camel case equivalent osrfMessage. All other occurrences have slready been eliminated from the source tree. Applied. --miker Scott

Re: [OPEN-ILS-DEV] PATCH: string_array.[ch] (camel case)

2008-12-05 Thread Mike Rylander
On Fri, Nov 28, 2008 at 11:15 AM, Scott McKellar [EMAIL PROTECTED] wrote: These patches eliminate several deprecated identifiers in favor of their camel case equivalents. All these identifiers have already been eliminated from elsewhere in the source tree: string_array ==